Repository navigation
Commit f062679
test(desktop): pin members sidebar visible order to full canonical npub
The full-npub ordering change bound its five unit cases to
compareMembersByRole only. The visible members-sidebar roster sorts
through compareMembersForModal, whose delegation to the shared name
stage had no regression: reverting just that delegation back to
formatMemberName(...).localeCompare kept every existing test green.
Add one focused e2e case on the existing small-sidebar workflow
seams: the two unnamed fixtures from the memberUtils unit pair join
the three-member "random" roster — both visible in the initial
virtual window, no 500-member roster needed — arriving in the
opposite of the expected order, and the rendered roster must place
V24 before V5. The full canonical npubs disagree with the compact
labels for exactly this pair, so a display-label order fails the
assertion.
Falsified against ec7a9cf by reverting only the modal delegation
(byte-identical to parent a1ffa77): the new case failed at the
order assertion while both existing members-sidebar workflows stayed
green; restored production passes all three. Production files are
untouched and byte-identical to ec7a9cf.
Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
Signed-off-by: Logan Johnson <[email protected]>1 parent 28e3241 commit f062679
1 file changed
Lines changed: 60 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
30 | 39 | | |
31 | 40 | | |
32 | 41 | | |
| |||
4254 | 4263 | | |
4255 | 4264 | | |
4256 | 4265 | | |
| 4266 | + | |
| 4267 | + | |
| 4268 | + | |
| 4269 | + | |
| 4270 | + | |
| 4271 | + | |
| 4272 | + | |
| 4273 | + | |
| 4274 | + | |
| 4275 | + | |
| 4276 | + | |
| 4277 | + | |
| 4278 | + | |
| 4279 | + | |
| 4280 | + | |
| 4281 | + | |
| 4282 | + | |
| 4283 | + | |
| 4284 | + | |
| 4285 | + | |
| 4286 | + | |
| 4287 | + | |
| 4288 | + | |
| 4289 | + | |
| 4290 | + | |
| 4291 | + | |
| 4292 | + | |
| 4293 | + | |
| 4294 | + | |
| 4295 | + | |
| 4296 | + | |
| 4297 | + | |
| 4298 | + | |
| 4299 | + | |
| 4300 | + | |
| 4301 | + | |
| 4302 | + | |
| 4303 | + | |
| 4304 | + | |
| 4305 | + | |
| 4306 | + | |
| 4307 | + | |
| 4308 | + | |
| 4309 | + | |
| 4310 | + | |
| 4311 | + | |
| 4312 | + | |
| 4313 | + | |
| 4314 | + | |
| 4315 | + | |
| 4316 | + | |
4257 | 4317 | | |
4258 | 4318 | | |
4259 | 4319 | | |
| |||
0 commit comments