Skip to content

Commit e7b8434

Browse files
loganjLarry
andcommitted
test(desktop): restore baseline Welcome ambiguous-submit regression
The independent extraction of this PR removed the fixed-root Welcome sequence that submits an ambiguous typed mention and asserts the visible error, the preserved draft, the still-prompt banner and no published event. Those assertions are baseline negative coverage for this suite, not newly owned recovery evidence, so they are restored after the new roster-freshness wait and before the unchanged exact-current-starter selection. The production fix for the visible failure is the independent composer recovery work; until it lands, this journey is expected to fail on the fixed root, and no green claim is made for it here. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <[email protected]>
1 parent 2132927 commit e7b8434

1 file changed

Lines changed: 19 additions & 2 deletions

File tree

‎desktop/tests/e2e/onboarding.spec.ts‎

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -498,9 +498,26 @@ async function expectWelcomeComposerBannerCompletesAfterPersonaMention(
498498
await expect(banner).toHaveAttribute("data-state", "prompt");
499499
expect(await sentRecipients()).toEqual([]);
500500

501+
// Baseline regression restored from the fixed root: a manually typed
502+
// colliding name must fail visibly, keep the draft, and publish nothing.
503+
// The production fix for that visible failure is the independent composer
504+
// recovery work; until it lands, this sequence is expected to fail on the
505+
// fixed root.
506+
await input.fill(content);
507+
await input.press("Escape");
508+
await page.getByTestId("send-message").click();
509+
await expect(
510+
page.getByText("The mention @Fizz is ambiguous.", { exact: false }),
511+
).toBeVisible();
512+
await expect(input).toHaveText(content);
513+
await expect(banner).toHaveAttribute("data-state", "prompt");
514+
expect(await sentRecipients()).toEqual([]);
515+
501516
// This freshness prefix retains both colliding starters in the roster and
502-
// selects the exact current starter. Ambiguous-send error/draft recovery is
503-
// owned by the independent composer recovery PR, not directory freshness.
517+
// selects the exact current starter. Make selection intent explicit; do
518+
// not remove the colliding fixture or relax extraction. The resulting event
519+
// must tag only our starter identity.
520+
await input.fill("");
504521
await input.fill(content);
505522
await page.getByTestId(`mention-suggestion-${fizz[0].pubkey}`).click();
506523
await page.getByTestId("send-message").click();

0 commit comments

Comments
 (0)