Repository navigation
Commit e6068d0
committed
feat(desktop): flatten custom harness form and align it with modal form styling
- CustomHarnessForm.tsx: remove the Advanced accordion — ID (auto-derived),
arguments, env vars, docs URL, and install hint now render inline below
Name and Command; Name and ID share one row
- Restyle all fields to match the Create agent dialog: PERSONA_FIELD_SHELL_CLASS
input shells (min-h-11), text-sm font-medium labels with
PERSONA_LABEL_OPTIONAL_CLASS hints, space-y-5 rhythm, and outline-variant
add-row buttons in the args/env editors
- Chromeless (catalog dialog) mode becomes a full-height flex column: the
header and fields scroll in a flex-1 overflow-y-auto body while the Save
footer stays pinned below a top border; new `header` prop lets the dialog's
title block scroll with the form
- Disable Save until required fields are satisfied (Name/Command/ID non-blank,
no empty arg or env-key rows); drop the redundant Cancel CTA — dismissal
lives on the dialog close and inline-card X
- HarnessCatalogDialog.tsx: give the custom entry its own non-scrolling
detail-pane layout so the form manages its own scroll region
- Update harness-management and harness-catalog-screenshots e2e specs for the
removed Advanced disclosure (fields asserted inline, one form screenshot)
Co-authored-by: Taylor Ho <[email protected]>
Signed-off-by: Taylor Ho <[email protected]>1 parent 94c8137 commit e6068d0
4 files changed
Lines changed: 262 additions & 205 deletions
File tree
- desktop
- src/features/settings/ui
- tests/e2e
0 commit comments