Repository navigation
Commit e5515f7
test(mobile): match the hop diagnostic's doc to its output, use it for every reply
Two optional suggestions from the final review of 93d426da1.
The `waitForCallback` doc comment quoted example failures the helper cannot
print: the hop is capped at 2 s, so "took 7.2 s" never occurs, and durations
print as "%.1f ms". It now quotes the real forms ("did not finish within
2 s", hundreds of ms, "took 0.4 ms"), states that the hop is measured after
the 10 s window so a fast hop does not rule out starvation that ended at
the deadline, and presents the 2026-11-01 diagnosis as an inference, since
the measurement did not exist in those runs.
`testAllowedNotificationRestoreNeedsNoAppGroupStore` used a plain
`wait(for:)`; it now goes through `waitForCallback`, so every bridge-reply
wait in the class carries the hop report.
Verification: class in isolation green once (6 tests, 0.05 s); `git diff
--check` clean; the commit touches only this file, with no Podfile.lock,
xcshareddata, or Dart changes.
Co-Authored-By: Claude Fable 5.1 <[email protected]>
Signed-off-by: Matt Toohey <[email protected]>1 parent 6cc43c9 commit e5515f7
1 file changed
Lines changed: 9 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
258 | 261 | | |
259 | 262 | | |
260 | 263 | | |
| |||
341 | 344 | | |
342 | 345 | | |
343 | 346 | | |
344 | | - | |
| 347 | + | |
345 | 348 | | |
346 | 349 | | |
347 | 350 | | |
| |||
0 commit comments