Skip to content

Commit e3008b3

Browse files
wpfleger96npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7
andauthored
fix(personas): remove goose runtime pin from Fizz built-in (#1566)
Signed-off-by: Will Pfleger <[email protected]> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
1 parent 08e707e commit e3008b3

3 files changed

Lines changed: 50 additions & 11 deletions

File tree

‎desktop/src-tauri/src/managed_agents/personas.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ const BUILT_IN_PERSONAS: &[BuiltInPersona] = &[
119119
"Orchard", "Buzz",
120120
],
121121
model: None,
122-
runtime: Some("goose"),
122+
runtime: None,
123123
default_active: true,
124124
},
125125
BuiltInPersona {

‎desktop/src-tauri/src/managed_agents/personas/tests.rs‎

Lines changed: 39 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
use super::{
2-
ensure_persona_ids_are_active, ensure_persona_is_active, merge_personas,
3-
migrate_retired_personas, validate_persona_activation_change, validate_persona_deletion,
4-
BUILT_IN_PERSONAS, RETIRED_PERSONAS,
2+
built_in_persona_records, ensure_persona_ids_are_active, ensure_persona_is_active,
3+
merge_personas, migrate_retired_personas, validate_persona_activation_change,
4+
validate_persona_deletion, BUILT_IN_PERSONAS, RETIRED_PERSONAS,
55
};
6+
use crate::managed_agents::discovery::{default_agent_command, effective_agent_command};
67
use crate::managed_agents::validate_team_id;
78
use crate::managed_agents::PersonaRecord;
89

@@ -35,7 +36,7 @@ fn merge_personas_adds_missing_built_ins() {
3536
assert!(records.iter().all(|record| record.is_builtin));
3637
assert!(records
3738
.iter()
38-
.any(|record| record.id == "builtin:fizz" && record.runtime.as_deref() == Some("goose")));
39+
.any(|record| record.id == "builtin:fizz" && record.runtime.is_none()));
3940
assert!(records
4041
.iter()
4142
.any(|record| record.id == "builtin:product-strategist" && !record.is_active));
@@ -479,3 +480,37 @@ fn migrate_is_idempotent() {
479480
// 4. Run again on result of (3) — should be no-op.
480481
assert!(!migrate_retired_personas(&mut stored_pre_demotion, now));
481482
}
483+
484+
// ── Fizz default harness ──────────────────────────────────────────────────────
485+
486+
#[test]
487+
fn fizz_builtin_has_no_pinned_runtime() {
488+
// The Fizz built-in must not hard-pin a runtime so it inherits the
489+
// bundled default (buzz-agent) rather than requiring goose on PATH.
490+
let records = built_in_persona_records("2026-01-01T00:00:00Z");
491+
let fizz = records
492+
.iter()
493+
.find(|r| r.id == "builtin:fizz")
494+
.expect("builtin:fizz must exist");
495+
assert_eq!(
496+
fizz.runtime, None,
497+
"Fizz built-in must not pin a runtime — it should inherit the default"
498+
);
499+
}
500+
501+
#[test]
502+
fn fizz_builtin_resolves_to_buzz_agent() {
503+
// With no runtime pin, effective_agent_command must fall through to
504+
// default_agent_command(), which resolves the bundled buzz-agent.
505+
let records = built_in_persona_records("2026-01-01T00:00:00Z");
506+
assert_eq!(
507+
effective_agent_command(Some("builtin:fizz"), &records, None),
508+
default_agent_command(),
509+
"Fizz must resolve to the bundled default harness, not goose"
510+
);
511+
assert_eq!(
512+
effective_agent_command(Some("builtin:fizz"), &records, None),
513+
"buzz-agent",
514+
"Fizz must resolve to buzz-agent specifically"
515+
);
516+
}

‎desktop/src/testing/e2eBridge.ts‎

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1706,7 +1706,7 @@ function resetMockPersonas(config?: E2eConfig) {
17061706
display_name: persona.display_name,
17071707
avatar_url: persona.avatar_url,
17081708
system_prompt: persona.system_prompt,
1709-
runtime: persona.id === "builtin:fizz" ? "goose" : null,
1709+
runtime: null,
17101710
model: null,
17111711
provider: null,
17121712
name_pool: [],
@@ -6568,17 +6568,21 @@ async function handleCreateManagedAgent(
65686568
.replace(/-/g, "")
65696569
.padEnd(64, "0")
65706570
.slice(0, 64);
6571+
const agentCommand = args.input.agentCommand ?? "buzz-agent";
6572+
const agentArgs =
6573+
args.input.agentArgs && args.input.agentArgs.length > 0
6574+
? [...args.input.agentArgs]
6575+
: agentCommand === "goose"
6576+
? ["acp"]
6577+
: [];
65716578
const managedAgent: MockManagedAgent = {
65726579
pubkey,
65736580
name,
65746581
persona_id: args.input.personaId ?? null,
65756582
relay_url: args.input.relayUrl ?? DEFAULT_RELAY_WS_URL,
65766583
acp_command: args.input.acpCommand ?? "buzz-acp",
6577-
agent_command: args.input.agentCommand ?? "goose",
6578-
agent_args:
6579-
args.input.agentArgs && args.input.agentArgs.length > 0
6580-
? [...args.input.agentArgs]
6581-
: ["acp"],
6584+
agent_command: agentCommand,
6585+
agent_args: agentArgs,
65826586
mcp_command: args.input.mcpCommand ?? "",
65836587
turn_timeout_seconds: args.input.turnTimeoutSeconds ?? 320,
65846588
idle_timeout_seconds: args.input.idleTimeoutSeconds ?? null,

0 commit comments

Comments
 (0)