Skip to content

Commit e0f5e5d

Browse files
committed
fix(mobile): address timeline review feedback
Signed-off-by: kenny lopez <[email protected]>
1 parent fbd9f56 commit e0f5e5d

5 files changed

Lines changed: 34 additions & 19 deletions

File tree

‎mobile/lib/features/channels/channel_detail_page/message_list.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -516,6 +516,7 @@ class _MessageList extends HookConsumerWidget {
516516
entries.length,
517517
itemPositionsListener,
518518
appBarTitleContentHeight,
519+
composerBottomInset,
519520
],
520521
);
521522

‎mobile/lib/features/channels/jump_to_latest_button.dart‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,21 @@ import 'package:flutter/material.dart';
66
import 'package:flutter/rendering.dart';
77
import 'package:flutter/services.dart';
88
import 'package:flutter_hooks/flutter_hooks.dart';
9+
import 'package:hooks_riverpod/hooks_riverpod.dart';
910
import 'package:lucide_icons_flutter/lucide_icons.dart';
1011

1112
import '../../shared/theme/theme.dart';
1213

1314
/// Compact conversation control that returns a detached timeline to its tail.
14-
class JumpToLatestButton extends HookWidget {
15+
class JumpToLatestButton extends HookConsumerWidget {
1516
final VoidCallback onPressed;
1617

1718
const JumpToLatestButton({required this.onPressed, super.key});
1819

1920
static const _iosViewType = 'buzz/jump_to_latest_glass';
2021

2122
@override
22-
Widget build(BuildContext context) {
23+
Widget build(BuildContext context, WidgetRef ref) {
2324
final nativeChannel = useState<MethodChannel?>(null);
2425
final onPressedRef = useRef(onPressed)..value = onPressed;
2526
final brightness = context.theme.brightness.name;

‎mobile/lib/features/channels/sticky_date_header.dart‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import 'package:flutter/material.dart';
77
import 'package:flutter/rendering.dart';
88
import 'package:flutter/services.dart';
99
import 'package:flutter_hooks/flutter_hooks.dart';
10+
import 'package:hooks_riverpod/hooks_riverpod.dart';
1011

1112
import '../../shared/theme/theme.dart';
1213

@@ -154,7 +155,7 @@ class StickyDateHeader extends StatelessWidget {
154155
}
155156
}
156157

157-
class _IosStickyDateGlass extends HookWidget {
158+
class _IosStickyDateGlass extends HookConsumerWidget {
158159
final String label;
159160
final double width;
160161
final double height;
@@ -166,7 +167,7 @@ class _IosStickyDateGlass extends HookWidget {
166167
});
167168

168169
@override
169-
Widget build(BuildContext context) {
170+
Widget build(BuildContext context, WidgetRef ref) {
170171
final nativeChannel = useState<MethodChannel?>(null);
171172
final brightness = context.theme.brightness.name;
172173

‎mobile/test/features/channels/jump_to_latest_button_test.dart‎

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import 'package:flutter/foundation.dart';
44
import 'package:flutter/material.dart';
55
import 'package:flutter/services.dart';
66
import 'package:flutter_test/flutter_test.dart';
7+
import 'package:hooks_riverpod/hooks_riverpod.dart';
78

89
void main() {
910
testWidgets('keeps the native iOS glass in sync with the app theme', (
@@ -20,9 +21,11 @@ void main() {
2021
});
2122
try {
2223
await tester.pumpWidget(
23-
MaterialApp(
24-
theme: AppTheme.light(),
25-
home: Scaffold(body: JumpToLatestButton(onPressed: () {})),
24+
ProviderScope(
25+
child: MaterialApp(
26+
theme: AppTheme.light(),
27+
home: Scaffold(body: JumpToLatestButton(onPressed: () {})),
28+
),
2629
),
2730
);
2831

@@ -47,9 +50,11 @@ void main() {
4750

4851
methodCalls.clear();
4952
await tester.pumpWidget(
50-
MaterialApp(
51-
theme: AppTheme.dark(),
52-
home: Scaffold(body: JumpToLatestButton(onPressed: () {})),
53+
ProviderScope(
54+
child: MaterialApp(
55+
theme: AppTheme.dark(),
56+
home: Scaffold(body: JumpToLatestButton(onPressed: () {})),
57+
),
5358
),
5459
);
5560
await tester.pumpAndSettle();

‎mobile/test/features/channels/sticky_date_header_test.dart‎

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import 'package:flutter/foundation.dart';
44
import 'package:flutter/material.dart';
55
import 'package:flutter/services.dart';
66
import 'package:flutter_test/flutter_test.dart';
7+
import 'package:hooks_riverpod/hooks_riverpod.dart';
78

89
void main() {
910
testWidgets('updates the native iOS glass date and app theme', (
@@ -23,9 +24,11 @@ void main() {
2324
});
2425
try {
2526
await tester.pumpWidget(
26-
MaterialApp(
27-
theme: AppTheme.light(),
28-
home: Scaffold(body: StickyDateHeader(state: state)),
27+
ProviderScope(
28+
child: MaterialApp(
29+
theme: AppTheme.light(),
30+
home: Scaffold(body: StickyDateHeader(state: state)),
31+
),
2932
),
3033
);
3134

@@ -65,9 +68,11 @@ void main() {
6568

6669
methodCalls.clear();
6770
await tester.pumpWidget(
68-
MaterialApp(
69-
theme: AppTheme.dark(),
70-
home: Scaffold(body: StickyDateHeader(state: state)),
71+
ProviderScope(
72+
child: MaterialApp(
73+
theme: AppTheme.dark(),
74+
home: Scaffold(body: StickyDateHeader(state: state)),
75+
),
7176
),
7277
);
7378
await tester.pumpAndSettle();
@@ -93,9 +98,11 @@ void main() {
9398
final state = ValueNotifier(const StickyDateHeaderState(label: 'Today'));
9499
try {
95100
await tester.pumpWidget(
96-
MaterialApp(
97-
theme: AppTheme.light(),
98-
home: Scaffold(body: StickyDateHeader(state: state)),
101+
ProviderScope(
102+
child: MaterialApp(
103+
theme: AppTheme.light(),
104+
home: Scaffold(body: StickyDateHeader(state: state)),
105+
),
99106
),
100107
);
101108

0 commit comments

Comments
 (0)