Repository navigation
Commit dcd5cee
fix(desktop): hash effective spawn config the way spawn actually resolves it
Review feedback on #1602: the restart badge hash had two false-negatives.
1. Persona prompt/model/provider/env edits were excluded, but start/restore
re-snapshot the linked persona onto the record right before spawning, so
those edits DO apply on a plain restart. spawn_config_hash now applies the
same prospective re-snapshot (persona_snapshot_with_agent_config_fallback)
before hashing, so the badge trips when a restart would pick up the edit.
2. A blank record relay_url resolves to the active workspace relay at spawn,
but the raw "" was hashed — a workspace relay change never badged. The
relay is now hashed in resolved form (effective_agent_relay_url) with the
workspace relay threaded from both call sites, keeping the hash pure.
Flipped persona_prompt_edit test to assert_ne and added blank-relay /
pinned-relay workspace-change regression tests.
Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <[email protected]>1 parent c1c2168 commit dcd5cee
3 files changed
Lines changed: 103 additions & 32 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1360 | 1360 | | |
1361 | 1361 | | |
1362 | 1362 | | |
| 1363 | + | |
| 1364 | + | |
1363 | 1365 | | |
1364 | | - | |
| 1366 | + | |
| 1367 | + | |
| 1368 | + | |
| 1369 | + | |
| 1370 | + | |
1365 | 1371 | | |
1366 | 1372 | | |
1367 | 1373 | | |
| |||
1873 | 1879 | | |
1874 | 1880 | | |
1875 | 1881 | | |
1876 | | - | |
| 1882 | + | |
| 1883 | + | |
| 1884 | + | |
| 1885 | + | |
1877 | 1886 | | |
1878 | 1887 | | |
1879 | 1888 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
17 | 21 | | |
18 | 22 | | |
19 | 23 | | |
| |||
23 | 27 | | |
24 | 28 | | |
25 | 29 | | |
26 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
27 | 33 | | |
28 | 34 | | |
29 | 35 | | |
30 | 36 | | |
31 | | - | |
32 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
33 | 67 | | |
34 | 68 | | |
35 | 69 | | |
| |||
53 | 87 | | |
54 | 88 | | |
55 | 89 | | |
56 | | - | |
57 | | - | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
58 | 94 | | |
59 | 95 | | |
60 | 96 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
71 | 74 | | |
72 | 75 | | |
73 | 76 | | |
| |||
78 | 81 | | |
79 | 82 | | |
80 | 83 | | |
81 | | - | |
82 | | - | |
| 84 | + | |
| 85 | + | |
83 | 86 | | |
84 | 87 | | |
85 | 88 | | |
| |||
89 | 92 | | |
90 | 93 | | |
91 | 94 | | |
92 | | - | |
93 | | - | |
| 95 | + | |
| 96 | + | |
94 | 97 | | |
95 | 98 | | |
96 | 99 | | |
| |||
103 | 106 | | |
104 | 107 | | |
105 | 108 | | |
106 | | - | |
107 | | - | |
| 109 | + | |
| 110 | + | |
108 | 111 | | |
109 | 112 | | |
110 | 113 | | |
111 | 114 | | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
116 | 119 | | |
117 | 120 | | |
118 | 121 | | |
119 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
120 | 146 | | |
121 | | - | |
122 | | - | |
| 147 | + | |
| 148 | + | |
123 | 149 | | |
124 | 150 | | |
125 | 151 | | |
| |||
129 | 155 | | |
130 | 156 | | |
131 | 157 | | |
132 | | - | |
133 | | - | |
| 158 | + | |
| 159 | + | |
134 | 160 | | |
135 | 161 | | |
136 | 162 | | |
| |||
145 | 171 | | |
146 | 172 | | |
147 | 173 | | |
148 | | - | |
149 | | - | |
| 174 | + | |
| 175 | + | |
150 | 176 | | |
151 | 177 | | |
0 commit comments