Skip to content

Commit dcb2639

Browse files
tellahoclaude
andauthored
feat(desktop): open profile panel from MembersSidebar rows (#962)
Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
1 parent 4e4dc72 commit dcb2639

2 files changed

Lines changed: 84 additions & 49 deletions

File tree

‎desktop/src/features/channels/ui/MembersSidebar.tsx‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import {
2828
DialogHeader,
2929
DialogTitle,
3030
} from "@/shared/ui/dialog";
31+
import { useProfilePanel } from "@/shared/context/ProfilePanelContext";
3132
import { useFeedbackToasts } from "@/shared/hooks/useToastEffect";
3233
import { normalizePubkey } from "@/shared/lib/pubkey";
3334
import {
@@ -161,6 +162,21 @@ export function MembersSidebar({
161162

162163
useFeedbackToasts(actionNoticeMessage, actionErrorMessage);
163164

165+
const { openProfilePanel } = useProfilePanel();
166+
// UserProfilePanel only renders inside ChannelPane, which forums replace
167+
// with ForumView — opening there would close the sheet and show nothing.
168+
const isForumChannel = channel?.channelType === "forum";
169+
const handleOpenProfile = React.useMemo(
170+
() =>
171+
openProfilePanel && !isForumChannel
172+
? (pubkey: string) => {
173+
onOpenChange(false);
174+
openProfilePanel(pubkey);
175+
}
176+
: undefined,
177+
[isForumChannel, onOpenChange, openProfilePanel],
178+
);
179+
164180
const [editRespondToAgent, setEditRespondToAgent] =
165181
React.useState<ManagedAgent | null>(null);
166182

@@ -192,6 +208,7 @@ export function MembersSidebar({
192208
onManagedAgentAction={(agent) => {
193209
void handleAgentLifecycleAction(agent);
194210
}}
211+
onOpenProfile={handleOpenProfile}
195212
onRemoveMember={handleRemoveMember}
196213
onViewActivity={
197214
onViewActivity

‎desktop/src/features/channels/ui/MembersSidebarMemberCard.tsx‎

Lines changed: 67 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ type MembersSidebarMemberCardProps = {
4646
onChangeRole: (member: ChannelMember, role: string) => void;
4747
onEditRespondTo?: (agent: ManagedAgent) => void;
4848
onManagedAgentAction: (agent: ManagedAgent) => void;
49+
onOpenProfile?: (pubkey: string) => void;
4950
onRemoveMember: (member: ChannelMember) => void;
5051
onViewActivity?: (pubkey: string) => void;
5152
presenceStatus?: PresenceStatus | null;
@@ -97,6 +98,7 @@ export function MembersSidebarMemberCard({
9798
onChangeRole,
9899
onEditRespondTo,
99100
onManagedAgentAction,
101+
onOpenProfile,
100102
onRemoveMember,
101103
onViewActivity,
102104
presenceStatus,
@@ -112,60 +114,76 @@ export function MembersSidebarMemberCard({
112114
? Boolean(managedAgent) || canRemoveMember || canViewActivity
113115
: canRemoveMember || canChangeRole;
114116

117+
const memberIdentity = (
118+
<>
119+
<div className="relative shrink-0">
120+
<ProfileAvatar
121+
avatarUrl={profileAvatarUrl ?? null}
122+
className="h-9 w-9 text-[11px] shadow-none"
123+
iconClassName="h-4 w-4"
124+
label={memberAvatarLabel}
125+
/>
126+
{presenceStatus ? (
127+
<span
128+
className="absolute -bottom-0.5 -right-0.5 flex h-3.5 w-3.5 items-center justify-center rounded-full bg-background"
129+
data-testid={`sidebar-member-presence-${member.pubkey}`}
130+
>
131+
<PresenceDot className="h-2 w-2" status={presenceStatus} />
132+
</span>
133+
) : null}
134+
</div>
135+
<div className="min-w-0">
136+
<div className="flex items-center gap-1.5">
137+
<p className="truncate text-sm font-medium leading-5">
138+
{memberLabel}
139+
</p>
140+
<Badge className="shrink-0" variant="secondary">
141+
{roleLabel}
142+
</Badge>
143+
{managedAgent ? (
144+
<>
145+
<Badge
146+
className="shrink-0"
147+
data-testid={`sidebar-managed-agent-status-${member.pubkey}`}
148+
variant="secondary"
149+
>
150+
{formatManagedAgentStatus(managedAgent)}
151+
</Badge>
152+
<Badge
153+
className="shrink-0"
154+
data-testid={`sidebar-managed-agent-respond-to-${member.pubkey}`}
155+
variant="outline"
156+
>
157+
{formatRespondToLabel(managedAgent)}
158+
</Badge>
159+
</>
160+
) : null}
161+
</div>
162+
<p className="truncate font-mono text-[10px] text-muted-foreground/50">
163+
{truncatePubkey(member.pubkey)}
164+
</p>
165+
</div>
166+
</>
167+
);
168+
115169
return (
116170
<div
117171
className="group flex items-center justify-between gap-3 rounded-lg px-3 py-2 transition-colors hover:bg-muted/40"
118172
data-testid={`sidebar-member-${member.pubkey}`}
119173
>
120-
<div className="flex min-w-0 items-center gap-3">
121-
<div className="relative shrink-0">
122-
<ProfileAvatar
123-
avatarUrl={profileAvatarUrl ?? null}
124-
className="h-9 w-9 text-[11px] shadow-none"
125-
iconClassName="h-4 w-4"
126-
label={memberAvatarLabel}
127-
/>
128-
{presenceStatus ? (
129-
<span
130-
className="absolute -bottom-0.5 -right-0.5 flex h-3.5 w-3.5 items-center justify-center rounded-full bg-background"
131-
data-testid={`sidebar-member-presence-${member.pubkey}`}
132-
>
133-
<PresenceDot className="h-2 w-2" status={presenceStatus} />
134-
</span>
135-
) : null}
136-
</div>
137-
<div className="min-w-0">
138-
<div className="flex items-center gap-1.5">
139-
<p className="truncate text-sm font-medium leading-5">
140-
{memberLabel}
141-
</p>
142-
<Badge className="shrink-0" variant="secondary">
143-
{roleLabel}
144-
</Badge>
145-
{managedAgent ? (
146-
<>
147-
<Badge
148-
className="shrink-0"
149-
data-testid={`sidebar-managed-agent-status-${member.pubkey}`}
150-
variant="secondary"
151-
>
152-
{formatManagedAgentStatus(managedAgent)}
153-
</Badge>
154-
<Badge
155-
className="shrink-0"
156-
data-testid={`sidebar-managed-agent-respond-to-${member.pubkey}`}
157-
variant="outline"
158-
>
159-
{formatRespondToLabel(managedAgent)}
160-
</Badge>
161-
</>
162-
) : null}
163-
</div>
164-
<p className="truncate font-mono text-[10px] text-muted-foreground/50">
165-
{truncatePubkey(member.pubkey)}
166-
</p>
167-
</div>
168-
</div>
174+
{onOpenProfile ? (
175+
<button
176+
aria-label={`Open profile for ${memberLabel}`}
177+
className="flex min-w-0 flex-1 items-center gap-3 text-left focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 focus-visible:ring-offset-background rounded-md"
178+
data-testid={`sidebar-member-open-profile-${member.pubkey}`}
179+
onClick={() => onOpenProfile(member.pubkey)}
180+
type="button"
181+
>
182+
{memberIdentity}
183+
</button>
184+
) : (
185+
<div className="flex min-w-0 items-center gap-3">{memberIdentity}</div>
186+
)}
169187
{hasActions ? (
170188
<MemberActionsMenu
171189
canChangeRole={canChangeRole}

0 commit comments

Comments
 (0)