Skip to content

Commit dbf2cfc

Browse files
wesbillmanPinky
andauthored
fix(desktop): remove superseded built-in agents (#1929)
Signed-off-by: Wes <[email protected]> Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
1 parent 3e90dd5 commit dbf2cfc

4 files changed

Lines changed: 21 additions & 212 deletions

File tree

‎desktop/src-tauri/src/managed_agents/personas.rs‎

Lines changed: 0 additions & 127 deletions
Large diffs are not rendered by default.

‎desktop/src-tauri/src/managed_agents/personas/tests.rs‎

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -39,27 +39,11 @@ fn merge_personas_adds_missing_built_ins() {
3939
assert!(records
4040
.iter()
4141
.any(|record| record.id == "builtin:fizz" && record.runtime.is_none()));
42-
assert!(records
43-
.iter()
44-
.any(|record| record.id == "builtin:product-strategist" && !record.is_active));
4542
let display_names: Vec<&str> = records
4643
.iter()
4744
.map(|record| record.display_name.as_str())
4845
.collect();
49-
assert_eq!(
50-
display_names,
51-
vec![
52-
"Fizz",
53-
"Honey",
54-
"Bumble",
55-
"Product Strategist",
56-
"Implementation Partner",
57-
"QA Reviewer",
58-
"Work Coordinator",
59-
"Support Guide",
60-
"Experiment Designer"
61-
]
62-
);
46+
assert_eq!(display_names, vec!["Fizz", "Honey", "Bumble"]);
6347
let active_ids: Vec<&str> = records
6448
.iter()
6549
.filter(|record| record.is_active)

‎desktop/src/testing/e2eBridge.ts‎

Lines changed: 8 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -1861,72 +1861,27 @@ function resetMockManagedAgents(config?: E2eConfig) {
18611861
syncMockRelayAgentsFromManagedAgents();
18621862
}
18631863

1864-
const BUILT_IN_PERSONA_AVATAR_URLS = {
1865-
productStrategist:
1866-
"data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAxMjggMTI4Ij48cmVjdCB3aWR0aD0iMTI4IiBoZWlnaHQ9IjEyOCIgcng9IjMyIiBmaWxsPSIjMmY2ZjczIi8+PGNpcmNsZSBjeD0iOTYiIGN5PSIzMiIgcj0iMTYiIGZpbGw9IiNkZmY3ZjQiIGZpbGwtb3BhY2l0eT0iLjI4Ii8+PHBhdGggZD0iTTI0IDk0YzE0LTI1IDI3LTM3IDQwLTM3czI2IDEyIDQwIDM3IiBmaWxsPSJub25lIiBzdHJva2U9IiNkZmY3ZjQiIHN0cm9rZS13aWR0aD0iOCIgc3Ryb2tlLWxpbmVjYXA9InJvdW5kIi8+PHRleHQgeD0iNjQiIHk9IjcyIiB0ZXh0LWFuY2hvcj0ibWlkZGxlIiBmb250LWZhbWlseT0iSW50ZXIsQXJpYWwsc2Fucy1zZXJpZiIgZm9udC1zaXplPSIzNCIgZm9udC13ZWlnaHQ9IjcwMCIgZmlsbD0iI2RmZjdmNCI+UFM8L3RleHQ+PC9zdmc+",
1867-
implementationPartner:
1868-
"data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAxMjggMTI4Ij48cmVjdCB3aWR0aD0iMTI4IiBoZWlnaHQ9IjEyOCIgcng9IjMyIiBmaWxsPSIjNmY0ZTlhIi8+PGNpcmNsZSBjeD0iOTYiIGN5PSIzMiIgcj0iMTYiIGZpbGw9IiNmMGU4ZmYiIGZpbGwtb3BhY2l0eT0iLjI4Ii8+PHBhdGggZD0iTTI0IDk0YzE0LTI1IDI3LTM3IDQwLTM3czI2IDEyIDQwIDM3IiBmaWxsPSJub25lIiBzdHJva2U9IiNmMGU4ZmYiIHN0cm9rZS13aWR0aD0iOCIgc3Ryb2tlLWxpbmVjYXA9InJvdW5kIi8+PHRleHQgeD0iNjQiIHk9IjcyIiB0ZXh0LWFuY2hvcj0ibWlkZGxlIiBmb250LWZhbWlseT0iSW50ZXIsQXJpYWwsc2Fucy1zZXJpZiIgZm9udC1zaXplPSIzNCIgZm9udC13ZWlnaHQ9IjcwMCIgZmlsbD0iI2YwZThmZiI+SVA8L3RleHQ+PC9zdmc+",
1869-
qaReviewer:
1870-
"data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAxMjggMTI4Ij48cmVjdCB3aWR0aD0iMTI4IiBoZWlnaHQ9IjEyOCIgcng9IjMyIiBmaWxsPSIjOWE1YTFmIi8+PGNpcmNsZSBjeD0iOTYiIGN5PSIzMiIgcj0iMTYiIGZpbGw9IiNmZmYwZGMiIGZpbGwtb3BhY2l0eT0iLjI4Ii8+PHBhdGggZD0iTTI0IDk0YzE0LTI1IDI3LTM3IDQwLTM3czI2IDEyIDQwIDM3IiBmaWxsPSJub25lIiBzdHJva2U9IiNmZmYwZGMiIHN0cm9rZS13aWR0aD0iOCIgc3Ryb2tlLWxpbmVjYXA9InJvdW5kIi8+PHRleHQgeD0iNjQiIHk9IjcyIiB0ZXh0LWFuY2hvcj0ibWlkZGxlIiBmb250LWZhbWlseT0iSW50ZXIsQXJpYWwsc2Fucy1zZXJpZiIgZm9udC1zaXplPSIzNCIgZm9udC13ZWlnaHQ9IjcwMCIgZmlsbD0iI2ZmZjBkYyI+UUE8L3RleHQ+PC9zdmc+",
1871-
workCoordinator:
1872-
"data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAxMjggMTI4Ij48cmVjdCB3aWR0aD0iMTI4IiBoZWlnaHQ9IjEyOCIgcng9IjMyIiBmaWxsPSIjMzQ1ZjhjIi8+PGNpcmNsZSBjeD0iOTYiIGN5PSIzMiIgcj0iMTYiIGZpbGw9IiNlM2YwZmYiIGZpbGwtb3BhY2l0eT0iLjI4Ii8+PHBhdGggZD0iTTI0IDk0YzE0LTI1IDI3LTM3IDQwLTM3czI2IDEyIDQwIDM3IiBmaWxsPSJub25lIiBzdHJva2U9IiNlM2YwZmYiIHN0cm9rZS13aWR0aD0iOCIgc3Ryb2tlLWxpbmVjYXA9InJvdW5kIi8+PHRleHQgeD0iNjQiIHk9IjcyIiB0ZXh0LWFuY2hvcj0ibWlkZGxlIiBmb250LWZhbWlseT0iSW50ZXIsQXJpYWwsc2Fucy1zZXJpZiIgZm9udC1zaXplPSIzNCIgZm9udC13ZWlnaHQ9IjcwMCIgZmlsbD0iI2UzZjBmZiI+V0M8L3RleHQ+PC9zdmc+",
1873-
supportGuide:
1874-
"data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAxMjggMTI4Ij48cmVjdCB3aWR0aD0iMTI4IiBoZWlnaHQ9IjEyOCIgcng9IjMyIiBmaWxsPSIjNmE3MDMxIi8+PGNpcmNsZSBjeD0iOTYiIGN5PSIzMiIgcj0iMTYiIGZpbGw9IiNmMmY2ZDciIGZpbGwtb3BhY2l0eT0iLjI4Ii8+PHBhdGggZD0iTTI0IDk0YzE0LTI1IDI3LTM3IDQwLTM3czI2IDEyIDQwIDM3IiBmaWxsPSJub25lIiBzdHJva2U9IiNmMmY2ZDciIHN0cm9rZS13aWR0aD0iOCIgc3Ryb2tlLWxpbmVjYXA9InJvdW5kIi8+PHRleHQgeD0iNjQiIHk9IjcyIiB0ZXh0LWFuY2hvcj0ibWlkZGxlIiBmb250LWZhbWlseT0iSW50ZXIsQXJpYWwsc2Fucy1zZXJpZiIgZm9udC1zaXplPSIzNCIgZm9udC13ZWlnaHQ9IjcwMCIgZmlsbD0iI2YyZjZkNyI+U0c8L3RleHQ+PC9zdmc+",
1875-
experimentDesigner:
1876-
"data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAxMjggMTI4Ij48cmVjdCB3aWR0aD0iMTI4IiBoZWlnaHQ9IjEyOCIgcng9IjMyIiBmaWxsPSIjOGIzZjVlIi8+PGNpcmNsZSBjeD0iOTYiIGN5PSIzMiIgcj0iMTYiIGZpbGw9IiNmZmU3ZjAiIGZpbGwtb3BhY2l0eT0iLjI4Ii8+PHBhdGggZD0iTTI0IDk0YzE0LTI1IDI3LTM3IDQwLTM3czI2IDEyIDQwIDM3IiBmaWxsPSJub25lIiBzdHJva2U9IiNmZmU3ZjAiIHN0cm9rZS13aWR0aD0iOCIgc3Ryb2tlLWxpbmVjYXA9InJvdW5kIi8+PHRleHQgeD0iNjQiIHk9IjcyIiB0ZXh0LWFuY2hvcj0ibWlkZGxlIiBmb250LWZhbWlseT0iSW50ZXIsQXJpYWwsc2Fucy1zZXJpZiIgZm9udC1zaXplPSIzNCIgZm9udC13ZWlnaHQ9IjcwMCIgZmlsbD0iI2ZmZTdmMCI+RUQ8L3RleHQ+PC9zdmc+",
1877-
} as const;
1878-
18791864
function resetMockPersonas(config?: E2eConfig) {
18801865
const now = new Date().toISOString();
18811866
const activePersonaIds = new Set(config?.mock?.activePersonaIds ?? []);
18821867
const builtInPersonas = [
1883-
{
1884-
id: "builtin:product-strategist",
1885-
display_name: "Product Strategist",
1886-
avatar_url: BUILT_IN_PERSONA_AVATAR_URLS.productStrategist,
1887-
system_prompt:
1888-
"You are a product strategy agent. You help turn broad ideas into clear product and design direction.\n\n# Focus\n\nClarify the goal, identify the audience, and call out the tradeoffs that matter.",
1889-
},
1890-
{
1891-
id: "builtin:implementation-partner",
1892-
display_name: "Implementation Partner",
1893-
avatar_url: BUILT_IN_PERSONA_AVATAR_URLS.implementationPartner,
1894-
system_prompt:
1895-
"You are an implementation partner agent. You help turn scoped plans into working changes.\n\n# Focus\n\nPrefer small, direct edits that follow the existing codebase.",
1896-
},
1897-
{
1898-
id: "builtin:qa-reviewer",
1899-
display_name: "QA Reviewer",
1900-
avatar_url: BUILT_IN_PERSONA_AVATAR_URLS.qaReviewer,
1901-
system_prompt:
1902-
"You are a QA reviewer agent. You look for the ways a change might break.\n\n# Focus\n\nInspect state transitions, empty states, permissions, accessibility, and failure paths.",
1903-
},
19041868
{
19051869
id: "builtin:fizz",
19061870
display_name: "Fizz",
19071871
avatar_url: null,
19081872
system_prompt: "You are Fizz.",
19091873
},
19101874
{
1911-
id: "builtin:work-coordinator",
1912-
display_name: "Work Coordinator",
1913-
avatar_url: BUILT_IN_PERSONA_AVATAR_URLS.workCoordinator,
1914-
system_prompt:
1915-
"You are a work coordination agent. You keep multi-step work organized and grounded.\n\n# Focus\n\nTrack goals, dependencies, and follow-ups.",
1916-
},
1917-
{
1918-
id: "builtin:support-guide",
1919-
display_name: "Support Guide",
1920-
avatar_url: BUILT_IN_PERSONA_AVATAR_URLS.supportGuide,
1921-
system_prompt:
1922-
"You are a support and onboarding agent. You help people feel oriented quickly.\n\n# Focus\n\nExplain unfamiliar flows plainly, surface the next useful step, and keep guidance reassuring without becoming verbose.",
1875+
id: "builtin:honey",
1876+
display_name: "Honey",
1877+
avatar_url: null,
1878+
system_prompt: "You are Honey.",
19231879
},
19241880
{
1925-
id: "builtin:experiment-designer",
1926-
display_name: "Experiment Designer",
1927-
avatar_url: BUILT_IN_PERSONA_AVATAR_URLS.experimentDesigner,
1928-
system_prompt:
1929-
"You are an experiment design agent. You help turn uncertainty into experiments.\n\n# Focus\n\nBreak big questions into small trials, name what would prove or disprove an idea, and keep momentum through ambiguity.",
1881+
id: "builtin:bumble",
1882+
display_name: "Bumble",
1883+
avatar_url: null,
1884+
system_prompt: "You are Bumble.",
19301885
},
19311886
];
19321887
mockPersonas = builtInPersonas.map((persona) => ({

‎desktop/tests/e2e/agents.spec.ts‎

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -164,25 +164,22 @@ test("built-in personas are used from the catalog dialog", async ({ page }) => {
164164
await expect(page.getByTestId("persona-catalog-dialog")).toContainText(
165165
"Fizz",
166166
);
167-
const previewPersonas = [
168-
["builtin:product-strategist", "Product Strategist"],
169-
["builtin:implementation-partner", "Implementation Partner"],
170-
["builtin:qa-reviewer", "QA Reviewer"],
171-
["builtin:work-coordinator", "Work Coordinator"],
172-
["builtin:support-guide", "Support Guide"],
173-
["builtin:experiment-designer", "Experiment Designer"],
174-
] as const;
175-
for (const [, personaName] of previewPersonas) {
167+
for (const personaName of ["Fizz", "Honey", "Bumble"]) {
176168
await expect(page.getByTestId("persona-catalog-dialog")).toContainText(
177169
personaName,
178170
);
179171
}
180-
for (const [personaId, personaName] of previewPersonas) {
181-
await expect(
182-
page
183-
.getByTestId(`persona-catalog-list-item-${personaId}`)
184-
.getByRole("img", { name: `${personaName} avatar` }),
185-
).toHaveAttribute("src", /.+/);
172+
for (const retiredPersonaName of [
173+
"Product Strategist",
174+
"Implementation Partner",
175+
"QA Reviewer",
176+
"Work Coordinator",
177+
"Support Guide",
178+
"Experiment Designer",
179+
]) {
180+
await expect(page.getByTestId("persona-catalog-dialog")).not.toContainText(
181+
retiredPersonaName,
182+
);
186183
}
187184
await expect(page.getByTestId("persona-catalog-dialog-header")).toBeVisible();
188185
await expect(

0 commit comments

Comments
 (0)