Skip to content

Commit d34c9c2

Browse files
TheSentinel454Elrond
andauthored
ci: shorten the PR critical path (desktop lanes, smoke shards, parallel relay artifacts) (#8156)
## Summary The PR critical path on main push [run 37635224099](https://github.com/block/buzz/actions/runs/37635224099) (`e097c4299`) was about 42 minutes: - **Desktop Core** took 41 min. It ran frontend checks, two clippy graphs, the Tauri suite, the mesh-llm suite and every compiled-flag state one after another. The compiled-flag step alone took 16m51. - **Relay artifact producer → Desktop E2E Integration** took about 31 min. The producer built the relay binaries (5m07), the backend integration archive (4m41) and the PostgreSQL archive (8m18) one after another. - **Desktop Smoke E2E** took 19–24 min per shard across 4 shards, with 82 min of tests in total. This PR attacks all three. ### 1. Run each compiled-flag state once (`Justfile`) | Previous step | Cost | Why it's redundant | |---|---|---| | Clean state: full `buzz_lib` suite (`--lib`) | 3m27 run | `desktop-tauri-test` runs the same suite in the same compile state one step earlier. When `BUZZ_TEST_EXPECTED_AGENT_ACCESS_OWNER_ONLY` is unset, the expected value already defaults to `false` in non-owner-only builds (`runtime/test_fixtures.rs`, `agents_tests.rs`). | | Internal state: auto-connect and owner-only built separately | 1m22 + 1m06 + 56s across three recompiles | Internal release packaging always sets both capabilities together, so building owner-only without auto-connect tests a configuration that never ships. The extra 56s happens because a bare `cargo test <filter>` builds every target, not just the `--lib` harness. | | Demo state: `cargo test --workspace` | ~30s more than `--lib` | `buzz-terminal` and the `tests/*.rs` integration tests don't read any `BUZZ_BUILD_*` variable or `buzz_lib`, so they ran the same binaries a second time. | A fourth cost was hidden: every recipe invocation spent ~1m20 recompiling `buzz-desktop` to the *same* unit hash `desktop-tauri-test` had just built. `_ensure-sidecar-stubs` ran `touch` on every sidecar stub on each run. `tauri-build` emits `rerun-if-changed` for each `externalBin`, so the new mtimes reran `build.rs` and recompiled the crate. Stubs are now created only when they're missing. This also speeds up any local `desktop-tauri-*` recipe run back-to-back. After this change: - **Clean state:** runs only the two compiled-flag assertions (`compiled_flag_matches_expected`, `compiled_policy_matches_expected`) with `expected=false`. No recompile. - **Internal state:** one compile with `BUZZ_BUILD_AUTO_CONNECT_DEFAULT_RELAY=1` and `BUZZ_BUILD_AGENT_ACCESS_OWNER_ONLY=1`. It runs both assertions with `expected=true`, then the full `buzz_lib` suite. The suite now runs with auto-connect enabled as well, which matches the shipped internal build more closely than before. - **Auto-connect-only state (assertions only):** auto-connect `true`, owner-only `false`. The two capabilities are documented as independent. Without this state, a `build.rs` block that read the other capability's variable would pass, because every other state sets both or neither. - **Demo state:** one compile with only `BUZZ_BUILD_DEMO_SLUG`. It asserts the slug and asserts both capabilities stay `false`, then runs the full `buzz_lib` suite. - The recipe clears the three toggled `BUZZ_BUILD_*` capability variables and any caller `BUZZ_TEST_EXPECTED_*` values up front. Each state exports its own values in a subshell. Every invocation uses `--lib`, so each state compiles one test harness. - Each ignored-assertion run requires exactly one passing test per name filter. Previously, a renamed or un-ignored assertion matched nothing and passed silently. - The 32-character demo-name rejection check is unchanged. The full-suite reruns in the internal and demo states are kept on purpose. They are the only coverage that the whole suite holds up in those two shipped build shapes. Estimate: the compiled-flag work goes from about 17 min to about 11. ### 2. Split Desktop Core into parallel, path-gated lanes (`_ci-desktop.yml`) - **Desktop JS:** `desktop-check`, `desktop-test` and `desktop-build`. These compile no Rust, but some node:test cases read relay and DB crate sources to pin shared constants (for example `relayReconnectReplay.test.mjs`). So the job runs on desktop *and* Rust changes, in parallel with the Tauri lanes. `lefthook.yml` notes this as a deliberate local deviation. - **Desktop Tauri (core | mesh | compiled-flags):** a matrix of parallel Rust lanes. - `core` and `compiled-flags` share the existing `desktop-core` Rust cache key, so they start warm. `compiled-flags` restores it read-only. - `mesh` keeps its own cache because `mesh-llm` pulls a different dependency graph. - **Smoke E2E and the Windows frontend build** compile no Rust and read no crate sources, so they no longer run for Rust-only changes. - **Smoke E2E goes from 4 to 10 shards.** Playwright shards by test count, not duration. A simulation from the per-test durations in run 37635224099 reproduces the observed 4-shard split exactly. With 10 shards, the slowest shard runs about 11 min of tests. - **The `Desktop` gate is stricter.** Each selected job must succeed and each unselected job must be skipped, so a mis-gated job can't pass silently. The required check context (`Desktop`) is unchanged. `scripts/ci-required-gates.test.mjs` pins each job's `if:` to the gate's selection expression, and checks which jobs a Rust-only, desktop-only, Tauri, push, and empty selection pick. - **Path-filter fixes:** - The `desktop` filter now includes `_ci-desktop.yml`, `ci.yml` and `Justfile` (which holds the desktop recipes), so edits to them run the frontend lanes. - The `rust` filter now matches `Justfile`. It still named the pre-rename `justfile`, so a `Justfile`-only change selected no Rust suites. - `scripts/ci-selection.test.mjs` gains `Justfile` and desktop-workflow scenarios, and the shared-workflow scenario now expects `desktop`. - **Dead step removed:** the failure-only Playwright artifact upload in the old Core job never had anything to upload, because that job never ran Playwright. ### 3. Build relay artifacts in parallel (`_ci-relay.yml`) - **The producer is now a 3-way matrix** (`relay-binaries`, `backend-integration-tests`, `postgres-tests`). - Each lane has its own exact-source cache entry and uploads `desktop-e2e-relay-<artifact>`. - Consumers download `desktop-e2e-relay-*` into `target/ci`, so their paths are unchanged. - The required `Desktop E2E Relay` context still reads the producer job's aggregate result. - **Rust cache saving:** all lanes restore the existing Rust cache key, but only the widest lane (`postgres-tests`) saves it. Otherwise the fastest lane could overwrite it with a narrower target dir. - **Desktop E2E Integration goes from 2 to 3 shards.** Shard labels now use `strategy.job-total`. ### 4. Bound degraded apt steps (`scripts/ci-apt-retry.sh`) - With more shards, more runs hit the occasional degraded Ubuntu mirror. On this PR, a Tauri lane ran `apt-get install` for 27 minutes: apt's `Acquire` timeouts kept firing, but apt kept re-queuing the requests and never failed. Separately, three Smoke shards stalled silently in `playwright install-deps` (no output after `InRelease`) until the job timeout. Healthy apt steps across four recent runs finished in at most 238s. - Every apt-backed step in Desktop and Integration now runs through `scripts/ci-apt-retry.sh`. The script writes the apt options to `apt.conf.d`, so Playwright's own apt-get calls get them too. It kills each attempt after 7 minutes (90s for `apt-get update`). Between attempts it stops any `apt-get` or `dpkg` the attempt left running, repairs dpkg under its own 60s deadline, and retries up to 3 times. The stop matters for `playwright install-deps`, which runs `sudo sh -c "apt-get update && apt-get install ..."`: sudo puts its command in a new process group, so the deadline's signal stops `sh` and apt-get survives holding the dpkg lock (seen on Smoke shard 8 of run 37696815557, and reproduced with real sudo). - Downloaded `.deb`s are kept between attempts, so a retry resumes where the last one stopped. Against a mirror that stays degraded, this bounds each wrapped command at about 25 minutes rather than recovering it. The Tauri lanes wrap two commands, `apt-get update` (about 8.5 minutes worst case) and `apt-get install` (about 25), so about 34 minutes together. Job timeouts are sized to fit that bound plus the job's own work: Tauri 55m (lanes take up to ~15m), Integration 40m, and Smoke 45m. A degraded mirror therefore ends with the wrapper's error instead of a silent job timeout. - **The retry has already fired on this PR.** In [run 37703795342](https://github.com/block/buzz/actions/runs/37703795342), `playwright install-deps` on Integration shard 1/3 hit the 420s attempt deadline. The second attempt started about 1.4s later, downloaded and configured the real packages, and succeeded. The step took 526s (8m46), and that shard took 17m24 while the other two took about 5m. Healthy installs have taken at most 238s, so 420s leaves headroom, and a slow mirror costs one attempt instead of the job. - Between attempts the script stops **every** `apt-get`/`dpkg` on the machine, not only the ones it started. That's intentional: on a hosted runner any other one would hold the same dpkg lock. It assumes an ephemeral runner, and the script says not to use it on a self-hosted runner or a developer machine. - `scripts/ci-apt-retry.test.mjs` covers the following with a fake `sudo`: success, retry, the attempt budget, a stalled attempt, a stalled dpkg repair, an apt-get that escapes the attempt's process group (on a retry and on the final attempt), and usage. It needs Linux (GNU `timeout`, `flock`, `setsid`, procps), so it skips on other platforms. CI runs it on Ubuntu. ### What got simpler - **Compiled-flag recipe:** two full-suite runs instead of three, six cargo invocations instead of eight, and sidecar stubs no longer invalidate the desktop build cache. - **Path selection:** each desktop job declares only the paths that actually affect it. The stale `justfile` filter and a dead artifact step are gone. - **Apt options:** set once in `apt.conf.d` by one script, instead of as repeated `-o Acquire...` flags on each apt call. - **Shard counts:** the shard count is written once per matrix, not repeated in names and commands. ### Cost - **More runners:** a full run uses more runner jobs. Smoke E2E goes from 4 to 10 jobs, Desktop Core from 1 to 4, the relay producer from 1 to 3, and Integration from 2 to 3. - **Fewer runners on single-area PRs:** desktop-only PRs skip the Rust lanes, and Rust-only PRs skip Smoke E2E and the Windows build. - **One extra Rust cache entry:** `desktop-mesh`. ### Related issue None found. ### Testing Blox, compiled-flag recipe at `77b9874b`: - [x] Recipe passes with output redirected to a file. The log keeps all 4 state headers, the ignored assertions ran 2/2/2/3, and both full suites passed (`3423 passed`). - [x] A second back-to-back run shows no clean-state `Compiling buzz-desktop`. - [x] Mutation tests all fail as required: - `build.rs` auto-connect reads the owner-only var: rc=101. - The reverse swap: rc=101. - Rename `compiled_policy_matches_expected`: rc=1. - Wrong owner-only expectation: rc=101. - [ ] `just ci` Workflows: - [x] `actionlint` on `_ci-desktop.yml`, `_ci-relay.yml` and `ci.yml`: clean. - [x] `scripts/test-ci-required-context-isolation.sh`: passes. - [x] GitHub Actions: runs [37701003713](https://github.com/block/buzz/actions/runs/37701003713) and [37703795342](https://github.com/block/buzz/actions/runs/37703795342) took 27m09 and 28m51. Before this PR, PR runs had a median of 40.0m (n=21) and main pushes took about 42m. These are observations across mixed runner images, not a measured causal speedup. - [x] Selection, gate and apt suites (74/74 on Linux), `actionlint` and `bash -n` on Blox at tree `db9725fe`. --------- Signed-off-by: Elrond <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz> Co-authored-by: Elrond <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz>
1 parent bbcbd7c commit d34c9c2

9 files changed

Lines changed: 561 additions & 164 deletions

File tree

‎.github/workflows/_ci-desktop.yml‎

Lines changed: 109 additions & 87 deletions
Original file line numberDiff line numberDiff line change
@@ -21,51 +21,22 @@ env:
2121
PLAYWRIGHT_BROWSERS_PATH: ${{ github.workspace }}/.cache/ms-playwright
2222

2323
jobs:
24-
desktop-core:
25-
name: Desktop Core
24+
# Biome, node:test, and the Vite build do not compile Rust, but node:test
25+
# also pins desktop constants to relay/DB crate sources (for example
26+
# relayReconnectReplay.test.mjs), so Rust changes select this job too.
27+
desktop-js:
28+
name: Desktop JS
2629
runs-on: ubuntu-latest
27-
# The compiled-flag verification step rebuilds the workspace for each
28-
# BUZZ_BUILD_* state and runs the full suite under all three compile
29-
# states; the complete recipe needs ~46m, so budget 60m.
30-
timeout-minutes: 60
31-
if: github.event_name == 'push' || inputs.desktop || inputs.desktop_rust || inputs.rust
30+
timeout-minutes: 20
31+
# Keep in sync with JS_SELECTED in the Desktop gate (pinned by ci-required-gates.test.mjs).
32+
if: github.event_name == 'push' || inputs.desktop || inputs.rust
3233
permissions:
3334
contents: read
3435
steps:
3536
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
3637
with:
3738
fetch-depth: 2
3839
- uses: cashapp/activate-hermit@cea9af7913204a965fd488637a8d1811bba2e616 # v1
39-
- uses: rui314/setup-mold@7e4f20ad28a2e8ca6fd0892ccf72e2abb706b9c3 # v1
40-
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32
41-
with:
42-
workspaces: desktop/src-tauri
43-
save-if: ${{ github.event_name != 'pull_request' }}
44-
- name: Install Tauri dependencies (Linux)
45-
env:
46-
DEBIAN_FRONTEND: noninteractive
47-
run: |
48-
sudo apt-get update \
49-
-o Acquire::Retries=3 \
50-
-o Acquire::http::Timeout=30 \
51-
-o Acquire::https::Timeout=30
52-
sudo apt-get install -y --no-install-recommends \
53-
-o Acquire::Retries=3 \
54-
-o Acquire::http::Timeout=30 \
55-
-o Acquire::https::Timeout=30 \
56-
-o DPkg::Lock::Timeout=120 \
57-
build-essential \
58-
curl \
59-
file \
60-
libasound2-dev \
61-
libayatana-appindicator3-dev \
62-
libgtk-3-dev \
63-
librsvg2-dev \
64-
libssl-dev \
65-
libwebkit2gtk-4.1-dev \
66-
libxdo-dev \
67-
patchelf \
68-
wget
6940
- name: Get pnpm store directory
7041
id: pnpm-cache
7142
run: echo "STORE_PATH=$(pnpm store path --silent)" >> "$GITHUB_OUTPUT"
@@ -83,53 +54,92 @@ jobs:
8354
run: just desktop-test
8455
- name: Desktop build
8556
run: just desktop-build
86-
- name: Desktop Tauri clippy
87-
run: just desktop-tauri-clippy
88-
env:
89-
CMAKE_POLICY_VERSION_MINIMUM: "3.5"
90-
- name: Desktop Tauri check
91-
run: just desktop-tauri-check
92-
env:
93-
CMAKE_POLICY_VERSION_MINIMUM: "3.5"
94-
- name: Desktop Tauri tests
95-
run: just desktop-tauri-test
96-
env:
97-
CMAKE_POLICY_VERSION_MINIMUM: "3.5"
98-
- name: Desktop Mesh feature tests
99-
run: cargo test --manifest-path desktop/src-tauri/Cargo.toml --features mesh-llm --lib
100-
env:
101-
CMAKE_POLICY_VERSION_MINIMUM: "3.5"
102-
- name: Desktop Tauri compiled-flag verification
103-
run: just desktop-tauri-test-compiled-flags
104-
env:
105-
CMAKE_POLICY_VERSION_MINIMUM: "3.5"
106-
- name: Upload desktop e2e artifacts
107-
if: failure()
108-
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
109-
with:
110-
name: desktop-e2e-artifacts
111-
path: |
112-
desktop/playwright-report
113-
desktop/test-results
114-
if-no-files-found: ignore
11557
- name: Save pnpm store cache
11658
if: github.event_name == 'push'
11759
uses: actions/cache/save@caa296126883cff596d87d8935842f9db880ef25 # v5
11860
with:
11961
path: ${{ steps.pnpm-cache.outputs.STORE_PATH }}
12062
key: pnpm-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
12163

64+
# Tauri Rust lanes run in parallel. The compiled-flags lane only rebuilds
65+
# buzz_lib under other BUZZ_BUILD_* values, so it restores the core lane's
66+
# cache read-only; the mesh-llm feature pulls its own dependency graph.
67+
desktop-tauri:
68+
name: Desktop Tauri (${{ matrix.lane }})
69+
runs-on: ubuntu-latest
70+
# A lane needs up to ~15m. ci-apt-retry.sh bounds the apt step at ~34m worst
71+
# case (update ~8.5m + install ~25m); 55m fits both, so a degraded mirror
72+
# fails with the wrapper's error instead of the job timeout.
73+
timeout-minutes: 55
74+
# Keep in sync with RUST_SELECTED in the Desktop gate (pinned by ci-required-gates.test.mjs).
75+
if: github.event_name == 'push' || inputs.desktop_rust || inputs.rust
76+
strategy:
77+
fail-fast: false
78+
matrix:
79+
include:
80+
- lane: core
81+
cache: desktop-core
82+
save-cache: true
83+
run: just desktop-tauri-clippy && just desktop-tauri-check && just desktop-tauri-test
84+
- lane: mesh
85+
cache: desktop-mesh
86+
save-cache: true
87+
run: just desktop-tauri-test-mesh
88+
- lane: compiled-flags
89+
cache: desktop-core
90+
save-cache: false
91+
run: just desktop-tauri-test-compiled-flags
92+
permissions:
93+
contents: read
94+
steps:
95+
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
96+
with:
97+
fetch-depth: 2
98+
- uses: cashapp/activate-hermit@cea9af7913204a965fd488637a8d1811bba2e616 # v1
99+
- uses: rui314/setup-mold@7e4f20ad28a2e8ca6fd0892ccf72e2abb706b9c3 # v1
100+
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32
101+
with:
102+
workspaces: desktop/src-tauri
103+
shared-key: ${{ matrix.cache }}
104+
save-if: ${{ matrix.save-cache && github.event_name != 'pull_request' }}
105+
- name: Install Tauri dependencies (Linux)
106+
env:
107+
DEBIAN_FRONTEND: noninteractive
108+
run: |
109+
CI_APT_ATTEMPT_SECONDS=90 scripts/ci-apt-retry.sh sudo apt-get update
110+
scripts/ci-apt-retry.sh sudo apt-get install -y --no-install-recommends \
111+
build-essential \
112+
curl \
113+
file \
114+
libasound2-dev \
115+
libayatana-appindicator3-dev \
116+
libgtk-3-dev \
117+
librsvg2-dev \
118+
libssl-dev \
119+
libwebkit2gtk-4.1-dev \
120+
libxdo-dev \
121+
patchelf \
122+
wget
123+
- name: Desktop Tauri ${{ matrix.lane }}
124+
run: ${{ matrix.run }}
125+
env:
126+
CMAKE_POLICY_VERSION_MINIMUM: "3.5"
127+
122128
desktop-smoke-e2e:
123129
name: Desktop Smoke E2E (${{ matrix.shard }})
124130
runs-on: ubuntu-latest
125-
# Chromium dependency setup can take 10m; a serial smoke shard needs
126-
# ~25m. Leave time for the full suite and its reports to finish.
131+
# A smoke shard needs ~12m, and Chromium dependency setup is bounded by
132+
# ci-apt-retry.sh (~25m worst case). Leave time for the full suite
133+
# and its reports to finish.
127134
timeout-minutes: 45
128-
if: github.event_name == 'push' || inputs.desktop || inputs.desktop_rust || inputs.rust
135+
# Keep in sync with FRONTEND_SELECTED in the Desktop gate (pinned by ci-required-gates.test.mjs).
136+
if: github.event_name == 'push' || inputs.desktop
129137
strategy:
130138
fail-fast: false
131139
matrix:
132-
shard: [1, 2, 3, 4]
140+
# Playwright shards smoke specs by test count, not duration; ten
141+
# shards keep the slowest one near 11 minutes of test time.
142+
shard: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
133143
permissions:
134144
contents: read
135145
steps:
@@ -159,7 +169,7 @@ jobs:
159169
if: steps.playwright-cache.outputs.cache-hit != 'true'
160170
run: cd desktop && pnpm exec playwright install chromium
161171
- name: Install Playwright system dependencies
162-
run: cd desktop && pnpm exec playwright install-deps chromium
172+
run: cd desktop && ../scripts/ci-apt-retry.sh pnpm exec playwright install-deps chromium
163173
- name: Save Playwright browser cache
164174
if: steps.playwright-cache.outputs.cache-hit != 'true' && github.event_name == 'push' && matrix.shard == 1
165175
uses: actions/cache/save@caa296126883cff596d87d8935842f9db880ef25 # v5
@@ -169,7 +179,7 @@ jobs:
169179
- name: Desktop E2E build
170180
run: pnpm -C desktop build:e2e
171181
- name: Desktop smoke e2e
172-
run: cd desktop && pnpm exec playwright test --project=smoke --shard=${{ matrix.shard }}/4
182+
run: cd desktop && pnpm exec playwright test --project=smoke --shard=${{ matrix.shard }}/${{ strategy.job-total }}
173183
- name: Summarize flaky tests
174184
if: ${{ !cancelled() }}
175185
run: node scripts/summarize-flaky-tests.mjs playwright-report.json "Desktop Smoke E2E (${{ matrix.shard }})"
@@ -190,32 +200,44 @@ jobs:
190200
name: Desktop
191201
runs-on: ubuntu-latest
192202
timeout-minutes: 5
193-
needs: [desktop-core, desktop-smoke-e2e, desktop-windows-build]
203+
needs: [desktop-js, desktop-tauri, desktop-smoke-e2e, desktop-windows-build]
194204
if: always() && (github.event_name == 'push' || inputs.desktop || inputs.desktop_rust || inputs.rust)
195205
permissions:
196206
contents: read
197207
steps:
198208
- name: Check desktop jobs
209+
env:
210+
JS_SELECTED: ${{ github.event_name == 'push' || inputs.desktop || inputs.rust }}
211+
RUST_SELECTED: ${{ github.event_name == 'push' || inputs.desktop_rust || inputs.rust }}
212+
FRONTEND_SELECTED: ${{ github.event_name == 'push' || inputs.desktop }}
213+
JS: ${{ needs.desktop-js.result }}
214+
TAURI: ${{ needs.desktop-tauri.result }}
215+
SMOKE: ${{ needs.desktop-smoke-e2e.result }}
216+
WINDOWS: ${{ needs.desktop-windows-build.result }}
199217
run: |
200-
if [ "${{ needs.desktop-core.result }}" != "success" ]; then
201-
echo "Desktop Core finished with: ${{ needs.desktop-core.result }}"
202-
exit 1
203-
fi
204-
if [ "${{ needs.desktop-smoke-e2e.result }}" != "success" ]; then
205-
echo "Desktop Smoke E2E shards finished with: ${{ needs.desktop-smoke-e2e.result }}"
206-
exit 1
207-
fi
208-
if [ "${{ needs.desktop-windows-build.result }}" != "success" ]; then
209-
echo "Desktop Windows Build finished with: ${{ needs.desktop-windows-build.result }}"
210-
exit 1
211-
fi
212-
echo "Desktop jobs passed"
218+
# A selected job must succeed; an unselected job must be skipped.
219+
status=0
220+
check() {
221+
local name="$1" selected="$2" result="$3" want=skipped
222+
[ "$selected" = true ] && want=success
223+
if [ "$result" != "$want" ]; then
224+
echo "$name finished with: $result (expected $want)"
225+
status=1
226+
fi
227+
}
228+
check "Desktop JS" "$JS_SELECTED" "$JS"
229+
check "Desktop Tauri lanes" "$RUST_SELECTED" "$TAURI"
230+
check "Desktop Smoke E2E shards" "$FRONTEND_SELECTED" "$SMOKE"
231+
check "Desktop Windows Build" "$FRONTEND_SELECTED" "$WINDOWS"
232+
[ "$status" = 0 ] && echo "Desktop jobs passed"
233+
exit "$status"
213234
214235
desktop-windows-build:
215236
name: Desktop Windows Build
216237
runs-on: windows-latest
217238
timeout-minutes: 20
218-
if: github.event_name == 'push' || inputs.desktop || inputs.desktop_rust || inputs.rust
239+
# Keep in sync with FRONTEND_SELECTED in the Desktop gate (pinned by ci-required-gates.test.mjs).
240+
if: github.event_name == 'push' || inputs.desktop
219241
permissions:
220242
contents: read
221243
steps:

0 commit comments

Comments
 (0)