Repository navigation
Commit cbd43fa
refactor(desktop): report the access-policy relay write explicitly
`applyReusableAgentAccessPolicy` signalled "this hit the relay" by
returning a different object than it was handed: a matching policy
returned the caller's `agent`, a diverging one returned the fresh record
from `updateManagedAgent`. `useMentionSendFlow` read that with
`readyAgent !== agent` to decide whether an awaited relay round-trip
separated its pre-side-effect mention-authorization pass from the
publish, and therefore whether to revalidate at the publish boundary
(#5681).
The contract held today, and the safe failure direction (a gratuitous new
object) only costs a redundant pass — but the unsafe direction is silent:
a future in-place cache update that writes to the relay and returns the
caller's object would skip the publish-boundary revalidation, and nothing
pinned the convention. Make the signal load-bearing by construction.
- `applyReusableAgentAccessPolicy` now returns
`{ agent, wrote }` (`ApplyReusableAgentAccessPolicyResult`), with
`wrote` set from whether `updateManagedAgent` actually ran rather than
from anything about the returned record. Its doc comment names the
send-path consumer so the flag is not mistaken for incidental.
- The send path destructures `{ agent: readyAgent, wrote }` and sets
`wroteRelayState` from `wrote`; the existing-member branch supplies
`{ agent, wrote: false }`. Behaviour is identical — for the current
implementation the two signals agree case for case.
- `provisionChannelManagedAgent`'s two reuse branches destructure the
agent out; they never consulted the identity signal.
Three unit tests pin the contract in a new
`channelAgents.accessPolicy.test.mjs`: a matching policy reports
`wrote: false`, returns the input agent, and issues no command; a
diverging policy reports `wrote: true` and invokes
`update_managed_agent` with the resolved policy; and a write whose
response is content-identical to the input still reports `wrote: true`,
which is the case an identity or content comparison would miss.
The repository file-size ratchet stays red on this branch for
app_state.rs, agents.rs, managed_agents/runtime.rs and
useMentionSendFlow.ts. All four were already over before this change;
useMentionSendFlow.ts holds at its inherited 1077 lines here, so this
commit adds nothing to the ratchet and does not split the pre-existing
four.
Verified: desktop tsc --noEmit, biome check over src + tests (exit 0),
desktop unit tests (5810 tests, 5804 passed; the 5 failures are the
pre-existing inboxReopenNavigation and useRetainedProjectGitViews
loader failures, present on origin/main), and the full mentions (84) and
channels + agent-access-warning (93) Playwright smoke suites against a
pnpm build:e2e bundle.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Signed-off-by: Matt Toohey <[email protected]>1 parent cff56e2 commit cbd43fa
3 files changed
Lines changed: 178 additions & 16 deletions
File tree
- desktop/src/features
- agents
- messages/ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
135 | 149 | | |
136 | 150 | | |
137 | 151 | | |
138 | 152 | | |
139 | | - | |
| 153 | + | |
140 | 154 | | |
141 | 155 | | |
142 | 156 | | |
143 | 157 | | |
144 | 158 | | |
145 | 159 | | |
146 | 160 | | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
155 | 168 | | |
156 | 169 | | |
157 | 170 | | |
| |||
329 | 342 | | |
330 | 343 | | |
331 | 344 | | |
332 | | - | |
| 345 | + | |
333 | 346 | | |
334 | 347 | | |
335 | 348 | | |
| |||
358 | 371 | | |
359 | 372 | | |
360 | 373 | | |
361 | | - | |
| 374 | + | |
362 | 375 | | |
363 | 376 | | |
364 | 377 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
182 | | - | |
183 | | - | |
| 182 | + | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
189 | | - | |
190 | | - | |
191 | | - | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
| |||
0 commit comments