Repository navigation
Commit c507a4d
authored
fix(db): allow naturally expired push lease replacement (#7653)
## Summary
Allow a naturally expired push lease to be replaced by a newer lease for
the same author and installation.
## Failure mode
Expiry cleanup marked the old lease inactive but left active-only fields
populated. The push_leases_check constraint requires those fields to be
NULL when a lease is inactive. When the client later registered a
replacement lease, the cleanup ran before the replacement and violated
the constraint with SQLSTATE 23514. The transaction rolled back, so the
replacement failed instead of taking over the expired lease.
## Fix
Clear all active-only fields as part of natural-expiry cleanup,
preserving the existing constraint and replacement flow. No schema
change is required.
## Testing
- Passed the focused Postgres regression test: cargo test -p buzz-db
replacing_naturally_expired_lease_replaces_old_state -- --ignored
- Passed scripts/test-postgres-test-discovery.sh
- Ran just ci: formatting, lint, security, file-size, desktop, web,
mobile, and 12 unit-test lanes passed. The overall run was red only
because existing timing-sensitive buzz-acp tests failed.
- The pre-push test-unit hook reproduced the same unrelated buzz-acp
failures, so the already-run verification was documented and the branch
was published with that hook bypassed.
## Related issue
No matching open issue or pull request was found.
## Scope
One file changed: crates/buzz-db/src/store/push.rs. The test uses the
production accept_lease_event path and identifies the replacement by its
cryptographic source event ID and generation.
Signed-off-by: Jarrod Sibbison <[email protected]>1 parent b8aa023 commit c507a4d
1 file changed
Lines changed: 78 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
328 | 328 | | |
329 | 329 | | |
330 | 330 | | |
331 | | - | |
| 331 | + | |
| 332 | + | |
332 | 333 | | |
333 | 334 | | |
334 | 335 | | |
| |||
1665 | 1666 | | |
1666 | 1667 | | |
1667 | 1668 | | |
| 1669 | + | |
| 1670 | + | |
| 1671 | + | |
| 1672 | + | |
| 1673 | + | |
| 1674 | + | |
| 1675 | + | |
| 1676 | + | |
| 1677 | + | |
| 1678 | + | |
| 1679 | + | |
| 1680 | + | |
| 1681 | + | |
| 1682 | + | |
| 1683 | + | |
| 1684 | + | |
| 1685 | + | |
| 1686 | + | |
| 1687 | + | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
| 1692 | + | |
| 1693 | + | |
| 1694 | + | |
| 1695 | + | |
| 1696 | + | |
| 1697 | + | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
| 1707 | + | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
| 1711 | + | |
| 1712 | + | |
| 1713 | + | |
| 1714 | + | |
| 1715 | + | |
| 1716 | + | |
| 1717 | + | |
| 1718 | + | |
| 1719 | + | |
| 1720 | + | |
| 1721 | + | |
| 1722 | + | |
| 1723 | + | |
| 1724 | + | |
| 1725 | + | |
| 1726 | + | |
| 1727 | + | |
| 1728 | + | |
| 1729 | + | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
| 1735 | + | |
| 1736 | + | |
| 1737 | + | |
| 1738 | + | |
| 1739 | + | |
| 1740 | + | |
| 1741 | + | |
| 1742 | + | |
| 1743 | + | |
| 1744 | + | |
1668 | 1745 | | |
1669 | 1746 | | |
1670 | 1747 | | |
| |||
0 commit comments