Repository navigation
Commit c3bcdea
committed
fix(mesh): keep readiness diagnosis honest on a single-worker mesh
Translating the probe to the wire name left the catalog-visibility check below
it comparing against `AUTO_MODEL_ID`. Post-translation that value can only be
`mesh` or a named model, so the delegated-choice branch was unreachable.
MeshLLM only advertises the virtual `mesh` model once two non-virtual models
are reachable (`should_advertise_virtual_mesh`), so on a single-worker mesh the
name is never listed and `model_ever_visible` stayed false for the whole wait.
A readiness timeout — a lone host still loading weights, say — was then
reported as `CatalogNeverSynced`, "a network path problem between this machine
and the host", when `RoutingNeverCompleted`, "try again shortly", is the truth.
Confirmed against a live node here: with one worker, `/v1/models` lists only
the served model.
Only the wrong-diagnosis-on-timeout is affected; the happy path always worked,
because the chat probe sends `mesh` and the server degrades it.
The comparison now keys on the translated name, preserving the original
"delegated choice — any advertised model counts" semantics. The predicate is
extracted as `mesh_catalog_shows_model` so that rule is testable rather than
buried in the poll loop, and the failure copy now names the model the caller
asked for, so someone who picked "Auto" is not shown "mesh".
Four tests cover it. Verified they fail with the old comparison restored, so
they pin the behaviour rather than merely passing alongside it.
Reported by @wpfleger96 in review; the diagnosis and the suggested fix are
theirs.
Signed-off-by: Michael Neale <[email protected]>1 parent 8e3b150 commit c3bcdea
2 files changed
Lines changed: 76 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
558 | 558 | | |
559 | 559 | | |
560 | 560 | | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
561 | 583 | | |
562 | 584 | | |
563 | 585 | | |
| |||
600 | 622 | | |
601 | 623 | | |
602 | 624 | | |
| 625 | + | |
603 | 626 | | |
604 | 627 | | |
605 | 628 | | |
| |||
617 | 640 | | |
618 | 641 | | |
619 | 642 | | |
620 | | - | |
621 | | - | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
622 | 649 | | |
623 | 650 | | |
624 | 651 | | |
| |||
627 | 654 | | |
628 | 655 | | |
629 | 656 | | |
630 | | - | |
631 | | - | |
632 | | - | |
633 | | - | |
634 | | - | |
635 | | - | |
636 | | - | |
637 | | - | |
638 | | - | |
639 | | - | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
640 | 663 | | |
641 | 664 | | |
642 | 665 | | |
| |||
667 | 690 | | |
668 | 691 | | |
669 | 692 | | |
670 | | - | |
| 693 | + | |
671 | 694 | | |
672 | 695 | | |
673 | 696 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
181 | 221 | | |
182 | 222 | | |
183 | 223 | | |
| |||
0 commit comments