Skip to content

Commit c10b4f8

Browse files
wesbillmanBrain
andauthored
feat(desktop): star channels (Slack-style favorites) (#860)
Signed-off-by: Wes <[email protected]> Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co>
1 parent f748f71 commit c10b4f8

10 files changed

Lines changed: 1024 additions & 24 deletions

File tree

‎desktop/playwright.config.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ export default defineConfig({
2727
"**/custom-emoji.spec.ts",
2828
"**/custom-emoji-screenshots.spec.ts",
2929
"**/channel-mute-screenshots.spec.ts",
30+
"**/channel-star-screenshots.spec.ts",
3031
"**/file-attachment.spec.ts",
3132
"**/mentions.spec.ts",
3233
"**/relay-reconnect.spec.ts",

‎desktop/src/app/AppShell.tsx‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ import { HuddleBar, HuddleProvider } from "@/features/huddle";
5757
import { useMeshRelayOrchestrator } from "@/features/mesh-compute/hooks/useMeshRelayOrchestrator";
5858
import { AppSidebar } from "@/features/sidebar/ui/AppSidebar";
5959
import { useChannelMutes } from "@/features/sidebar/lib/useChannelMutes";
60+
import { useChannelStars } from "@/features/sidebar/lib/useChannelStars";
6061
import { useWorkspaces } from "@/features/workspaces/useWorkspaces";
6162
import { useApplyTemplate } from "@/features/channel-templates/useApplyTemplate";
6263
import { relayClient } from "@/shared/api/relayClient";
@@ -208,6 +209,9 @@ export function AppShell() {
208209
const { mutedChannelIds, muteChannel, unmuteChannel } = useChannelMutes(
209210
identityQuery.data?.pubkey,
210211
);
212+
const { starredChannelIds, starChannel, unstarChannel } = useChannelStars(
213+
identityQuery.data?.pubkey,
214+
);
211215
const profileQuery = useProfileQuery();
212216
const deferredPubkey = startupReady ? identityQuery.data?.pubkey : undefined;
213217
usePresenceSubscription();
@@ -818,6 +822,9 @@ export function AppShell() {
818822
mutedChannelIds={mutedChannelIds}
819823
onMuteChannel={muteChannel}
820824
onUnmuteChannel={unmuteChannel}
825+
starredChannelIds={starredChannelIds}
826+
onStarChannel={starChannel}
827+
onUnstarChannel={unstarChannel}
821828
/>
822829

823830
<SidebarInset className="min-h-0 min-w-0 overflow-hidden">
Lines changed: 258 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,258 @@
1+
import assert from "node:assert/strict";
2+
import test from "node:test";
3+
4+
import {
5+
parseStarPayload,
6+
mergeStores,
7+
starredChannelIdsFromStore,
8+
} from "./channelStarsStorage.ts";
9+
10+
// ── parseStarPayload ──────────────────────────────────────────────────────────
11+
12+
test("parseStarPayload: valid payload with channels returns store", () => {
13+
const payload = {
14+
version: 1,
15+
channels: {
16+
"chan-1": { starred: true, updatedAt: 1000 },
17+
"chan-2": { starred: false, updatedAt: 2000 },
18+
},
19+
};
20+
const result = parseStarPayload(payload);
21+
assert.deepEqual(result, {
22+
version: 1,
23+
channels: {
24+
"chan-1": { starred: true, updatedAt: 1000 },
25+
"chan-2": { starred: false, updatedAt: 2000 },
26+
},
27+
});
28+
});
29+
30+
test("parseStarPayload: missing version returns null", () => {
31+
assert.equal(
32+
parseStarPayload({
33+
channels: { "chan-1": { starred: true, updatedAt: 1 } },
34+
}),
35+
null,
36+
);
37+
});
38+
39+
test("parseStarPayload: wrong version returns null", () => {
40+
assert.equal(
41+
parseStarPayload({
42+
version: 2,
43+
channels: { "chan-1": { starred: true, updatedAt: 1 } },
44+
}),
45+
null,
46+
);
47+
});
48+
49+
test("parseStarPayload: null input returns null", () => {
50+
assert.equal(parseStarPayload(null), null);
51+
});
52+
53+
test("parseStarPayload: non-object input returns null", () => {
54+
assert.equal(parseStarPayload("string"), null);
55+
assert.equal(parseStarPayload(42), null);
56+
assert.equal(parseStarPayload(true), null);
57+
});
58+
59+
test("parseStarPayload: malformed channel entries missing starred/updatedAt are filtered out", () => {
60+
const payload = {
61+
version: 1,
62+
channels: {
63+
"no-starred": { updatedAt: 1000 },
64+
"no-updated-at": { starred: true },
65+
valid: { starred: false, updatedAt: 500 },
66+
"starred-wrong-type": { starred: "yes", updatedAt: 1000 },
67+
"updated-at-wrong-type": { starred: true, updatedAt: "now" },
68+
null: null,
69+
},
70+
};
71+
const result = parseStarPayload(payload);
72+
assert.deepEqual(result, {
73+
version: 1,
74+
channels: {
75+
valid: { starred: false, updatedAt: 500 },
76+
},
77+
});
78+
});
79+
80+
test("parseStarPayload: NaN/Infinity/negative updatedAt entries are filtered out", () => {
81+
const payload = {
82+
version: 1,
83+
channels: {
84+
nan: { starred: true, updatedAt: NaN },
85+
inf: { starred: true, updatedAt: Infinity },
86+
"neg-inf": { starred: true, updatedAt: -Infinity },
87+
neg: { starred: true, updatedAt: -1 },
88+
valid: { starred: true, updatedAt: 100 },
89+
},
90+
};
91+
const result = parseStarPayload(payload);
92+
assert.deepEqual(result, {
93+
version: 1,
94+
channels: { valid: { starred: true, updatedAt: 100 } },
95+
});
96+
});
97+
98+
test("parseStarPayload: empty channels returns store with empty channels", () => {
99+
const result = parseStarPayload({ version: 1, channels: {} });
100+
assert.deepEqual(result, { version: 1, channels: {} });
101+
});
102+
103+
test("parseStarPayload: version 1 with no channels key returns store with empty channels", () => {
104+
const result = parseStarPayload({ version: 1 });
105+
assert.deepEqual(result, { version: 1, channels: {} });
106+
});
107+
108+
// ── mergeStores ───────────────────────────────────────────────────────────────
109+
110+
test("mergeStores: non-overlapping channels returns union of both", () => {
111+
const local = {
112+
version: 1,
113+
channels: { "chan-a": { starred: true, updatedAt: 100 } },
114+
};
115+
const remote = {
116+
version: 1,
117+
channels: { "chan-b": { starred: false, updatedAt: 200 } },
118+
};
119+
const result = mergeStores(local, remote);
120+
assert.deepEqual(result, {
121+
version: 1,
122+
channels: {
123+
"chan-a": { starred: true, updatedAt: 100 },
124+
"chan-b": { starred: false, updatedAt: 200 },
125+
},
126+
});
127+
});
128+
129+
test("mergeStores: overlapping channel with remote newer takes remote", () => {
130+
const local = {
131+
version: 1,
132+
channels: { "chan-a": { starred: false, updatedAt: 100 } },
133+
};
134+
const remote = {
135+
version: 1,
136+
channels: { "chan-a": { starred: true, updatedAt: 200 } },
137+
};
138+
const result = mergeStores(local, remote);
139+
assert.deepEqual(result.channels["chan-a"], {
140+
starred: true,
141+
updatedAt: 200,
142+
});
143+
});
144+
145+
test("mergeStores: overlapping channel with local newer takes local", () => {
146+
const local = {
147+
version: 1,
148+
channels: { "chan-a": { starred: true, updatedAt: 300 } },
149+
};
150+
const remote = {
151+
version: 1,
152+
channels: { "chan-a": { starred: false, updatedAt: 100 } },
153+
};
154+
const result = mergeStores(local, remote);
155+
assert.deepEqual(result.channels["chan-a"], {
156+
starred: true,
157+
updatedAt: 300,
158+
});
159+
});
160+
161+
test("mergeStores: overlapping channel with same updatedAt local wins", () => {
162+
const local = {
163+
version: 1,
164+
channels: { "chan-a": { starred: true, updatedAt: 500 } },
165+
};
166+
const remote = {
167+
version: 1,
168+
channels: { "chan-a": { starred: false, updatedAt: 500 } },
169+
};
170+
const result = mergeStores(local, remote);
171+
assert.deepEqual(result.channels["chan-a"], {
172+
starred: true,
173+
updatedAt: 500,
174+
});
175+
});
176+
177+
test("mergeStores: unstar with higher updatedAt overrides star", () => {
178+
const local = {
179+
version: 1,
180+
channels: { "chan-a": { starred: true, updatedAt: 100 } },
181+
};
182+
const remote = {
183+
version: 1,
184+
channels: { "chan-a": { starred: false, updatedAt: 999 } },
185+
};
186+
const result = mergeStores(local, remote);
187+
assert.deepEqual(result.channels["chan-a"], {
188+
starred: false,
189+
updatedAt: 999,
190+
});
191+
});
192+
193+
test("mergeStores: empty local returns remote entries", () => {
194+
const local = { version: 1, channels: {} };
195+
const remote = {
196+
version: 1,
197+
channels: { "chan-b": { starred: true, updatedAt: 42 } },
198+
};
199+
const result = mergeStores(local, remote);
200+
assert.deepEqual(result.channels, {
201+
"chan-b": { starred: true, updatedAt: 42 },
202+
});
203+
});
204+
205+
test("mergeStores: empty remote returns local entries", () => {
206+
const local = {
207+
version: 1,
208+
channels: { "chan-a": { starred: false, updatedAt: 10 } },
209+
};
210+
const remote = { version: 1, channels: {} };
211+
const result = mergeStores(local, remote);
212+
assert.deepEqual(result.channels, {
213+
"chan-a": { starred: false, updatedAt: 10 },
214+
});
215+
});
216+
217+
test("mergeStores: both empty returns empty", () => {
218+
const result = mergeStores(
219+
{ version: 1, channels: {} },
220+
{ version: 1, channels: {} },
221+
);
222+
assert.deepEqual(result, { version: 1, channels: {} });
223+
});
224+
225+
// ── starredChannelIdsFromStore ────────────────────────────────────────────────
226+
227+
test("starredChannelIdsFromStore: returns set of IDs where starred=true", () => {
228+
const store = {
229+
version: 1,
230+
channels: {
231+
"chan-a": { starred: true, updatedAt: 100 },
232+
"chan-b": { starred: true, updatedAt: 200 },
233+
"chan-c": { starred: false, updatedAt: 300 },
234+
},
235+
};
236+
const result = starredChannelIdsFromStore(store);
237+
assert.equal(result.has("chan-a"), true);
238+
assert.equal(result.has("chan-b"), true);
239+
assert.equal(result.has("chan-c"), false);
240+
assert.equal(result.size, 2);
241+
});
242+
243+
test("starredChannelIdsFromStore: excludes IDs where starred=false", () => {
244+
const store = {
245+
version: 1,
246+
channels: {
247+
"chan-x": { starred: false, updatedAt: 1 },
248+
"chan-y": { starred: false, updatedAt: 2 },
249+
},
250+
};
251+
const result = starredChannelIdsFromStore(store);
252+
assert.equal(result.size, 0);
253+
});
254+
255+
test("starredChannelIdsFromStore: empty channels returns empty set", () => {
256+
const result = starredChannelIdsFromStore({ version: 1, channels: {} });
257+
assert.equal(result.size, 0);
258+
});

0 commit comments

Comments
 (0)