Skip to content

Commit be275cf

Browse files
authored
fix(desktop): keep identity key help dialog readable in dark mode (#2854)
## Problem With macOS in dark mode (the default for fresh profiles is to follow the system scheme), the onboarding "What's an identity key?" help dialog renders its title in near-white on the always-white textured card, making it unreadable. The body paragraphs stay readable because they use the fixed olive `--buzz-onboarding-backup-ink`; only the `text-foreground` title (and the close button's hover color) flip with the theme. ## Cause The dialog's `DialogContent` carries `buzz-onboarding-neutral-theme` but is portaled outside the `buzz-startup-shell` subtree, so in dark mode it matches `.dark .buzz-onboarding-neutral-theme:not(.buzz-startup-shell)` (`components.css`), which flips `--foreground` to `0 0% 98%`. The textured powder card (`buzz-card-textured`) has no dark variant — it is baked light — so the near-white title disappears against it. ## Fix One attribute: pin the dialog to the light neutral theme with `data-system-color-scheme="light"`. This is the established pattern for always-light onboarding dialogs (`HostedCommunityOnboarding.tsx`, the `CommunityOnboardingFlow.tsx` avatar dialog), and the pinned-light CSS rule already exists and out-specifies the dark-mode flip. No new CSS. ## Testing - Added a dark-mode regression test to `tests/e2e/identity-key-help.spec.ts` (already registered in the Playwright smoke project): emulates `prefers-color-scheme: dark`, opens the dialog, and asserts the title resolves to the pinned light-neutral ink `rgb(23, 23, 23)`. Before the fix it rendered `rgb(250, 250, 250)`. - Manual repro: macOS appearance set to Dark → fresh profile → machine onboarding → click "What's an identity key?". Before/after screenshots are in the comment below. Signed-off-by: Michael Pfister <[email protected]>
1 parent f2fe3b6 commit be275cf

2 files changed

Lines changed: 36 additions & 0 deletions

File tree

‎desktop/src/features/onboarding/ui/IdentityKeyHelpDialog.tsx‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ export function IdentityKeyHelpDialog() {
6767
<DialogContent
6868
className="buzz-onboarding-neutral-theme max-w-[47.5rem] -translate-y-5"
6969
closeButtonClassName={ONBOARDING_INK_ICON_CLASS}
70+
data-system-color-scheme="light"
7071
data-testid="identity-key-help-dialog"
7172
overlayVariant="transparent"
7273
surface="textured"

‎desktop/tests/e2e/identity-key-help.spec.ts‎

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,3 +56,38 @@ test("identity key help explains the first-run choice", async ({ page }) => {
5656
"1",
5757
);
5858
});
59+
60+
test("identity key help stays readable when the app resolves dark mode", async ({
61+
page,
62+
}) => {
63+
await page.emulateMedia({ colorScheme: "dark" });
64+
await installMockBridge(page, undefined, {
65+
skipCommunitySeed: true,
66+
skipOnboardingSeed: true,
67+
});
68+
await page.goto("/");
69+
70+
// Fresh profiles follow the system scheme, so the emulated dark scheme is
71+
// the first-run repro: the app resolves the dark theme while onboarding.
72+
await expect
73+
.poll(() =>
74+
page.evaluate(() => document.documentElement.classList.contains("dark")),
75+
)
76+
.toBe(true);
77+
78+
const trigger = page.getByTestId("identity-key-help-trigger");
79+
await expect(trigger).toHaveCSS("opacity", "1", { timeout: 5000 });
80+
await trigger.click();
81+
82+
const dialog = page.getByTestId("identity-key-help-dialog");
83+
await expect(dialog).toBeVisible();
84+
await waitForAnimations(page);
85+
86+
// The textured powder card is baked light in both themes, so the dialog pins
87+
// the neutral onboarding theme to its light variant. Without the pin the
88+
// dark theme flips --foreground to near-white and the title disappears
89+
// against the white card.
90+
await expect(
91+
dialog.getByRole("heading", { name: "What’s an identity key?" }),
92+
).toHaveCSS("color", "rgb(23, 23, 23)");
93+
});

0 commit comments

Comments
 (0)