Skip to content

Commit bb002e7

Browse files
fix(workflow): bypass system proxies for webhooks (#2800)
## Summary Disable automatic system-proxy discovery for workflow webhook requests. ## Why Webhook destinations are resolved, validated, and pinned before the request to prevent DNS-rebinding SSRF. If reqwest uses a system proxy, the proxy can resolve the original hostname itself instead of connecting to the validated address, bypassing that pinning guarantee. Calling `no_proxy()` keeps these security-sensitive requests on the directly validated connection path. Redirects remain disabled. ## Test plan - `cargo fmt --all -- --check` - `cargo test -p buzz-workflow --features reqwest` (149 passed) - `cargo clippy -p buzz-workflow --all-targets --features reqwest -- -D warnings` - `git diff --check` Co-authored-by: Amp <[email protected]>
1 parent 9faf102 commit bb002e7

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

‎crates/buzz-workflow/src/executor.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -805,6 +805,9 @@ async fn call_webhook_impl(
805805
// different address than the one validated above (DNS rebinding TOCTOU).
806806
let client = Client::builder()
807807
.timeout(Duration::from_secs(10))
808+
// A system proxy would resolve the original hostname itself, bypassing
809+
// the validated and pinned address above.
810+
.no_proxy()
808811
// Disable redirects — a redirect to an internal host bypasses the SSRF check.
809812
.redirect(reqwest::redirect::Policy::none())
810813
.resolve(host, std::net::SocketAddr::new(safe_ip, port))

0 commit comments

Comments
 (0)