Skip to content

Commit b572e70

Browse files
browclaude
andcommitted
fix(mobile): restore the Builderlab session before gating agents
On a cold start the account client has no subject until a saved session is restored, which hid Agents for a signed-in owner. The gate now restores once. Pull-to-refresh keeps showing owned agents, and the refresh test reloads the community for real. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Tom Brow <[email protected]>
1 parent 72e4623 commit b572e70

3 files changed

Lines changed: 49 additions & 2 deletions

File tree

‎mobile/lib/features/agents/agents_sheet.dart‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,15 @@ class AgentsSheet extends HookConsumerWidget {
157157
return ownedCommunityAgents(registeredKeys, controller.owner, fetch);
158158
}, [community?.relayUrl, registeredKey, controller.owner, attempt.value]);
159159
final registered = useFuture(registryFuture, preserveState: false);
160+
// A refresh keeps showing the last owned agents for the same registry.
161+
final scope = '${community?.relayUrl}|$registeredKey|${controller.owner}';
162+
final lastOwned = useRef<(String, Set<String>)?>(null);
163+
if (registered.data case final owned?) lastOwned.value = (scope, owned);
164+
final owned =
165+
registered.data ??
166+
(lastOwned.value?.$1 == scope ? lastOwned.value?.$2 : null);
160167
final keys = {
161-
...?registered.data,
168+
...?owned,
162169
for (final entry in directory.asData?.value ?? <AgentDirectoryEntry>[])
163170
entry.pubkey,
164171
}.where((key) => !controller.deletedAgents.contains(key)).toList();

‎mobile/lib/shared/agents/remote_agents.dart‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,19 @@ bool supportsRemoteAgents(Community? community) =>
3030
community.pubkey != null &&
3131
HostedEnvironment.supportsRelay(Uri.parse(community.relayUrl));
3232

33+
/// Restores a saved Builderlab session once, so a cold start with a stored
34+
/// session shows remote agents without waiting for another sign-in path.
35+
final builderlabRestoreProvider = FutureProvider<void>((ref) async {
36+
try {
37+
await ref.watch(builderlabAccountProvider).restore();
38+
} on Object {
39+
// Unreachable or rejected sessions stay signed out; sign-in recovers them.
40+
}
41+
});
42+
3343
/// Whether a Builderlab account is signed in, updating on sign-in and out.
3444
final builderlabSignedInProvider = Provider<bool>((ref) {
45+
if (HostedEnvironment.enabled) ref.watch(builderlabRestoreProvider);
3546
final subject = ref.watch(builderlabAccountProvider).subjectChanges;
3647
void changed() => ref.invalidateSelf();
3748
subject.addListener(changed);

‎mobile/test/shared/agents/remote_agents_test.dart‎

Lines changed: 30 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import 'package:buzz/shared/community/community.dart';
77
import 'package:buzz/shared/community/community_provider.dart';
88
import 'package:buzz/shared/crypto/nip_oa.dart';
99
import 'package:buzz/shared/hosted/account_identity_store.dart';
10+
import 'package:buzz/shared/hosted/builderlab_account.dart';
1011
import 'package:buzz/shared/hosted/hosted_environment.dart';
1112
import 'package:buzz/shared/hosted/hosted_relay_auth.dart';
1213
import 'package:buzz/shared/relay/relay.dart';
@@ -24,6 +25,18 @@ final _scope = 'remote-agents:${HostedEnvironment.origin.host}:$fakeSubject';
2425
/// Deterministic test keys.
2526
nostr.Keys _keys(String last) => nostr.Keys('0' * 63 + last);
2627

28+
/// Starts signed out, like a cold start, until its saved session is restored.
29+
class _RestoringRegistry extends FakeRegistry {
30+
_RestoringRegistry() : super(signedIn: false);
31+
32+
@override
33+
Future<BuilderlabAccount?> restore() async {
34+
await Future<void>.delayed(Duration.zero);
35+
signedIn = true;
36+
return account;
37+
}
38+
}
39+
2740
Community _community({String? pubkey}) => Community.create(
2841
name: 'Test',
2942
relayUrl: 'wss://test.${HostedEnvironment.communitySuffix}',
@@ -102,7 +115,7 @@ void main() {
102115
HostedEnvironment.enabled,
103116
);
104117
// A community refresh keeps the surfaces open on the previous value.
105-
container.invalidate(activeCommunityProvider);
118+
container.invalidate(activeCommunityProvider, asReload: true);
106119
expect(container.read(activeCommunityProvider).isLoading, isTrue);
107120
expect(
108121
container.read(remoteAgentsEnabledProvider),
@@ -112,6 +125,22 @@ void main() {
112125
expect(container.read(remoteAgentsEnabledProvider), isFalse);
113126
});
114127

128+
test('a saved Builderlab session is restored on cold start', () async {
129+
final registry = _RestoringRegistry();
130+
addTearDown(registry.dispose);
131+
final container = ProviderContainer(
132+
overrides: [builderlabAccountProvider.overrideWithValue(registry)],
133+
);
134+
addTearDown(container.dispose);
135+
expect(container.read(builderlabSignedInProvider), isFalse);
136+
// Nothing else restores the account; the gate itself must.
137+
await Future<void>.delayed(Duration.zero);
138+
expect(
139+
container.read(builderlabSignedInProvider),
140+
HostedEnvironment.enabled,
141+
);
142+
});
143+
115144
test('a failed listing is reported instead of an empty registry', () async {
116145
final registry = FakeRegistry(bound: fakeOwner.public)..failListing = true;
117146
final controller = await _controller(registry);

0 commit comments

Comments
 (0)