You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b3b1256
Browse filesBrowse the repository at this point in the historyBrowse files
fix(mobile): bind same-name mentions to exact selected identities
Two members sharing a display name could not be told apart in mobile
mentions: picking the second overwrote the first's selection, rendering
linked whichever same-name person matched first, and a later rename or a
shorter name could re-bind the text to the wrong recipient. This binds
every mention to the exact selected identity:
- Track each same-name selection under its recipient key instead of
overwriting by label; conflicting picks render a qualified label like
`Name (key...)`.
- Match the longest label first, so a shorter or interior name can
never claim part of a longer one and steal its identity; ambiguous
labels block shorter mentions instead of silently re-binding.
- Render mentions from the signed identity key in each event's tags,
never from message text alone, so qualified labels stay correct
regardless of tag order and survive later renames. Qualified-label
authority now derives from the event's complete signed tags (`p` and
reference-only `mention` entries), computed inside MessageContent and
passed explicitly to the binding computation, never from optional
cached display names: a signed full-key mention keeps its exact
navigation even when its profile is missing, while ordinary aliases
and untagged namesakes stay denied. Sorted signed keys join the
rendered presentation identity so a rebuilt body cannot retain stale
authorization.
- Persist exact identity selections with the draft text; malformed
records refuse visibly, and send revalidates saved mentions instead of
falling back to a same-name roster entry.
Qualified-label destinations are asserted through the production
ChannelDetailPage and ThreadDetailPage consumers across both signed tag
orders and present, renamed, key-fallback and missing profiles, tapping
each qualified label to open exactly its signed profile sheet.
Ports the landed Desktop exact-recipient behavior (docs/mention-editor.md).
Full mobile package suite passes on this tree (2,121 tests), with the
analyzer and formatter clean.
Signed-off-by: Logan Johnson <[email protected]>
0 commit comments