Skip to content

Commit a4fbebb

Browse files
wpfleger96npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7
andauthored
perf(desktop): virtualize unbounded lists and warm the emoji index (#1089)
Signed-off-by: Will Pfleger <[email protected]> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
1 parent 3bf2ac0 commit a4fbebb

17 files changed

Lines changed: 686 additions & 201 deletions

File tree

‎desktop/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
"@radix-ui/react-tooltip": "^1.2.8",
4646
"@tanstack/react-query": "^5.90.21",
4747
"@tanstack/react-router": "^1.168.10",
48+
"@tanstack/react-virtual": "^3.14.2",
4849
"@tauri-apps/api": "~2.11",
4950
"@tauri-apps/plugin-notification": "^2.3.3",
5051
"@tauri-apps/plugin-opener": "~2.5",

‎desktop/playwright.config.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ export default defineConfig({
4848
"**/thread-unread-screenshots.spec.ts",
4949
"**/animated-avatar-screenshots.spec.ts",
5050
"**/reminders-screenshots.spec.ts",
51+
"**/virtualization-screenshots.spec.ts",
5152
],
5253
use: {
5354
...devices["Desktop Chrome"],

‎desktop/src/features/agents/ui/AgentSessionTranscriptList.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export function AgentSessionTranscriptList({
4242
role="log"
4343
>
4444
{items.map((item) => (
45-
<div className="mt-4 first:mt-0" key={item.id}>
45+
<div className="mt-4 first:mt-0 content-visibility-auto" key={item.id}>
4646
<TranscriptItemView
4747
agentName={agentName}
4848
item={item}

‎desktop/src/features/channels/ui/ChannelCanvas.tsx‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ export function ChannelCanvas({
3636
const [draft, setDraft] = React.useState("");
3737

3838
const canvasContent = canvasQuery.data?.content ?? null;
39+
// Defer the single large Markdown parse so opening the canvas commits the
40+
// surrounding chrome immediately and the heavy render reconciles after.
41+
const deferredCanvasContent = React.useDeferredValue(canvasContent);
3942

4043
function handleStartEditing() {
4144
setDraft(canvasContent ?? "");
@@ -121,7 +124,10 @@ export function ChannelCanvas({
121124
className="rounded-2xl border border-border/70 bg-muted/20 px-4 py-3"
122125
data-testid="channel-canvas-content"
123126
>
124-
<Markdown channelNames={channelNames} content={canvasContent} />
127+
<Markdown
128+
channelNames={channelNames}
129+
content={deferredCanvasContent ?? ""}
130+
/>
125131
</div>
126132
) : (
127133
<p className="text-sm text-muted-foreground">

‎desktop/src/features/channels/ui/MembersSidebar.tsx‎

Lines changed: 41 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -432,46 +432,47 @@ export function MembersSidebar({
432432

433433
function renderMemberCard(member: ChannelMember, memberIsBot: boolean) {
434434
return (
435-
<MembersSidebarMemberCard
436-
canChangeRole={canManageMembers && member.pubkey !== currentPubkey}
437-
canRemoveMember={canRemoveMember(member)}
438-
isActionPending={isActionPending || changeRoleMutation.isPending}
439-
isArchived={isArchived}
440-
key={member.pubkey}
441-
managedAgent={
442-
memberIsBot
443-
? managedAgentByPubkey.get(normalizePubkey(member.pubkey))
444-
: undefined
445-
}
446-
member={member}
447-
memberIsBot={memberIsBot}
448-
memberAvatarLabel={member.displayName ?? formatPubkey(member.pubkey)}
449-
memberLabel={formatMemberName(member, currentPubkey)}
450-
onChangeRole={(m, role) => {
451-
void changeRoleMutation.mutateAsync({ pubkey: m.pubkey, role });
452-
}}
453-
onEditRespondTo={memberIsBot ? setEditRespondToAgent : undefined}
454-
onManagedAgentAction={(agent) => {
455-
void handleAgentLifecycleAction(agent);
456-
}}
457-
onOpenProfile={handleOpenProfile}
458-
onRemoveMember={handleRemoveMember}
459-
onViewActivity={
460-
onViewActivity
461-
? (pubkey: string) => {
462-
onOpenChange(false);
463-
onViewActivity(pubkey);
464-
}
465-
: undefined
466-
}
467-
presenceStatus={
468-
memberPresenceQuery.data?.[member.pubkey.toLowerCase()] ?? null
469-
}
470-
profileAvatarUrl={
471-
memberProfilesQuery.data?.profiles[member.pubkey.toLowerCase()]
472-
?.avatarUrl ?? null
473-
}
474-
/>
435+
<div className="content-visibility-auto" key={member.pubkey}>
436+
<MembersSidebarMemberCard
437+
canChangeRole={canManageMembers && member.pubkey !== currentPubkey}
438+
canRemoveMember={canRemoveMember(member)}
439+
isActionPending={isActionPending || changeRoleMutation.isPending}
440+
isArchived={isArchived}
441+
managedAgent={
442+
memberIsBot
443+
? managedAgentByPubkey.get(normalizePubkey(member.pubkey))
444+
: undefined
445+
}
446+
member={member}
447+
memberIsBot={memberIsBot}
448+
memberAvatarLabel={member.displayName ?? formatPubkey(member.pubkey)}
449+
memberLabel={formatMemberName(member, currentPubkey)}
450+
onChangeRole={(m, role) => {
451+
void changeRoleMutation.mutateAsync({ pubkey: m.pubkey, role });
452+
}}
453+
onEditRespondTo={memberIsBot ? setEditRespondToAgent : undefined}
454+
onManagedAgentAction={(agent) => {
455+
void handleAgentLifecycleAction(agent);
456+
}}
457+
onOpenProfile={handleOpenProfile}
458+
onRemoveMember={handleRemoveMember}
459+
onViewActivity={
460+
onViewActivity
461+
? (pubkey: string) => {
462+
onOpenChange(false);
463+
onViewActivity(pubkey);
464+
}
465+
: undefined
466+
}
467+
presenceStatus={
468+
memberPresenceQuery.data?.[member.pubkey.toLowerCase()] ?? null
469+
}
470+
profileAvatarUrl={
471+
memberProfilesQuery.data?.profiles[member.pubkey.toLowerCase()]
472+
?.avatarUrl ?? null
473+
}
474+
/>
475+
</div>
475476
);
476477
}
477478

‎desktop/src/features/custom-emoji/ui/EmojiPicker.tsx‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,33 @@
11
import data from "@emoji-mart/data";
22
import Picker from "@emoji-mart/react";
3+
import { init } from "emoji-mart";
34
import * as React from "react";
45

56
import { buildCustomEmojiCategory } from "@/features/custom-emoji/emojiMartCategory";
67
import { useCustomEmoji } from "@/features/custom-emoji/hooks";
78

9+
// emoji-mart builds its searchable index synchronously inside `init`, which
10+
// `<Picker>` calls on mount — so the first reaction popover open paid the full
11+
// ~1.8k-emoji index build and froze the cursor. Warm `init({ data })` once at
12+
// idle so the index is prebuilt; `init` is a no-op after the first call (its
13+
// `Data` singleton guards the rebuild), so the Picker's mount-time `init` skips
14+
// the heavy work. Search still reads the prebuilt index — no first-keystroke
15+
// hitch. Module-level so it fires regardless of when a picker first mounts.
16+
let warmStarted = false;
17+
function warmEmojiIndex() {
18+
if (warmStarted) {
19+
return;
20+
}
21+
warmStarted = true;
22+
const warm = () => void init({ data });
23+
if (typeof window !== "undefined" && "requestIdleCallback" in window) {
24+
window.requestIdleCallback(warm, { timeout: 1_500 });
25+
} else {
26+
globalThis.setTimeout(warm, 250);
27+
}
28+
}
29+
warmEmojiIndex();
30+
831
/**
932
* The one emoji picker for the whole app. Every place that lets a user choose
1033
* an emoji — composing a message, reacting to a regular or system message,

‎desktop/src/features/forum/ui/ForumThreadPanel.tsx‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,10 @@ function ReplyRow({
7575
const replyMentionNames = resolveMentionNames(reply.tags, profiles);
7676

7777
return (
78-
<div className="group px-4 py-3" data-forum-event-id={reply.eventId}>
78+
<div
79+
className="group content-visibility-auto px-4 py-3"
80+
data-forum-event-id={reply.eventId}
81+
>
7982
<div className="flex items-center gap-2">
8083
<UserProfilePopover pubkey={reply.pubkey}>
8184
<button

‎desktop/src/features/forum/ui/ForumView.tsx‎

Lines changed: 29 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import type { Channel } from "@/shared/api/types";
77
import { channelChrome } from "@/shared/layout/chromeLayout";
88
import { cn } from "@/shared/lib/cn";
99
import { Skeleton } from "@/shared/ui/skeleton";
10+
import { VirtualizedList } from "@/shared/ui/VirtualizedList";
1011

1112
import {
1213
useCreateForumPostMutation,
@@ -47,6 +48,7 @@ export function ForumView({
4748
targetReplyId,
4849
}: ForumViewProps) {
4950
const [isComposerOpen, setIsComposerOpen] = React.useState(false);
51+
const postsScrollRef = React.useRef<HTMLDivElement>(null);
5052

5153
const profileQuery = useProfileQuery();
5254
const postsQuery = useForumPostsQuery(channel);
@@ -185,6 +187,7 @@ export function ForumView({
185187
<div
186188
className="flex-1 overflow-y-auto"
187189
data-scroll-restoration-id={`forum-list:${channel.id}`}
190+
ref={postsScrollRef}
188191
>
189192
{postsQuery.isLoading ? (
190193
<div className="space-y-3 p-4">
@@ -205,26 +208,32 @@ export function ForumView({
205208
</div>
206209
</div>
207210
) : (
208-
<div className="space-y-3 p-4">
209-
{posts.map((post) => (
210-
<ForumPostCard
211-
canDelete={canDelete(post.pubkey, effectiveCurrentPubkey)}
212-
currentPubkey={effectiveCurrentPubkey}
213-
isActive={selectedPostId === post.eventId}
214-
isDeleting={
215-
deletePostMutation.isPending &&
216-
deletePostMutation.variables?.eventId === post.eventId
217-
}
218-
key={post.eventId}
219-
onClick={() => onSelectPost(post.eventId)}
220-
onDelete={(eventId) => {
221-
deletePostMutation.mutate({ eventId });
222-
}}
223-
post={post}
224-
profiles={profiles}
225-
/>
226-
))}
227-
</div>
211+
<VirtualizedList
212+
estimateSize={120}
213+
getItemKey={(post) => post.eventId}
214+
innerClassName="p-4"
215+
items={posts}
216+
renderItem={(post) => (
217+
<div className="pb-3">
218+
<ForumPostCard
219+
canDelete={canDelete(post.pubkey, effectiveCurrentPubkey)}
220+
currentPubkey={effectiveCurrentPubkey}
221+
isActive={selectedPostId === post.eventId}
222+
isDeleting={
223+
deletePostMutation.isPending &&
224+
deletePostMutation.variables?.eventId === post.eventId
225+
}
226+
onClick={() => onSelectPost(post.eventId)}
227+
onDelete={(eventId) => {
228+
deletePostMutation.mutate({ eventId });
229+
}}
230+
post={post}
231+
profiles={profiles}
232+
/>
233+
</div>
234+
)}
235+
scrollRef={postsScrollRef}
236+
/>
228237
)}
229238
</div>
230239
</div>

0 commit comments

Comments
 (0)