You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 9b46232
Browse filesBrowse the repository at this point in the historyBrowse files
fix(desktop): drop live traces on any exit from the channel surface
Blind-review round 7 (Opus medium) findings:
- P2: a trace begun while the channel route was still resolving never
mounted ChannelScreen, so no route-exit cleanup existed; leaving for
Home and history-backing into the channel within 30s settled the
stale trace with the time spent away. Any committed non-channel
navigation and any history traversal now drop the active trace at the
navigation layer (dropActiveChannelSwitchTrace), which covers traces
no component ever owned. Same-channel navigations keep the live
trace.
- The delayed-chunk spec now asserts no CLEAN measure while the chunk
is held (the tracer honestly emits a truncated one if its 5s deadline
passes) and guards its own timing budget explicitly so a slow CI box
fails with the real reason.
- The rotation-degradation test blocks rotation with a non-empty
directory instead of chmod, so it also holds when tests run as root
(containers), and now runs on Windows too.
Co-Authored-By: Claude Fable 5 <[email protected]>
Signed-off-by: Max Lampert <[email protected]>
0 commit comments