Skip to content

Commit 9514760

Browse files
author
Michael Feth
committed
test(desktop): assert the real Welcome starter names in the Fizz-reuse test
The retired-Fizz reuse test asserted the two minted teammates were ["Bumble", "Honey"]. `builtin:bumble` is a persona id, not a display name -- WELCOME_TEAM_STARTERS names that starter "Pollen": { name: "Honey", personaId: "builtin:honey" } { name: "Pollen", personaId: "builtin:bumble" } So the assertion could never pass. It failed deterministically on all three attempts (two CI retries), which is what turned the "Desktop E2E Integration" required check red. The behaviour under test was already correct: exactly two create_managed_agent calls were made, so the retired built-in Fizz record was reused rather than re-minted. Only the expected names were wrong. Signed-off-by: Michael Feth <[email protected]>
1 parent 56fdeba commit 9514760

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎desktop/tests/e2e/onboarding.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3349,7 +3349,7 @@ test("an upgraded install reuses the retired built-in Fizz instead of minting a
33493349
(entry.payload as { input?: { name?: string } })?.input?.name,
33503350
),
33513351
);
3352-
expect(createdNames.sort()).toEqual(["Bumble", "Honey"]);
3352+
expect(createdNames.sort()).toEqual(["Honey", "Pollen"]);
33533353

33543354
const agents = await invokeMockCommand<
33553355
Array<{ pubkey: string; name: string; persona_id: string | null }>

0 commit comments

Comments
 (0)