Repository navigation
Commit 8cce3c0
fix(desktop): render compact npub for unnamed relay thread participants
jedwards27 review of PR #7495 (exact head a1ffa77, 22:10:51Z) flagged
[P2] that buildRelayThreadSummary fell back from a missing profile name
to the raw pubkey, so a cold/relay-only thread facepile exposed the raw
64-char hex identity via UserAvatar's displayName label while the
client-assembled path (resolveUserLabel) already renders the compact
npub.
Fall back to truncateNpub(pubkey) instead — the same canonical compact
identity form used everywhere else in this PR. Authored profile names
are untouched; distinct key-tail avatar initials come for free because
getInitials derives them from the compact npub shape.
Replace the review-flagged invalid relay-summary fixture ("bob")
with a valid 64-hex key and assert the compact npub label — the value
MessageThreadSummaryRow binds to UserAvatar's visible/accessible
displayName. Verified falsifiable: reverting the fallback to raw
pubkey fails the test.
Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
Signed-off-by: Logan Johnson <[email protected]>1 parent a1ffa77 commit 8cce3c0
2 files changed
Lines changed: 18 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
607 | 607 | | |
608 | 608 | | |
609 | 609 | | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
610 | 617 | | |
611 | 618 | | |
612 | 619 | | |
613 | 620 | | |
614 | 621 | | |
615 | 622 | | |
616 | 623 | | |
617 | | - | |
| 624 | + | |
618 | 625 | | |
619 | 626 | | |
620 | 627 | | |
| |||
631 | 638 | | |
632 | 639 | | |
633 | 640 | | |
634 | | - | |
| 641 | + | |
635 | 642 | | |
636 | 643 | | |
637 | | - | |
| 644 | + | |
638 | 645 | | |
639 | 646 | | |
640 | 647 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
408 | 409 | | |
409 | 410 | | |
410 | 411 | | |
411 | | - | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
412 | 419 | | |
413 | 420 | | |
414 | 421 | | |
| |||
0 commit comments