Repository navigation
Commit 8bb43d5
fix(desktop): make the test loader work on Windows (#2758)
The resolve hook hands nextResolve absolute filesystem paths. Node's ESM
resolver requires URLs or relative specifiers: POSIX absolute paths
happen to be coerced, but a Windows path like C:\... parses as a URL
with protocol 'c:', so every desktop unit-test run on Windows dies
immediately with ERR_UNSUPPORTED_ESM_URL_SCHEME - on a clean tree,
before any test executes. CI never sees it (Linux runners).
Convert absolute paths to file:// URLs (pathToFileURL) at the three
nextResolve call sites. On POSIX the resulting URL is identical to what
node coerced before; on Windows the loader now works.
With this change the full desktop suite (318 files, 3487 tests) passes
on Windows 11 / node 24.14.1. Independently reported by another Windows
contributor in #2634's testing notes.
Claude-Session: https://claude.ai/code/session_01YFkHsUe1UUBBuvL81Zoe3n
---------
Signed-off-by: technicallybrantley <[email protected]>
Signed-off-by: Will Pfleger <[email protected]>
Co-authored-by: Claude Fable 5 <[email protected]>
Co-authored-by: Will Pfleger <[email protected]>1 parent 545bb46 commit 8bb43d5
1 file changed
Lines changed: 18 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
16 | 27 | | |
17 | 28 | | |
18 | 29 | | |
| |||
76 | 87 | | |
77 | 88 | | |
78 | 89 | | |
79 | | - | |
| 90 | + | |
80 | 91 | | |
81 | 92 | | |
82 | 93 | | |
| |||
86 | 97 | | |
87 | 98 | | |
88 | 99 | | |
89 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
90 | 104 | | |
91 | 105 | | |
92 | 106 | | |
| |||
103 | 117 | | |
104 | 118 | | |
105 | 119 | | |
106 | | - | |
| 120 | + | |
107 | 121 | | |
108 | 122 | | |
109 | 123 | | |
| |||
0 commit comments