Skip to content

Commit 82fd3ae

Browse files
committed
test(mobile): retain truthful presence UI coverage on corrected parent
Signed-off-by: Logan Johnson <[email protected]>
1 parent 2e3eae6 commit 82fd3ae

4 files changed

Lines changed: 212 additions & 1 deletion

File tree

‎mobile/test/features/channels/channel_detail_page_test.dart‎

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,17 @@ import '../profile/presence_snapshot_test.dart'
44
show PresenceTestRelay, presenceEvent;
55
import 'dart:collection';
66
import 'dart:convert';
7+
import 'dart:io';
8+
import 'dart:ui' as ui;
79

810
import 'package:flutter/foundation.dart';
911
import 'package:flutter/material.dart';
1012
import 'package:flutter/rendering.dart'
11-
show RenderParagraph, ScrollDirection, SemanticsAction;
13+
show
14+
RenderParagraph,
15+
RenderRepaintBoundary,
16+
ScrollDirection,
17+
SemanticsAction;
1218
import 'package:flutter/services.dart';
1319
import 'package:flutter_test/flutter_test.dart';
1420
import 'package:hooks_riverpod/hooks_riverpod.dart';
@@ -46,6 +52,7 @@ import 'package:buzz/shared/read_state/read_state_provider.dart';
4652
import 'package:buzz/features/channels/unread_badge/observed_unread_event.dart';
4753
import 'package:buzz/features/channels/small_avatar.dart';
4854
import 'package:buzz/features/profile/profile_provider.dart';
55+
import 'package:buzz/features/profile/presence_cache_provider.dart';
4956
import 'package:buzz/shared/profile/user_cache_provider.dart';
5057
import 'package:buzz/shared/profile/user_profile.dart';
5158
import 'package:buzz/features/profile/user_profile_sheet.dart';
@@ -67,6 +74,8 @@ import 'package:buzz/shared/widgets/masked_avatar_badge.dart';
6774
import 'package:buzz/shared/widgets/skeleton.dart';
6875
import 'package:shared_preferences/shared_preferences.dart';
6976

77+
part 'channel_detail_page_test/presence_tests.dart';
78+
7079
const _channelId = '11111111-2222-4333-8444-555555555555';
7180
const _huddleChannelId = '8d764100-fd8f-44cf-9c98-6d8fbd739b8c';
7281
const _otherChannelId = '22222222-3333-4444-8555-666666666666';
@@ -202,6 +211,7 @@ NostrEvent _edit({
202211

203212
Widget _buildTestable({
204213
required List<NostrEvent> messages,
214+
PresenceCacheNotifier? presenceCache,
205215
List<TypingEntry> typing = const [],
206216
Map<String, UserProfile> users = const {},
207217
Set<String>? knownAgentPubkeys,
@@ -272,6 +282,8 @@ Widget _buildTestable({
272282
() => userCacheNotifier ?? _FakeUserCacheNotifier(users),
273283
),
274284
profileProvider.overrideWith(() => _FakeProfileNotifier()),
285+
if (presenceCache != null)
286+
presenceCacheProvider.overrideWith(() => presenceCache),
275287
channelsProvider.overrideWith(() => fakeChannelsNotifier),
276288
channelStarsProvider.overrideWith(_FakeChannelStarsNotifier.new),
277289
channelMutesProvider.overrideWith(_FakeChannelMutesNotifier.new),
@@ -474,6 +486,7 @@ double? effectiveFontSizeForText(
474486
}
475487

476488
void main() {
489+
presenceTests();
477490
setUp(() async {
478491
SharedPreferences.setMockInitialValues({});
479492
_testPrefs = await SharedPreferences.getInstance();
Lines changed: 137 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,137 @@
1+
part of '../channel_detail_page_test.dart';
2+
3+
void presenceTests() {
4+
testWidgets('DM header never substitutes offline for unknown presence', (
5+
tester,
6+
) async {
7+
await _loadPresenceFonts(tester);
8+
final cache = _PresenceFixture();
9+
final channel = Channel(
10+
id: _channelId,
11+
name: 'DM',
12+
channelType: 'dm',
13+
description: 'Direct message',
14+
visibility: 'private',
15+
createdBy: 'self',
16+
createdAt: DateTime(2025),
17+
memberCount: 2,
18+
participants: const ['Self', 'Alice'],
19+
participantPubkeys: const ['self', 'alice'],
20+
isMember: true,
21+
);
22+
await tester.pumpWidget(
23+
_buildTestable(
24+
messages: const [],
25+
channel: channel,
26+
presenceCache: cache,
27+
users: const {
28+
'alice': UserProfile(
29+
pubkey: 'alice',
30+
displayName: 'Alice',
31+
ownerPubkey: 'self',
32+
),
33+
},
34+
),
35+
);
36+
await tester.pumpAndSettle();
37+
final avatar = find.byKey(const ValueKey('dm-header-avatar'));
38+
final bounds = tester.getRect(avatar);
39+
for (final entry in <String?, String>{
40+
null: 'Unknown',
41+
'online': 'Online',
42+
'away': 'Away',
43+
'offline': 'Offline',
44+
}.entries) {
45+
cache.setPresence(entry.key);
46+
await tester.pumpAndSettle();
47+
expect(
48+
tester
49+
.widget<Text>(find.byKey(const ValueKey('dm-header-presence')))
50+
.data,
51+
entry.value,
52+
);
53+
expect(
54+
tester.widget<MaskedAvatarBadge>(avatar).badge,
55+
entry.key == null ? isNull : isNotNull,
56+
);
57+
expect(tester.getRect(avatar), bounds);
58+
await _capturePresence(tester, 'dm-${entry.value}');
59+
}
60+
cache.setPresence(null);
61+
await tester.pumpAndSettle();
62+
expect(find.text('Offline'), findsNothing);
63+
expect(tester.takeException(), isNull);
64+
});
65+
66+
testWidgets('profile exposes one truthful presence label for every state', (
67+
tester,
68+
) async {
69+
await _loadPresenceFonts(tester);
70+
final cache = _PresenceFixture();
71+
final semantics = tester.ensureSemantics();
72+
73+
await tester.pumpWidget(
74+
_buildTestable(
75+
messages: const [],
76+
presenceCache: cache,
77+
users: const {
78+
'alice': UserProfile(
79+
pubkey: 'alice',
80+
displayName: 'Alice',
81+
ownerPubkey: 'self',
82+
),
83+
},
84+
home: const Scaffold(body: UserProfileSheet(pubkey: 'alice')),
85+
),
86+
);
87+
await tester.pumpAndSettle();
88+
for (final entry in <String?, String>{
89+
null: 'Unknown',
90+
'online': 'Online',
91+
'away': 'Away',
92+
'offline': 'Offline',
93+
}.entries) {
94+
cache.setPresence(entry.key);
95+
await tester.pumpAndSettle();
96+
expect(find.text(entry.value), findsOneWidget);
97+
expect(find.bySemanticsLabel('Presence: ${entry.value}'), findsOneWidget);
98+
if (entry.key != 'offline') expect(find.text('Offline'), findsNothing);
99+
await _capturePresence(tester, 'profile-${entry.value}');
100+
}
101+
expect(tester.takeException(), isNull);
102+
semantics.dispose();
103+
});
104+
}
105+
106+
class _PresenceFixture extends PresenceCacheNotifier {
107+
@override
108+
Map<String, String> build() => {};
109+
@override
110+
void track(List<String> pubkeys) {}
111+
void setPresence(String? status) => state = {'alice': ?status};
112+
}
113+
114+
// Opt-in rendered evidence; ordinary test runs perform no filesystem writes.
115+
Future<void> _loadPresenceFonts(WidgetTester tester) async {
116+
if (Platform.environment['PRESENCE_SCREENSHOTS'] == null) return;
117+
await tester.binding.setSurfaceSize(const Size(390, 844));
118+
addTearDown(() => tester.binding.setSurfaceSize(null));
119+
await (FontLoader(
120+
'Inter',
121+
)..addFont(rootBundle.load('assets/fonts/InterVariable.ttf'))).load();
122+
}
123+
124+
Future<void> _capturePresence(WidgetTester tester, String name) async {
125+
final directory = Platform.environment['PRESENCE_SCREENSHOTS'];
126+
if (directory == null) return;
127+
final boundary = tester.renderObject<RenderRepaintBoundary>(
128+
find.byType(RepaintBoundary).first,
129+
);
130+
await tester.runAsync(() async {
131+
final image = await boundary.toImage();
132+
final data = await image.toByteData(format: ui.ImageByteFormat.png);
133+
await Directory(directory).create(recursive: true);
134+
await File('$directory/$name.png').writeAsBytes(data!.buffer.asUint8List());
135+
image.dispose();
136+
});
137+
}

‎mobile/test/features/channels/channels_page_test.dart‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import 'package:buzz/shared/read_state/read_state_provider.dart';
2121
import 'package:buzz/features/channels/unread_badge/observed_unread_event.dart';
2222
import 'package:buzz/features/profile/profile_avatar.dart';
2323
import 'package:buzz/features/profile/profile_provider.dart';
24+
import 'package:buzz/features/profile/presence_cache_provider.dart';
2425
import 'package:buzz/shared/profile/user_profile.dart';
2526
import 'package:buzz/shared/utils/string_utils.dart';
2627
import 'package:buzz/shared/auth/auth.dart';
@@ -33,6 +34,8 @@ import 'package:buzz/shared/widgets/frosted_app_bar.dart';
3334
import 'package:buzz/shared/widgets/masked_avatar_badge.dart';
3435
import 'package:buzz/shared/widgets/skeleton.dart';
3536

37+
part 'channels_page_test/presence_tests.dart';
38+
3639
void main() {
3740
Widget buildTestable({
3841
required List<Override> overrides,
@@ -137,6 +140,11 @@ void main() {
137140
),
138141
];
139142

143+
presenceListTests(
144+
(overrides) => buildTestable(overrides: overrides),
145+
testChannels,
146+
);
147+
140148
testWidgets('DM tile presence observation failure hides the dot', (
141149
tester,
142150
) async {
Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
part of '../channels_page_test.dart';
2+
3+
void presenceListTests(
4+
Widget Function(List<Override>) harness,
5+
List<Channel> channels,
6+
) {
7+
testWidgets('DM list hides unconfirmed dots and paints confirmed presence', (
8+
tester,
9+
) async {
10+
final cache = _ListPresenceFixture();
11+
await tester.pumpWidget(
12+
harness([
13+
channelsProvider.overrideWith(() => _FakeNotifier(channels)),
14+
presenceCacheProvider.overrideWith(() => cache),
15+
]),
16+
);
17+
await tester.pumpAndSettle();
18+
final avatar = find.byWidgetPredicate(
19+
(widget) => widget is AvatarImage && widget.radius == 9,
20+
);
21+
final dots = find.byWidgetPredicate(
22+
(widget) =>
23+
widget is Positioned && widget.bottom == -1 && widget.right == -1,
24+
);
25+
expect(dots, findsNothing);
26+
final bounds = tester.getRect(avatar);
27+
for (final status in ['online', 'away', 'offline']) {
28+
cache.state = {'alice': status};
29+
await tester.pumpAndSettle();
30+
expect(dots, findsOneWidget);
31+
final dot = tester.widget<Container>(
32+
find.descendant(of: dots, matching: find.byType(Container)),
33+
);
34+
final theme = AppTheme.light();
35+
expect((dot.decoration as BoxDecoration).color, switch (status) {
36+
'online' => theme.extension<AppColors>()!.success,
37+
'away' => theme.extension<AppColors>()!.warning,
38+
_ => theme.colorScheme.outline,
39+
});
40+
expect(tester.getRect(avatar), bounds);
41+
}
42+
cache.state = {};
43+
await tester.pumpAndSettle();
44+
expect(dots, findsNothing);
45+
});
46+
}
47+
48+
class _ListPresenceFixture extends PresenceCacheNotifier {
49+
@override
50+
Map<String, String> build() => {};
51+
@override
52+
void track(List<String> pubkeys) {}
53+
}

0 commit comments

Comments
 (0)