Skip to content

Commit 73cc31c

Browse files
tlongwell-blocknpub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67dMaxMariQuinn
authored
chore: remove LLM-slop comments across the codebase (#1277)
Signed-off-by: Tyler Longwell <[email protected]> Co-authored-by: npub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67d <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@sprout-oss.stage.blox.sqprod.co> Co-authored-by: Max <d8473ee32b973aa31a21a65adddcc4b69cc2a8a4dee8121ecd51926e0cddbc02@sprout-oss.stage.blox.sqprod.co> Co-authored-by: Mari <95cae996907d7cab9f5dbf43c0f53edeac6ab0b032a6feae4abfd784e467b3f5@sprout-oss.stage.blox.sqprod.co> Co-authored-by: Quinn <96f056ad5f2305c8ddf637dc65d048aa4c12d7daeb8867690e34fca46b0ef64c@sprout-oss.stage.blox.sqprod.co> Co-authored-by: Sami <f4a42a97e594b77bdbd8ee35191c8b28a94a4cb871d96f32921558275421fb68@sprout-oss.stage.blox.sqprod.co> Co-authored-by: Perci <5a968df9a7494b4e019b9ecf739e088ba61097b4312124e9a88ae5b42e3f5f3e@sprout-oss.stage.blox.sqprod.co> Co-authored-by: Tyler Longwell <[email protected]>
1 parent 996a3f8 commit 73cc31c

212 files changed

Lines changed: 0 additions & 2902 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎crates/buzz-acp/src/acp.rs‎

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ use crate::observer::{ObserverContext, ObserverHandle};
1919
/// Lines exceeding this limit are rejected to prevent OOM from rogue agents.
2020
const MAX_LINE_SIZE: usize = 10_000_000; // 10 MB
2121

22-
// ─── Public types ────────────────────────────────────────────────────────────
23-
2422
/// An MCP server configuration passed to `session/new`.
2523
///
2624
/// Corresponds to the `McpServerStdio` variant in the ACP schema.
@@ -106,8 +104,6 @@ pub enum AcpError {
106104
AgentError(String),
107105
}
108106

109-
// ─── AcpClient ───────────────────────────────────────────────────────────────
110-
111107
/// ACP client that owns an agent subprocess and communicates over its stdio.
112108
///
113109
/// One `AcpClient` per agent process. Multiple sessions can be created on the
@@ -151,8 +147,6 @@ pub struct AcpClient {
151147
}
152148

153149
impl AcpClient {
154-
// ── Lifecycle ─────────────────────────────────────────────────────────
155-
156150
/// Kill the agent subprocess and wait for it to exit (no zombies).
157151
///
158152
/// `Drop` only calls `start_kill()` (sends SIGKILL but doesn't reap).
@@ -568,8 +562,6 @@ impl AcpClient {
568562
self.parse_stop_reason(&result)
569563
}
570564

571-
// ── Internal helpers ──────────────────────────────────────────────────
572-
573565
/// Serialize `value` as a single NDJSON line and flush to the agent's stdin.
574566
///
575567
/// Bounded by a 30-second write timeout. If the agent stops reading stdin
@@ -1090,8 +1082,6 @@ impl AcpClient {
10901082
}
10911083
}
10921084

1093-
// ─── Permission response constructors ────────────────────────────────────────
1094-
10951085
/// Build `session/prompt` params from one or more text content blocks.
10961086
fn build_prompt_params(session_id: &str, prompt_blocks: &[&str]) -> serde_json::Value {
10971087
let blocks: Vec<serde_json::Value> = prompt_blocks
@@ -1122,8 +1112,6 @@ fn permission_response_cancelled(id: &serde_json::Value) -> serde_json::Value {
11221112
})
11231113
}
11241114

1125-
// ─── Session response types ───────────────────────────────────────────────────
1126-
11271115
/// Full `session/new` response — session ID plus the raw JSON result.
11281116
///
11291117
/// Callers use the extractor helpers to pull model info from `raw`.
@@ -1215,8 +1203,6 @@ pub fn resolve_model_switch_method(
12151203
None
12161204
}
12171205

1218-
// ─── Drop: kill child process ─────────────────────────────────────────────────
1219-
12201206
impl Drop for AcpClient {
12211207
fn drop(&mut self) {
12221208
// Best-effort SIGKILL + reap. We cannot `await` in Drop (sync context).
@@ -1258,14 +1244,10 @@ fn kill_process_group(_pid: u32) -> bool {
12581244
false
12591245
}
12601246

1261-
// ─── Tests ───────────────────────────────────────────────────────────────────
1262-
12631247
#[cfg(test)]
12641248
mod tests {
12651249
use super::*;
12661250

1267-
// ── StopReason parsing ────────────────────────────────────────────────
1268-
12691251
#[test]
12701252
fn stop_reason_parses_all_known_values() {
12711253
assert_eq!(StopReason::from_str("end_turn"), Some(StopReason::EndTurn));
@@ -1310,8 +1292,6 @@ mod tests {
13101292
assert_eq!(StopReason::from_str("Refusal"), Some(StopReason::Refusal));
13111293
}
13121294

1313-
// ── Permission option finding ─────────────────────────────────────────
1314-
13151295
#[test]
13161296
fn find_allow_once_by_kind_not_by_option_id() {
13171297
// optionId values are intentionally non-obvious to prove we don't hardcode them.
@@ -1371,8 +1351,6 @@ mod tests {
13711351
assert_eq!(reject_once.unwrap()["optionId"].as_str(), Some("rej-x"));
13721352
}
13731353

1374-
// ── JSON-RPC message construction ─────────────────────────────────────
1375-
13761354
#[test]
13771355
fn request_has_id_field() {
13781356
let id: u64 = 42;
@@ -1563,8 +1541,6 @@ mod tests {
15631541
assert_eq!(msg["params"]["sessionId"].as_str(), Some("sess_xyz789"));
15641542
}
15651543

1566-
// ── String ID handling (Fix 1) ────────────────────────────────────────
1567-
15681544
#[test]
15691545
fn permission_request_with_string_id() {
15701546
// Verify that permission response uses the same ID type as the request.
@@ -1617,8 +1593,6 @@ mod tests {
16171593
assert!(cancelled_numeric["id"].is_number());
16181594
}
16191595

1620-
// ── Model extractor tests ─────────────────────────────────────────────
1621-
16221596
#[test]
16231597
fn extract_model_config_options_finds_model_category() {
16241598
let result = serde_json::json!({
@@ -1685,8 +1659,6 @@ mod tests {
16851659
assert!(super::extract_model_state(&result).is_none());
16861660
}
16871661

1688-
// ── resolve_model_switch_method tests ─────────────────────────────────
1689-
16901662
#[test]
16911663
fn resolve_prefers_stable_over_unstable() {
16921664
let result = serde_json::json!({
@@ -1783,8 +1755,6 @@ mod tests {
17831755
);
17841756
}
17851757

1786-
// ── Error variant display ─────────────────────────────────────────────
1787-
17881758
#[test]
17891759
fn idle_timeout_error_includes_duration() {
17901760
let err = AcpError::IdleTimeout(std::time::Duration::from_secs(320));
@@ -1805,8 +1775,6 @@ mod tests {
18051775
);
18061776
}
18071777

1808-
// ── Async integration tests with real subprocess ──────────────────────
1809-
18101778
async fn spawn_script(script: &str) -> AcpClient {
18111779
AcpClient::spawn("bash", &["-c".into(), script.into()], &[])
18121780
.await
@@ -1977,8 +1945,6 @@ mod tests {
19771945
assert_eq!(result.unwrap()["worked"], serde_json::json!(true));
19781946
}
19791947

1980-
// ── Keepalive / tool-call idle reset tests (PR #935 fix) ─────────────
1981-
19821948
#[tokio::test]
19831949
async fn keepalive_resets_idle_past_deadline() {
19841950
// Keepalive session/update lines every 50ms against a 100ms idle deadline.
@@ -2044,8 +2010,6 @@ mod tests {
20442010
);
20452011
}
20462012

2047-
// ── session_new_full systemPrompt serialization ──────────────────────
2048-
20492013
#[tokio::test]
20502014
async fn session_new_full_includes_system_prompt_when_some() {
20512015
// Script: respond to initialize, then echo back the session/new request.

0 commit comments

Comments
 (0)