Skip to content

Commit 620320b

Browse files
browclaude
andcommitted
fix(mobile): retry the agent ownership lookup
Retry and pull-to-refresh now rerun a failed lookup even when the registry is unchanged. The create journey runs in the normal test lane. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Tom Brow <[email protected]>
1 parent b050de7 commit 620320b

4 files changed

Lines changed: 54 additions & 9 deletions

File tree

‎mobile/lib/features/agents/agents_sheet.dart‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,10 +150,12 @@ class AgentsSheet extends HookConsumerWidget {
150150
// Key on the agents' identities, not the list instance: each refresh
151151
// replaces the list, and refetching would blank the shown agents.
152152
final registeredKey = (registeredKeys.toList()..sort()).join(',');
153+
// Bumped by Retry and pull-to-refresh so a failed lookup runs again.
154+
final attempt = useState(0);
153155
final registryFuture = useMemoized(() async {
154156
final fetch = ref.read(relaySessionProvider.notifier).fetchHistory;
155157
return ownedCommunityAgents(registeredKeys, controller.owner, fetch);
156-
}, [community?.relayUrl, registeredKey, controller.owner]);
158+
}, [community?.relayUrl, registeredKey, controller.owner, attempt.value]);
157159
final registered = useFuture(registryFuture, preserveState: false);
158160
final keys = {
159161
...?registered.data,
@@ -202,7 +204,9 @@ class AgentsSheet extends HookConsumerWidget {
202204

203205
Future<void> refresh() async {
204206
await controller.run(controller.refresh);
205-
if (context.mounted) ref.invalidate(agentDirectoryProvider);
207+
if (!context.mounted) return;
208+
attempt.value++;
209+
ref.invalidate(agentDirectoryProvider);
206210
}
207211

208212
return SizedBox(

‎mobile/test/features/agents/agents_harness.dart‎

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,30 @@ import '../../helpers/remote_agents_fixture.dart';
2020

2121
/// Fakes the relay boundary: owner-attested profiles for registry agents.
2222
class _Relay extends RelaySessionNotifier {
23+
_Relay(this.harness);
24+
final AgentsHarness harness;
25+
2326
@override
2427
SessionState build() => const SessionState(status: SessionStatus.connected);
2528

2629
@override
2730
Future<List<NostrEvent>> fetchHistory(
2831
NostrFilter filter, {
2932
Duration timeout = const Duration(seconds: 8),
30-
}) async => [
31-
if (filter.authors?.contains(fakeAgent) ?? false)
32-
signedAgentProfile(fakeAgentKeys, fakeOwner, content: '{"name":"Scout"}'),
33-
];
33+
}) async {
34+
final agent = filter.authors?.contains(fakeAgent) ?? false;
35+
if (agent && harness.relayDown) {
36+
throw TimeoutException('relay unavailable');
37+
}
38+
return [
39+
if (agent)
40+
signedAgentProfile(
41+
fakeAgentKeys,
42+
fakeOwner,
43+
content: '{"name":"Scout"}',
44+
),
45+
];
46+
}
3447
}
3548

3649
/// Holds creation open so a test can observe the in-flight state.
@@ -78,6 +91,9 @@ class AgentsHarness {
7891
final GatedController controller;
7992
final Community community;
8093

94+
/// Fails agent profile fetches until the relay recovers.
95+
bool relayDown = false;
96+
8197
static Future<AgentsHarness> create() async {
8298
FlutterSecureStorage.setMockInitialValues({});
8399
SharedPreferences.setMockInitialValues({});
@@ -113,7 +129,7 @@ class AgentsHarness {
113129
overrides: [
114130
builderlabAccountProvider.overrideWithValue(registry),
115131
remoteAgentControllerProvider.overrideWithValue(controller),
116-
relaySessionProvider.overrideWith(_Relay.new),
132+
relaySessionProvider.overrideWith(() => _Relay(this)),
117133
activeCommunityProvider.overrideWith((ref) async => community),
118134
agentDirectoryProvider.overrideWith(
119135
(ref) async => [
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
import 'package:flutter/material.dart';
2+
import 'package:flutter_test/flutter_test.dart';
3+
4+
import '../../helpers/remote_agents_fixture.dart';
5+
import 'agents_harness.dart';
6+
7+
void main() {
8+
testWidgets('Retry repeats a failed ownership lookup', (tester) async {
9+
final h = await AgentsHarness.create();
10+
h.registry.listed.add({
11+
'agent_pubkey': fakeAgent,
12+
'agent_id': 'agent',
13+
'agent_name': 'Scout',
14+
'status': 'BEEKEEPER_AGENT_STATUS_ACTIVE',
15+
});
16+
h.relayDown = true;
17+
await h.open(tester, directory: []);
18+
expect(find.text('Could not load agents'), findsOneWidget);
19+
expect(find.byKey(ValueKey(fakeAgent)), findsNothing);
20+
21+
h.relayDown = false;
22+
await tester.tap(find.text('Retry'));
23+
await tester.pumpAndSettle();
24+
expect(find.text('Could not load agents'), findsNothing);
25+
expect(find.byKey(ValueKey(fakeAgent)), findsOneWidget);
26+
});
27+
}

‎mobile/test/features/agents/create_agent_sheet_test.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import 'package:buzz/shared/hosted/hosted_environment.dart';
21
import 'dart:async';
32

43
import 'package:buzz/features/agents/agents_sheet.dart';
@@ -106,6 +105,5 @@ void main() {
106105
expect(find.byKey(ValueKey(added)), findsOneWidget);
107106
expect(h.registry.calls, contains('publish-policy'));
108107
},
109-
skip: !HostedEnvironment.enabled,
110108
);
111109
}

0 commit comments

Comments
 (0)