Skip to content

Commit 518af3a

Browse files
square-tombclaude
andcommitted
perf(mobile): stop downloading whole videos for posterless stills
Delete eager poster generation for videos without NIP-71 poster metadata. Each rendered bubble or stack card downloaded the whole video (up to 100 MB) to grab a frame, and desktop never writes posters, so this covered every desktop-sent video. Posterless videos go back to the static placeholder. Also route .3gpp and .3g2 picker results as videos now that the explicit Video attachment action is gone. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Tom Brow <[email protected]>
1 parent ef57fec commit 518af3a

11 files changed

Lines changed: 22 additions & 273 deletions

File tree

‎mobile/lib/features/channels/compose_bar/attachments.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ bool _queueComposerAttachment(
4545
}
4646

4747
final _pickedVideoExtension = RegExp(
48-
r'\.(mp4|mov|m4v|webm|3gp|avi|mkv)$',
48+
r'\.(mp4|mov|m4v|webm|3gp|3gpp|3g2|avi|mkv)$',
4949
caseSensitive: false,
5050
);
5151

‎mobile/lib/features/channels/message_content.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ import 'local_send_bubble_surface.dart';
4242
import 'media_viewer_page.dart';
4343
import 'native_photo_zoom_preview.dart';
4444
import 'native_video_files.dart';
45-
import 'video_poster.dart';
4645
import 'message_content/link_normalizer.dart';
4746
import 'message_content/markdown_escapes.dart';
4847
import 'message_content/preview_text.dart';

‎mobile/lib/features/channels/message_content/media_stack.dart‎

Lines changed: 5 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -42,21 +42,6 @@ class _MessageImageStack extends HookConsumerWidget {
4242
final reducedMotion = MediaQuery.disableAnimationsOf(context);
4343
final auth = ref.watch(mediaGetAuthServiceProvider);
4444
final index = value.round() % items.length;
45-
// Match the rendered cards, including the next card during a swipe. Do not
46-
// download every posterless video in a large attachment group.
47-
final posterIndices = {
48-
for (var slot = 0; slot <= 3; slot++)
49-
(value.floor() + slot) % items.length,
50-
};
51-
final generatedPosters = [
52-
for (var i = 0; i < items.length; i++)
53-
if (posterIndices.contains(i) &&
54-
items[i].isVideo &&
55-
items[i].posterUrl == null)
56-
ref.watch(videoPosterProvider(items[i].url)).asData?.value
57-
else
58-
null,
59-
];
6045
final hasVideos = items.any((item) => item.isVideo);
6146
final itemName = hasVideos ? 'Attachment' : 'Photo';
6247

@@ -91,17 +76,15 @@ class _MessageImageStack extends HookConsumerWidget {
9176
(cardWidth * MediaQuery.devicePixelRatioOf(context))
9277
.ceilToDouble();
9378
final providers = [
94-
for (var i = 0; i < items.length; i++)
95-
if (items[i].isVideo && items[i].posterUrl == null)
96-
generatedPosters[i] == null
97-
? null
98-
: MemoryImage(generatedPosters[i]!)
79+
for (final item in items)
80+
if (item.isVideo && item.posterUrl == null)
81+
null
9982
else
10083
ResizeImage.resizeIfNeeded(
10184
physicalDecodeWidth.toInt(),
10285
null,
10386
MediaImageProvider(
104-
url: items[i].isVideo ? items[i].posterUrl! : items[i].url,
87+
url: item.isVideo ? item.posterUrl! : item.url,
10588
auth: auth,
10689
client: ref.watch(mediaHttpClientProvider),
10790
),
@@ -268,16 +251,7 @@ class _MessageImageStack extends HookConsumerWidget {
268251
Widget card(int i) {
269252
final item = items[i];
270253
Widget photo = item.isVideo && item.posterUrl == null
271-
? generatedPosters[i] == null
272-
? const _MediaPreviewFallback(
273-
icon: BuzzIcons.video,
274-
label: 'Video preview unavailable',
275-
)
276-
: Image.memory(
277-
generatedPosters[i]!,
278-
fit: BoxFit.cover,
279-
excludeFromSemantics: true,
280-
)
254+
? ColoredBox(color: context.colors.surfaceContainerHigh)
281255
: MediaImage(
282256
url: item.isVideo ? item.posterUrl! : item.url,
283257
decodeWidth: decodeWidth,

‎mobile/lib/features/channels/message_content/video_preview.dart‎

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
part of '../message_content.dart';
22

33
/// A video bubble. It shows the NIP-71 poster when the event has one;
4-
/// older attachments generate a still without creating a playback controller.
4+
/// otherwise a static placeholder, so scrolling never starts a video decoder.
55
class _MessageVideoPreview extends HookConsumerWidget {
66
final String url;
77
final ImetaEntry? imeta;
@@ -19,9 +19,6 @@ class _MessageVideoPreview extends HookConsumerWidget {
1919
final opening = useRef(false);
2020
final aspectRatio = messageVideoAspectRatio(imeta?.aspectRatio);
2121
final posterUrl = imeta?.posterUrl;
22-
final generatedPoster = posterUrl == null
23-
? ref.watch(videoPosterProvider(url)).asData?.value
24-
: null;
2522

2623
return Padding(
2724
padding: const EdgeInsets.only(top: Grid.half),
@@ -41,9 +38,7 @@ class _MessageVideoPreview extends HookConsumerWidget {
4138
context: context,
4239
sourceKeys: [sourceKey],
4340
previewProviders: [
44-
if (generatedPoster != null)
45-
MemoryImage(generatedPoster)
46-
else if (posterUrl != null)
41+
if (posterUrl != null)
4742
MediaImageProvider(
4843
url: posterUrl,
4944
auth: auth,
@@ -53,14 +48,11 @@ class _MessageVideoPreview extends HookConsumerWidget {
5348
null,
5449
],
5550
providers: [
56-
if (generatedPoster != null)
57-
MemoryImage(generatedPoster)
58-
else
59-
MediaImageProvider(
60-
url: posterUrl ?? url,
61-
auth: auth,
62-
client: client,
63-
),
51+
MediaImageProvider(
52+
url: posterUrl ?? url,
53+
auth: auth,
54+
client: client,
55+
),
6456
],
6557
urls: [url],
6658
labels: [imeta?.alt ?? 'Video'],
@@ -108,12 +100,6 @@ class _MessageVideoPreview extends HookConsumerWidget {
108100
label: 'Video preview unavailable',
109101
),
110102
)
111-
else if (generatedPoster != null)
112-
Image.memory(
113-
generatedPoster,
114-
fit: BoxFit.cover,
115-
excludeFromSemantics: true,
116-
)
117103
else
118104
const _MediaPreviewFallback(
119105
icon: BuzzIcons.video,

‎mobile/lib/features/channels/message_gallery.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class MessageGalleryItem {
1717
/// Whether this item opens video playback rather than an image decoder.
1818
final bool isVideo;
1919

20-
/// Optional video poster; absent posters are generated lazily by the stack.
20+
/// Optional video poster; absent posters use a static video placeholder.
2121
final String? posterUrl;
2222

2323
const MessageGalleryItem({

‎mobile/lib/features/channels/native_video_files.dart‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ class _VideoFileDownload {
8383
Directory? directory;
8484
bool disposed = false;
8585
bool finished = false;
86-
void Function()? _cancelTimeouts;
8786

8887
Future<String?> _fetch() async {
8988
Timer? stall;
@@ -97,10 +96,6 @@ class _VideoFileDownload {
9796
}
9897

9998
final deadline = Timer(owner.maxDuration, abort);
100-
_cancelTimeouts = () {
101-
stall?.cancel();
102-
deadline.cancel();
103-
};
10499
StreamIterator<List<int>>? body;
105100
RandomAccessFile? output;
106101
var success = false;
@@ -173,7 +168,6 @@ class _VideoFileDownload {
173168

174169
Future<void> dispose() async {
175170
disposed = true;
176-
_cancelTimeouts?.call();
177171
if (!stop.isCompleted) stop.complete();
178172
await result;
179173
await _delete();

‎mobile/lib/features/channels/video_poster.dart‎

Lines changed: 0 additions & 60 deletions
This file was deleted.

‎mobile/test/features/channels/compose_bar_test/mixed_gallery_tests.dart‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,13 @@ class _MixedGalleryService extends _FakeVideoUploadService {
4242
}
4343

4444
void _mixedGalleryTests() {
45-
for (final filename in ['camera.MOV', 'clip.mp4', 'clip.m4v']) {
45+
for (final filename in [
46+
'camera.MOV',
47+
'clip.mp4',
48+
'clip.m4v',
49+
'clip.3gpp',
50+
'clip.3g2',
51+
]) {
4652
testWidgets('Photos queues $filename as a video alongside photos', (
4753
tester,
4854
) async {

‎mobile/test/features/channels/message_content_test.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'package:buzz/shared/widgets/buzz_agent_icon.dart';
2-
import 'package:buzz/features/channels/video_poster.dart';
32
import 'package:buzz/features/channels/local_send_bubble_surface.dart';
43
import 'dart:async';
54
import 'dart:convert';

‎mobile/test/features/channels/message_stack_cases.dart‎

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,6 @@
11
part of 'message_content_test.dart';
22

33
void stackJourneyTests() {
4-
testWidgets('large video stacks only fetch posters for rendered cards', (
5-
tester,
6-
) async {
7-
final requested = <String>[];
8-
await tester.pumpWidget(
9-
_testable(
10-
MessageContent(
11-
bubble: true,
12-
content: List.generate(
13-
20,
14-
(i) => '![Video $i](https://example.com/clip-$i.mp4)',
15-
).join('\n'),
16-
),
17-
disableAnimations: true,
18-
overrides: [
19-
videoPosterProvider.overrideWith((ref, url) async {
20-
requested.add(url);
21-
return null;
22-
}),
23-
],
24-
),
25-
);
26-
await tester.pumpAndSettle();
27-
expect(requested.toSet(), {
28-
for (var i = 0; i < 4; i++) 'https://example.com/clip-$i.mp4',
29-
});
30-
});
31-
324
testWidgets('mixed stacks keep video order and return from the fallback player', (
335
tester,
346
) async {
@@ -67,8 +39,7 @@ void stackJourneyTests() {
6739
await tester.pumpAndSettle();
6840
expect(requested, contains(photo));
6941
expect(requested, contains(poster));
70-
// Only the legacy video without poster metadata needs a background fetch.
71-
expect(requested, contains(clip));
42+
expect(requested, isNot(contains(clip)));
7243
expect(requested, isNot(contains('https://example.com/second.mov')));
7344
final stack = find.byKey(const ValueKey('message-media-stack'));
7445
final spoken = find.byKey(const ValueKey('message-media-stack-semantics'));

0 commit comments

Comments
 (0)