Repository navigation
Commit 49fb420
test(db): drop scratch databases and roles even when a test fails
buzz-db tests that create their own databases or roles dropped them at
the end of the test body, so a failed assertion or timeout skipped the
cleanup and left the object on the shared server. Seven files carried
their own copy of create_scratch_db_through and its drop helper.
Add ScratchDb and ScratchRole guards to test_support. Their Drop runs
DROP DATABASE IF EXISTS ... WITH (FORCE) or DROP ROLE IF EXISTS on a
fresh admin connection, on a separate thread with its own runtime, the
same approach ScratchSchema takes, so it works under both runtime
flavours and while a panicking test unwinds. WITH (FORCE) ends any
sessions still open on the database, so pools need not be closed first.
Drop failures print a warning rather than panicking, because a panic
during unwinding would abort the test binary.
Replace the per-file helpers and every end-of-test DROP DATABASE in
buzz-db with the guard, and use ScratchRole for the replica-fence
masked-activity test's least-privilege role. Test behaviour is otherwise
unchanged; admin pools and close() calls that only served cleanup are
removed. TESTING.md now points new tests at the guards.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Matt Toohey <[email protected]>1 parent cc04cdc commit 49fb420
18 files changed
Lines changed: 381 additions & 939 deletions
File tree
- crates/buzz-db
- src
- runtime
- tests
- store
- partition
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
24 | 30 | | |
25 | 31 | | |
26 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
| 198 | + | |
198 | 199 | | |
199 | 200 | | |
200 | 201 | | |
| |||
2567 | 2568 | | |
2568 | 2569 | | |
2569 | 2570 | | |
2570 | | - | |
2571 | | - | |
2572 | 2571 | | |
2573 | 2572 | | |
2574 | 2573 | | |
2575 | 2574 | | |
2576 | 2575 | | |
2577 | | - | |
2578 | | - | |
2579 | | - | |
2580 | | - | |
2581 | | - | |
2582 | | - | |
2583 | | - | |
2584 | | - | |
2585 | | - | |
2586 | | - | |
| 2576 | + | |
| 2577 | + | |
2587 | 2578 | | |
2588 | 2579 | | |
2589 | 2580 | | |
| |||
2716 | 2707 | | |
2717 | 2708 | | |
2718 | 2709 | | |
2719 | | - | |
2720 | | - | |
2721 | | - | |
2722 | | - | |
2723 | | - | |
2724 | | - | |
2725 | | - | |
2726 | | - | |
2727 | 2710 | | |
2728 | 2711 | | |
2729 | 2712 | | |
| |||
2787 | 2770 | | |
2788 | 2771 | | |
2789 | 2772 | | |
2790 | | - | |
2791 | | - | |
2792 | 2773 | | |
2793 | 2774 | | |
2794 | 2775 | | |
| |||
2869 | 2850 | | |
2870 | 2851 | | |
2871 | 2852 | | |
2872 | | - | |
2873 | | - | |
2874 | | - | |
2875 | | - | |
2876 | 2853 | | |
2877 | | - | |
2878 | | - | |
2879 | | - | |
2880 | | - | |
2881 | | - | |
2882 | | - | |
2883 | | - | |
2884 | | - | |
2885 | | - | |
2886 | | - | |
| 2854 | + | |
| 2855 | + | |
2887 | 2856 | | |
2888 | 2857 | | |
2889 | 2858 | | |
2890 | | - | |
| 2859 | + | |
2891 | 2860 | | |
2892 | 2861 | | |
2893 | 2862 | | |
2894 | 2863 | | |
2895 | 2864 | | |
2896 | 2865 | | |
2897 | 2866 | | |
2898 | | - | |
| 2867 | + | |
2899 | 2868 | | |
2900 | 2869 | | |
2901 | 2870 | | |
| |||
2904 | 2873 | | |
2905 | 2874 | | |
2906 | 2875 | | |
2907 | | - | |
| 2876 | + | |
2908 | 2877 | | |
2909 | 2878 | | |
2910 | 2879 | | |
| |||
2965 | 2934 | | |
2966 | 2935 | | |
2967 | 2936 | | |
2968 | | - | |
2969 | | - | |
2970 | | - | |
2971 | | - | |
2972 | | - | |
2973 | | - | |
2974 | | - | |
2975 | | - | |
2976 | | - | |
2977 | | - | |
2978 | | - | |
2979 | 2937 | | |
2980 | 2938 | | |
2981 | 2939 | | |
| |||
2997 | 2955 | | |
2998 | 2956 | | |
2999 | 2957 | | |
3000 | | - | |
3001 | 2958 | | |
3002 | 2959 | | |
3003 | 2960 | | |
3004 | | - | |
3005 | | - | |
3006 | | - | |
3007 | | - | |
3008 | | - | |
3009 | | - | |
3010 | | - | |
3011 | | - | |
3012 | | - | |
| 2961 | + | |
3013 | 2962 | | |
3014 | | - | |
| 2963 | + | |
3015 | 2964 | | |
3016 | 2965 | | |
3017 | 2966 | | |
3018 | 2967 | | |
3019 | 2968 | | |
3020 | | - | |
| 2969 | + | |
3021 | 2970 | | |
3022 | 2971 | | |
3023 | 2972 | | |
| |||
3102 | 3051 | | |
3103 | 3052 | | |
3104 | 3053 | | |
3105 | | - | |
| 3054 | + | |
3106 | 3055 | | |
3107 | 3056 | | |
3108 | 3057 | | |
| |||
3117 | 3066 | | |
3118 | 3067 | | |
3119 | 3068 | | |
3120 | | - | |
3121 | | - | |
3122 | | - | |
3123 | | - | |
3124 | | - | |
3125 | | - | |
3126 | | - | |
3127 | | - | |
3128 | 3069 | | |
3129 | 3070 | | |
3130 | 3071 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
823 | 823 | | |
824 | 824 | | |
825 | 825 | | |
| 826 | + | |
826 | 827 | | |
827 | 828 | | |
828 | 829 | | |
829 | | - | |
830 | | - | |
831 | | - | |
832 | | - | |
833 | | - | |
834 | | - | |
835 | | - | |
836 | | - | |
837 | | - | |
838 | | - | |
839 | | - | |
840 | | - | |
841 | | - | |
842 | | - | |
843 | | - | |
844 | | - | |
845 | | - | |
846 | | - | |
847 | | - | |
848 | | - | |
849 | | - | |
850 | | - | |
851 | | - | |
852 | | - | |
853 | | - | |
854 | | - | |
855 | | - | |
856 | | - | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
857 | 834 | | |
858 | 835 | | |
859 | 836 | | |
| |||
1051 | 1028 | | |
1052 | 1029 | | |
1053 | 1030 | | |
1054 | | - | |
| 1031 | + | |
1055 | 1032 | | |
1056 | 1033 | | |
1057 | 1034 | | |
| |||
1090 | 1067 | | |
1091 | 1068 | | |
1092 | 1069 | | |
1093 | | - | |
1094 | | - | |
1095 | 1070 | | |
1096 | 1071 | | |
1097 | 1072 | | |
| |||
1101 | 1076 | | |
1102 | 1077 | | |
1103 | 1078 | | |
1104 | | - | |
1105 | | - | |
1106 | | - | |
1107 | | - | |
1108 | 1079 | | |
1109 | 1080 | | |
1110 | 1081 | | |
| |||
1118 | 1089 | | |
1119 | 1090 | | |
1120 | 1091 | | |
1121 | | - | |
1122 | | - | |
1123 | | - | |
1124 | | - | |
1125 | | - | |
1126 | | - | |
1127 | | - | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
1128 | 1098 | | |
1129 | 1099 | | |
1130 | 1100 | | |
1131 | 1101 | | |
1132 | 1102 | | |
1133 | | - | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
1134 | 1108 | | |
1135 | 1109 | | |
1136 | 1110 | | |
| |||
1144 | 1118 | | |
1145 | 1119 | | |
1146 | 1120 | | |
1147 | | - | |
1148 | | - | |
1149 | | - | |
1150 | | - | |
1151 | 1121 | | |
1152 | 1122 | | |
1153 | 1123 | | |
| |||
1191 | 1161 | | |
1192 | 1162 | | |
1193 | 1163 | | |
1194 | | - | |
| 1164 | + | |
1195 | 1165 | | |
1196 | 1166 | | |
1197 | 1167 | | |
| |||
1236 | 1206 | | |
1237 | 1207 | | |
1238 | 1208 | | |
1239 | | - | |
1240 | 1209 | | |
1241 | 1210 | | |
1242 | 1211 | | |
| |||
1246 | 1215 | | |
1247 | 1216 | | |
1248 | 1217 | | |
1249 | | - | |
| 1218 | + | |
1250 | 1219 | | |
1251 | 1220 | | |
1252 | 1221 | | |
| |||
1286 | 1255 | | |
1287 | 1256 | | |
1288 | 1257 | | |
1289 | | - | |
1290 | 1258 | | |
1291 | 1259 | | |
0 commit comments