You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3cc3dae
Browse filesBrowse the repository at this point in the historyBrowse files
fix(desktop): clear a persisted failure only on a successful turn_completed
Review follow-up for #1659: TurnCompletionGuard emits `turn_completed` on every
exit path (success, error, timeout, cancel, panic), so the desktop store cleared
a persisted failure badge on a *cancelled* turn too — erasing a prior genuine
failure that a cancel proves nothing about.
- buzz-acp: tag the `turn_completed` payload with a coarse `outcome`, set to
"ok" only on the `PromptOutcome::Ok` send paths (via a shared success flag on
the completion guard) and "incomplete" on every other exit.
- desktop store: clear the failure only when `outcome` is "ok" or absent
(absent = a harness build predating the field, so mixed-version behavior is
unchanged). A cancelled/failed completion no longer clears the badge.
- add a regression test: failure -> cancelled turn_completed -> failure remains;
an "ok" completion still clears it.
- classify_turn_failure: document the unreachable `Ok(_)` defensive default.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Signed-off-by: Orlando Lopez <[email protected]>
0 commit comments