Repository navigation
Commit 3c05927
test(acp): prove a control notice lands in the command's thread
Review asked to confirm that the notice inherits the thread tags of the
command, so a `!rotate` typed in a thread is not answered with an unrelated
root-level message. It does — `spawn_control_notice` and the awaited
`!shutdown` path both derive their `ThreadTags` from the triggering event —
but nothing guarded it.
Extract the `ThreadTags` to `ThreadRef` mapping out of `post_notice` into
`thread_ref_from_tags` so the test exercises the real path rather than a
copy of it, and assert both directions: a threaded command keeps its root
and parent, a channel-level command stays unthreaded.
Verified the test fails when `thread_ref_from_tags` is made to return `None`.
Refs #3711
Co-Authored-By: Claude Opus 5 <[email protected]>
Signed-off-by: Bérenger Ouadi <[email protected]>1 parent cc911a9 commit 3c05927
2 files changed
Lines changed: 50 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4375 | 4375 | | |
4376 | 4376 | | |
4377 | 4377 | | |
| 4378 | + | |
| 4379 | + | |
| 4380 | + | |
| 4381 | + | |
| 4382 | + | |
| 4383 | + | |
| 4384 | + | |
| 4385 | + | |
| 4386 | + | |
| 4387 | + | |
| 4388 | + | |
| 4389 | + | |
| 4390 | + | |
| 4391 | + | |
| 4392 | + | |
| 4393 | + | |
| 4394 | + | |
| 4395 | + | |
| 4396 | + | |
| 4397 | + | |
| 4398 | + | |
| 4399 | + | |
| 4400 | + | |
| 4401 | + | |
| 4402 | + | |
| 4403 | + | |
| 4404 | + | |
| 4405 | + | |
| 4406 | + | |
4378 | 4407 | | |
4379 | 4408 | | |
4380 | 4409 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3615 | 3615 | | |
3616 | 3616 | | |
3617 | 3617 | | |
| 3618 | + | |
| 3619 | + | |
| 3620 | + | |
| 3621 | + | |
| 3622 | + | |
| 3623 | + | |
| 3624 | + | |
| 3625 | + | |
| 3626 | + | |
| 3627 | + | |
| 3628 | + | |
| 3629 | + | |
| 3630 | + | |
| 3631 | + | |
| 3632 | + | |
| 3633 | + | |
| 3634 | + | |
| 3635 | + | |
| 3636 | + | |
| 3637 | + | |
3618 | 3638 | | |
3619 | 3639 | | |
3620 | 3640 | | |
| |||
3625 | 3645 | | |
3626 | 3646 | | |
3627 | 3647 | | |
3628 | | - | |
3629 | | - | |
3630 | | - | |
3631 | | - | |
3632 | | - | |
3633 | | - | |
3634 | | - | |
3635 | | - | |
3636 | | - | |
3637 | | - | |
3638 | | - | |
3639 | | - | |
| 3648 | + | |
3640 | 3649 | | |
3641 | 3650 | | |
3642 | 3651 | | |
| |||
0 commit comments