Skip to content

Commit 39afd73

Browse files
committed
fix(mobile): wrap exact mention chips at accessible text sizes
Signed-off-by: Logan Johnson <[email protected]>
1 parent 87d7807 commit 39afd73

2 files changed

Lines changed: 25 additions & 1 deletion

File tree

‎mobile/lib/features/channels/message_content.dart‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -940,7 +940,9 @@ class _MentionPill extends StatelessWidget {
940940
offset: const Offset(0, -Grid.quarter),
941941
child: Text('@', style: style),
942942
),
943-
Text(label, style: style, semanticsLabel: semanticsLabel),
943+
Flexible(
944+
child: Text(label, style: style, semanticsLabel: semanticsLabel),
945+
),
944946
],
945947
),
946948
);

‎mobile/test/features/channels/message_content_exact_mentions_test.dart‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import 'package:flutter/material.dart';
12
import 'package:flutter_test/flutter_test.dart';
23
import 'package:buzz/features/channels/message_content.dart';
34
import '../../helpers/widget_helpers.dart';
@@ -20,6 +21,27 @@ void main() {
2021
expect(tester.takeException(), isNull);
2122
});
2223

24+
testWidgets('qualified chips wrap in narrow layouts at large text sizes', (
25+
tester,
26+
) async {
27+
tester.view.physicalSize = const Size(320, 640);
28+
tester.view.devicePixelRatio = 1;
29+
addTearDown(tester.view.reset);
30+
await tester.pumpWidget(
31+
WidgetHelpers.testable(
32+
child: MediaQuery(
33+
data: const MediaQueryData(textScaler: TextScaler.linear(2)),
34+
child: MessageContent(
35+
content: '@Scout (${'b' * 64})',
36+
mentionNames: {'b' * 64: 'Scout'},
37+
),
38+
),
39+
),
40+
);
41+
await tester.pumpAndSettle();
42+
expect(tester.takeException(), isNull);
43+
});
44+
2345
testWidgets('namesake chips resolve exact tagged keys, not tag order', (
2446
tester,
2547
) async {

0 commit comments

Comments
 (0)