Repository navigation
Commit 37dad04
fix(relay/handlers): seed empty manifest pointer on kind:30617 announce
The architectural split Eva's live e2e caught: 30617 created the on-disk
bare repo but no S3 pointer, while the read path (info_refs/upload_pack)
now hydrates from the pointer. Pointer-absent ⇒ Ok(None) ⇒ 404 by Max's
intentional fail-closed, so announce-then-clone returned 404 for every
freshly-announced repo.
Fix: establish the invariant "repo announced ⟺ pointer exists" by
seeding an empty-manifest pointer at the end of `handle_git_repo_
announcement`. After seed:
- `info_refs` stays strictly fail-closed: pointer-absent means
never-announced, not "announced but no pushes." Max's blocker
preserved exactly.
- `live_hydrate_empty_repo` proves clone of an empty hydrated repo works.
- First push CASes the seeded pointer via `IfMatch(etag)`, no
special-case branch. The `IfNoneMatchStar` arm of `cas_publish`
becomes dead code for announced repos.
Two new private helpers in `side_effects.rs`:
- `seed_manifest_pointer(state, owner, repo)` — `put_manifest(empty)` +
`put_pointer(IfNoneMatchStar)`. **Idempotency is constructive, not
trusted**: a `CasOutcome::LostRace` is treated as success ONLY if the
existing pointer body matches the empty manifest's digest. Any other
value (stale from a prior lifecycle, real misconfiguration) surfaces
as `anyhow!` — Max's guardrail #1.
- `emit_initial_ref_state(state, owner, repo)` — kind:30618 over the
seeded empty manifest using Sami's `build_ref_state_event`. Pointer is
the commit; this event is the derived "repo exists, empty" signal —
Max's guardrail #2. Non-fatal on failure: manifest is truth, 30618 is
just notification.
Empty manifests across all repos share canonical bytes (deterministic
serialization by construction) ⟹ same digest ⟹ `put_manifest` is
idempotent at the store level. One blob, many pointers. Pinned by
`empty_manifest_validates` test in manifest.rs with byte-stable canonical
bytes — locks the digest so future serde version bumps don't silently
shift it.
Rollback on seed failure: remove the on-disk repo + the name reservation,
same pattern as hook-install failure. A successful seed but failed emit
leaves the pointer in place (correctly — it's the source of truth).
239/239 relay tests (was 238 + 1 new), clippy + fmt clean.
Co-authored-by: Dawn <c6237ef84fa537c78dcee78efd2d4e59f728859c7f194da42ac51ededfa0be05@users.noreply.sprout>
Signed-off-by: tlongwell-block <[email protected]>1 parent 11085ba commit 37dad04
2 files changed
Lines changed: 180 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
297 | 297 | | |
298 | 298 | | |
299 | 299 | | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
300 | 324 | | |
301 | 325 | | |
302 | 326 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1871 | 1871 | | |
1872 | 1872 | | |
1873 | 1873 | | |
| 1874 | + | |
| 1875 | + | |
| 1876 | + | |
| 1877 | + | |
| 1878 | + | |
| 1879 | + | |
| 1880 | + | |
| 1881 | + | |
| 1882 | + | |
| 1883 | + | |
| 1884 | + | |
| 1885 | + | |
| 1886 | + | |
| 1887 | + | |
| 1888 | + | |
| 1889 | + | |
| 1890 | + | |
1874 | 1891 | | |
1875 | 1892 | | |
1876 | 1893 | | |
1877 | 1894 | | |
1878 | 1895 | | |
1879 | 1896 | | |
1880 | 1897 | | |
| 1898 | + | |
| 1899 | + | |
| 1900 | + | |
| 1901 | + | |
| 1902 | + | |
| 1903 | + | |
| 1904 | + | |
| 1905 | + | |
| 1906 | + | |
| 1907 | + | |
| 1908 | + | |
| 1909 | + | |
| 1910 | + | |
| 1911 | + | |
| 1912 | + | |
| 1913 | + | |
| 1914 | + | |
| 1915 | + | |
| 1916 | + | |
| 1917 | + | |
| 1918 | + | |
| 1919 | + | |
| 1920 | + | |
| 1921 | + | |
| 1922 | + | |
| 1923 | + | |
| 1924 | + | |
| 1925 | + | |
| 1926 | + | |
| 1927 | + | |
| 1928 | + | |
| 1929 | + | |
| 1930 | + | |
| 1931 | + | |
| 1932 | + | |
| 1933 | + | |
| 1934 | + | |
| 1935 | + | |
| 1936 | + | |
| 1937 | + | |
| 1938 | + | |
| 1939 | + | |
| 1940 | + | |
| 1941 | + | |
| 1942 | + | |
| 1943 | + | |
| 1944 | + | |
| 1945 | + | |
| 1946 | + | |
| 1947 | + | |
| 1948 | + | |
| 1949 | + | |
| 1950 | + | |
| 1951 | + | |
| 1952 | + | |
| 1953 | + | |
| 1954 | + | |
| 1955 | + | |
| 1956 | + | |
| 1957 | + | |
| 1958 | + | |
| 1959 | + | |
| 1960 | + | |
| 1961 | + | |
| 1962 | + | |
| 1963 | + | |
| 1964 | + | |
| 1965 | + | |
| 1966 | + | |
| 1967 | + | |
| 1968 | + | |
| 1969 | + | |
| 1970 | + | |
| 1971 | + | |
| 1972 | + | |
| 1973 | + | |
| 1974 | + | |
| 1975 | + | |
| 1976 | + | |
| 1977 | + | |
| 1978 | + | |
| 1979 | + | |
| 1980 | + | |
| 1981 | + | |
| 1982 | + | |
| 1983 | + | |
| 1984 | + | |
| 1985 | + | |
| 1986 | + | |
| 1987 | + | |
| 1988 | + | |
| 1989 | + | |
| 1990 | + | |
| 1991 | + | |
| 1992 | + | |
| 1993 | + | |
| 1994 | + | |
| 1995 | + | |
| 1996 | + | |
| 1997 | + | |
| 1998 | + | |
| 1999 | + | |
| 2000 | + | |
| 2001 | + | |
| 2002 | + | |
| 2003 | + | |
| 2004 | + | |
| 2005 | + | |
| 2006 | + | |
| 2007 | + | |
| 2008 | + | |
| 2009 | + | |
| 2010 | + | |
| 2011 | + | |
| 2012 | + | |
| 2013 | + | |
| 2014 | + | |
| 2015 | + | |
| 2016 | + | |
| 2017 | + | |
| 2018 | + | |
| 2019 | + | |
| 2020 | + | |
| 2021 | + | |
| 2022 | + | |
| 2023 | + | |
| 2024 | + | |
| 2025 | + | |
| 2026 | + | |
| 2027 | + | |
| 2028 | + | |
| 2029 | + | |
| 2030 | + | |
| 2031 | + | |
| 2032 | + | |
| 2033 | + | |
| 2034 | + | |
| 2035 | + | |
| 2036 | + | |
1881 | 2037 | | |
1882 | 2038 | | |
1883 | 2039 | | |
| |||
0 commit comments