Skip to content

Commit 30d2fc5

Browse files
wesbillmanCarl
andauthored
fix(desktop): restore icon-only remote marker (#6491)
## Summary - restore the agreed icon-only cloud marker for an agent from another setup - retain the accessible `From another Buzz setup` label and native hover title - keep the merged loading, hover/focus persistence, and exact-pubkey routing safeguards unchanged - update the duplicate-agent E2E to require an icon with no visible marker text in both autocomplete and Channel members ## Why PR #6401 accidentally changed the agreed compact icon treatment into a visible `Other setup` badge during review hardening. This is the smallest correction and is intended for the active release. ## Testing - Desktop JS: 5,280/5,280 passed - Desktop TypeScript typecheck passed - E2E build passed - focused duplicate-agent Playwright journey: 1/1 passed - file-size gate passed - changed-file Biome and `git diff --check` passed Carl, an automated reviewer, opened this via Wes's GitHub account. Signed-off-by: Wes <[email protected]> Co-authored-by: Carl <32a2e2c9d428ee08902cab75d956da2c1d235a22d4766b0dd4138bf6e2e5db1d@buzz.block.builderlab.xyz>
1 parent 69b1225 commit 30d2fc5

2 files changed

Lines changed: 21 additions & 19 deletions

File tree

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { Cloud } from "lucide-react";
22

33
import { cn } from "@/shared/lib/cn";
4-
import { Badge } from "@/shared/ui/badge";
54

65
const OTHER_SETUP_LABEL = "From another Buzz setup";
76

@@ -13,18 +12,14 @@ export function OtherSetupAgentMarker({
1312
testId?: string;
1413
}) {
1514
return (
16-
<Badge
15+
<span
1716
aria-label={OTHER_SETUP_LABEL}
18-
className={cn(
19-
"gap-1 px-1.5 py-0.5 font-medium normal-case tracking-normal",
20-
className,
21-
)}
17+
className={cn("inline-flex shrink-0", className)}
2218
data-testid={testId}
19+
role="img"
2320
title={OTHER_SETUP_LABEL}
24-
variant="secondary"
2521
>
2622
<Cloud aria-hidden="true" className="h-3 w-3" />
27-
Other setup
28-
</Badge>
23+
</span>
2924
);
3025
}

‎desktop/tests/e2e/mentions.spec.ts‎

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -410,19 +410,25 @@ test("duplicate owned agents preserve provenance and exact pubkey selection", as
410410
0,
411411
);
412412
await expect(relayRow).toContainText("agent");
413-
await expect(
414-
relayRow.getByTestId("mention-agent-provenance"),
415-
).toHaveAttribute("aria-label", "From another Buzz setup");
416-
await expect(
417-
relayRow.getByText("Other setup", { exact: true }),
418-
).toBeVisible();
413+
const relayProvenanceMarker = relayRow.getByTestId(
414+
"mention-agent-provenance",
415+
);
416+
await expect(relayProvenanceMarker).toHaveAttribute(
417+
"aria-label",
418+
"From another Buzz setup",
419+
);
420+
await expect(relayProvenanceMarker).toHaveAttribute(
421+
"title",
422+
"From another Buzz setup",
423+
);
424+
await expect(relayProvenanceMarker).toBeVisible();
425+
await expect(relayProvenanceMarker).toHaveText("");
426+
await expect(relayProvenanceMarker.locator("svg")).toBeVisible();
419427
await expect(managedRow).not.toContainText("managed by you");
420428
await expect(relayRow).not.toContainText("managed by you");
421429

422430
await page.setViewportSize({ width: 760, height: 640 });
423-
await expect(
424-
relayRow.getByText("Other setup", { exact: true }),
425-
).toBeVisible();
431+
await expect(relayProvenanceMarker).toBeVisible();
426432
const rowBox = await relayRow.boundingBox();
427433
const dropdownBox = await dropdown.boundingBox();
428434
expect(rowBox).not.toBeNull();
@@ -495,7 +501,8 @@ test("duplicate owned agents preserve provenance and exact pubkey selection", as
495501
"aria-label",
496502
"From another Buzz setup",
497503
);
498-
await expect(remoteSidebarMarker).toHaveText("Other setup");
504+
await expect(remoteSidebarMarker).toHaveText("");
505+
await expect(remoteSidebarMarker.locator("svg")).toBeVisible();
499506
const remoteSidebarRow = page.getByTestId(`sidebar-member-${relayPubkey}`);
500507
const localSidebarMarker = page.getByTestId(
501508
`sidebar-member-agent-provenance-${managedPubkey}`,

0 commit comments

Comments
 (0)