Repository navigation
Commit 3056641
committed
Close remaining authz gaps in PR #320
Fix authorization holes identified during crossfire security review:
1. trigger_workflow: require workflow ownership for channel workflows.
Previously any channel member could trigger any workflow in that
channel, executing actions attributed to the workflow owner.
2. list_run_approvals: require workflow ownership. Previously any
channel member could read approval records (including actionable
token hashes) for any workflow in the channel.
3. REQ handler: block global subscriptions for channel-restricted
tokens. The fan_out() path delivers global events to all global
subscriptions without per-connection channel filtering, so
restricted tokens must not register global subscriptions.
4. GET /api/events/:id: block global event access for channel-
restricted tokens. Matches the policy already enforced by the
search endpoints (no globals for restricted tokens).
5. list_workflow_runs: fix misleading error string ('trigger' ->
'view runs for').1 parent 87d3f85 commit 3056641
3 files changed
Lines changed: 19 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
68 | 74 | | |
69 | 75 | | |
70 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
399 | 399 | | |
400 | 400 | | |
401 | 401 | | |
402 | | - | |
| 402 | + | |
403 | 403 | | |
404 | 404 | | |
405 | 405 | | |
| |||
439 | 439 | | |
440 | 440 | | |
441 | 441 | | |
442 | | - | |
443 | | - | |
444 | 442 | | |
| 443 | + | |
445 | 444 | | |
446 | 445 | | |
447 | 446 | | |
| |||
478 | 477 | | |
479 | 478 | | |
480 | 479 | | |
481 | | - | |
482 | | - | |
483 | 480 | | |
| 481 | + | |
484 | 482 | | |
485 | 483 | | |
486 | 484 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
145 | 155 | | |
146 | 156 | | |
147 | 157 | | |
| |||
0 commit comments