You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 2bb6578
Browse filesBrowse the repository at this point in the historyBrowse files
Fizz (agent)
committed
Merge branch 'main' into PR #2885 to clear stale-base CI failure
Co-authored-by: Phuoc (Phu) Do <[email protected]>
Signed-off-by: Phuoc (Phu) Do <[email protected]>
* origin/main: (111 commits)
chore(ci): bump desktop smoke E2E timeout to 30 minutes (#3409)
release(chart): publish 0.1.7 (#3393)
feat(acp): steer claude-code and codex agents via _session/steering (#3007)
feat(desktop): apply WebKit rendering workarounds at startup on Linux (#3271)
fix(desktop): stabilize flaky DM expansion E2E ordering assertions (#2004)
docs(contributing): document the Linux system libraries just ci requires (#3396)
fix(desktop): paint community rail full height (#3382)
fix(acp): disable goose cron scheduler in managed agent children (#3144)
feat(desktop): add custom harness inline from agent dialogs (#3252)
chore(compose): remove stale typesense env vars (#3332)
feat(desktop): refine agent catalog sharing (#2439)
fix(desktop): keep drafts out of the Inbox All view (#3217)
docs: restructure DCO guidance into scannable subsection (#3337)
Unify mobile loading spinners (#3314)
fix(desktop): restore the inbox icon in the sidebar (#3341)
fix(desktop): gate codex-acp on a minimum supported version (#3254)
feat(cli): add users set-status command for NIP-38 profile status (#3253)
fix(composer): scope multiline block formatting (#3246)
feat(chart): add relay pod extension points (#3322)
Refine mobile attachment picking (#3313)
...
What problem does this solve? Who runs into it and when?
9
+
10
+
**Proposed solution**
11
+
Describe what you'd like to see.
12
+
13
+
**Alternatives considered**
14
+
What other approaches did you consider?
15
+
16
+
**Additional context**
17
+
Anything else that helps — links, screenshots, prior art.
18
+
19
+
---
20
+
21
+
Before opening: please [search open issues and PRs](https://github.com/block/buzz/issues?q=is%3Aopen) for duplicates — link the closest one, or say "none found".
Copy file name to clipboardExpand all lines: AGENTS.md
+23-2Lines changed: 23 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -108,6 +108,8 @@ re-install hooks after env changes. Before agents run Git or hooks, activate the
108
108
repo's Hermit environment (`. ./bin/activate-hermit`); do not rewrite hook
109
109
commands to compensate for an unconfigured shell `PATH`.
110
110
111
+
**Commit with `git commit -s`.** The required **DCO Check** fails any PR with a commit missing a `Signed-off-by` trailer, and `just hooks` installs a `commit-msg` hook that adds it to commits you create locally (`git rebase` and `git cherry-pick` still need `--signoff`) — if you build commit commands programmatically, include `-s` every time. To repair a branch that already has unsigned commits: `git rebase --signoff main`, then force-push.
112
+
111
113
Additional rules:
112
114
- No `unsafe` code
113
115
- Do not introduce new `unwrap()` or `expect()` in production paths — use `?` and proper error types
@@ -341,9 +343,19 @@ Add specs to `desktop/tests/e2e/` and register them in `playwright.config.ts`
341
343
(`smoke` project `testMatch`). Every test calls `installMockBridge(page)` for
342
344
mock Tauri IPC. Mock pubkey, channel names, and UUIDs live in `e2eBridge.ts`.
343
345
346
+
**Always build with `pnpm build:e2e`, never `pnpm run build`.** The mock Tauri
347
+
bridge is compiled in only for `--mode e2e` (see `installE2eBridgeIfConfigured`
348
+
in `desktop/src/main.tsx`). A plain `pnpm run build` strips it, so
349
+
`window.__TAURI_INTERNALS__` is never defined and **every** mock-mode spec fails
350
+
with `Cannot read properties of undefined (reading 'invoke')` — the app renders
351
+
"Community connection failed" instead of the UI under test. That looks exactly
352
+
like a product bug rather than a build mistake, so it burns real time.
353
+
`pnpm test:e2e:smoke` and `pnpm test:e2e:integration` run the right build for
354
+
you; prefer them over a manual build plus `playwright test`.
355
+
344
356
**Stale server:**`reuseExistingServer: true` means a previous build's server
345
-
serves old code. Kill port 4173 and `pnpm run build` before re-running tests
346
-
after code changes.
357
+
serves old code. Kill port 4173 and re-run `pnpm build:e2e` before re-running
358
+
tests after code changes.
347
359
348
360
**`addInitScript` before bridge:**`page.addInitScript` (localStorage seeding)
349
361
must run BEFORE `installMockBridge(page)` — React reads state on mount, the
@@ -553,6 +565,15 @@ To run the app locally (starts Docker, relay, iOS simulator automatically):
553
565
just mobile-dev
554
566
```
555
567
568
+
When run from a git worktree, `just mobile-dev` (and `just
569
+
mobile-build-android`) give the debug build a per-worktree app identifier
570
+
(keyed to the worktree directory name) and a branch-labelled app name via
571
+
`scripts/mobile-worktree-overrides.sh`, so builds from multiple worktrees
572
+
install side by side. Release builds are unaffected. `just mobile-clean`
573
+
removes stale worktree-suffixed installs from simulators/emulators. See
574
+
[mobile/README.md](mobile/README.md) for direct Xcode / Android Studio
575
+
usage.
576
+
556
577
### Testing Conventions
557
578
558
579
- Prefer **widget tests** over unit tests for UI components — test the
0 commit comments