You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 2076faf
Browse filesBrowse the repository at this point in the historyBrowse files
Fixes Sami's R1 (blocker), R3, and the flagged minor from his review of
4432030. (R2 was independently fixed by ffe760a — Wren's blocker 1/2,
same finding.)
- R1: the parallelism "correction" was backwards. c1bca1b — the
document's pre-existing citation pin — is an unmerged feature-branch
commit that diverged from main Jul 18 and predates #3038 (default
parallelism 24 -> 10, which IS in this PR's base b4f4ed1). The
shutdown-tail worst case is ~87s at default parallelism 10, not ~157s
at 24. Corrected in §Stop, §K8s Grace, and Known Defect 7, with every
line reference in those passages re-verified against b4f4ed1 itself
(drain timeout lib.rs:2636/2657, reap segment :2664-2688, graceful
Ok(()) :2723, !shutdown :2045, Ctrl-C :1635, SIGTERM :1644,
acp.rs:436, types.rs:809, config.rs:293, config.rs:378 for
no_presence). Known Defects gains a citation-pin caveat naming the
stale pin and promising a follow-up re-pin; structural claims
unchanged (87s still blows the 60s grace).
- R3: OnFailure's second prerequisite named. A crash-looping harness
(phase Running, waiting{CrashLoopBackOff}, restartCount > 0) falls
through every deploy-state-machine row and fails the started
criterion while the kubelet is reviving it. §Pod shape now states
that the exit-code contract alone is NOT the green light: a
crash-loop classification row + restartCount treatment in the
started-criterion MUST land before the binding ships OnFailure; L3
conformance item 2 gates on both prerequisites.
- Known Defect 8 (new): coerceConfigValues (ProviderConfigFields.tsx:6)
ships a cleared numeric field as "" — a JSON string — and blessing
inactivity_seconds: 0 puts that arm on a documented path. Desktop fix
(cleared -> omit-or-default) plus provider-side in-band error for
non-numeric numerics.
Verified: git merge-base --is-ancestor c1bca1bb4f4ed1 -> false;
DEFAULT_AGENT_PARALLELISM = 10 at b4f4ed1 types.rs:809; all replaced
line references checked against git show b4f4ed1 in this worktree.
Surviving pool_ready cites (lib.rs:1743/:1320/:2570,
pool_lifecycle.rs:42) hold identically at b4f4ed1 and were left.
Co-authored-by: npub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67d <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>
Signed-off-by: npub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67d <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>
0 commit comments