Skip to content

Commit 171f723

Browse files
committed
test(mobile): verify late work cannot override age decisions
Signed-off-by: Tom Brow <[email protected]>
1 parent 4b5ee1a commit 171f723

1 file changed

Lines changed: 108 additions & 0 deletions

File tree

‎mobile/test/features/age_gate/age_gate_app_test.dart‎

Lines changed: 108 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ import 'package:buzz/features/channels/unread_badge/unread_badge_provider.dart';
99
import 'package:buzz/features/home/home_page.dart';
1010
import 'package:buzz/features/pairing/pairing_provider.dart';
1111
import 'package:buzz/shared/auth/auth.dart';
12+
import 'package:buzz/shared/huddle/huddle.dart';
13+
import 'package:nostr/nostr.dart' as nostr;
14+
import '../../shared/community/community_storage_test.dart'
15+
show FakeSecureStorage;
1216
import 'package:buzz/shared/push/push_bootstrap.dart';
1317
import 'package:buzz/shared/relay/relay.dart';
1418
import 'package:buzz/shared/theme/theme_provider.dart';
@@ -29,6 +33,92 @@ void main() {
2933
.setMockMethodCallHandler(appBadgeChannel, null);
3034
});
3135

36+
testWidgets(
37+
'an in-flight credential commit cannot reopen restricted access',
38+
(tester) async {
39+
SharedPreferences.setMockInitialValues({});
40+
final prefs = await SharedPreferences.getInstance();
41+
final storage = _PausedCommunityStorage();
42+
final age = _MutableAgeSignalNotifier();
43+
var connections = 0;
44+
final relay = RelaySessionNotifier(
45+
socketFactory:
46+
({
47+
required wsUrl,
48+
required nsec,
49+
required onMessage,
50+
required onConnected,
51+
required onDisconnected,
52+
}) {
53+
connections++;
54+
throw StateError(
55+
'Restricted authentication must not open a socket',
56+
);
57+
},
58+
);
59+
final container = ProviderContainer(
60+
overrides: [
61+
savedPrefsProvider.overrideWithValue(prefs),
62+
communityStorageProvider.overrideWithValue(storage),
63+
communitySnapshotWriterProvider.overrideWithValue((_) async {}),
64+
ageSignalProvider.overrideWith(() => age),
65+
relaySessionProvider.overrideWith(() => relay),
66+
pairingProvider.overrideWith(
67+
() => PairingNotifier(
68+
credentialValidator:
69+
({required relayUrl, required nsec}) async {},
70+
),
71+
),
72+
],
73+
);
74+
addTearDown(container.dispose);
75+
await container.read(authProvider.future);
76+
final listener = container.listen(relaySessionProvider, (_, _) {});
77+
addTearDown(listener.close);
78+
await tester.pumpWidget(
79+
UncontrolledProviderScope(container: container, child: const App()),
80+
);
81+
await tester.pump();
82+
final code = base64Url.encode(
83+
utf8.encode(
84+
jsonEncode({
85+
'relayUrl': 'https://relay.example',
86+
'nsec': nostr.Keys.generate().nsec,
87+
}),
88+
),
89+
);
90+
final pairing = container.read(pairingProvider.notifier).pair(code);
91+
await tester.pump();
92+
expect(storage.started.isCompleted, isTrue);
93+
age.setState(AgeSignalState.restricted);
94+
await tester.pump();
95+
expect(find.byType(AgeRestrictionPage), findsOneWidget);
96+
storage.release.complete();
97+
await pairing;
98+
await tester.pump();
99+
expect((await storage.loadAll()), hasLength(1));
100+
expect(
101+
(await container.read(authProvider.future)).status,
102+
AuthStatus.authenticated,
103+
);
104+
expect(container.read(pairingProvider).status, PairingStatus.idle);
105+
expect(find.byType(AgeRestrictionPage), findsOneWidget);
106+
expect(
107+
container.read(relaySessionProvider).status,
108+
SessionStatus.disconnected,
109+
);
110+
expect(connections, 0);
111+
expect(
112+
container.read(huddleSessionProvider).phase,
113+
HuddleSessionPhase.idle,
114+
);
115+
await tester.pumpWidget(const SizedBox.shrink());
116+
listener.close();
117+
container.dispose();
118+
await tester.pump(const Duration(milliseconds: 1));
119+
},
120+
);
121+
32122
test('backs off repeated snapshot transition failures', () {
33123
expect(ageSignalPushSnapshotRetryDelay(0), const Duration(seconds: 5));
34124
expect(ageSignalPushSnapshotRetryDelay(1), const Duration(seconds: 10));
@@ -204,6 +294,7 @@ void main() {
204294
) async {
205295
final response = Completer<Object?>();
206296
var requests = 0;
297+
var restrictions = 0;
207298
final relaySession = _CountingRelaySessionNotifier();
208299
TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger
209300
.setMockMethodCallHandler(ageSignalChannel, (_) {
@@ -224,6 +315,9 @@ void main() {
224315
ageAllowedNotificationRestorerProvider.overrideWithValue(
225316
() async {},
226317
),
318+
ageRestrictedNotificationPurgerProvider.overrideWithValue(() async {
319+
restrictions++;
320+
}),
227321
savedPrefsProvider.overrideWithValue(prefs),
228322
],
229323
child: const AgeSignalPushBootstrap(child: App()),
@@ -251,6 +345,7 @@ void main() {
251345
await tester.pump();
252346
await tester.pump();
253347
final restricted = outcome == 'minor';
348+
expect(restrictions, restricted ? 1 : 0);
254349
expect(
255350
find.byType(AgeRestrictionPage),
256351
restricted ? findsOneWidget : findsNothing,
@@ -422,3 +517,16 @@ class _RecordingPairAuthNotifier extends _UnauthenticatedAuthNotifier {
422517
imports += 1;
423518
}
424519
}
520+
521+
class _PausedCommunityStorage extends CommunityStorage {
522+
_PausedCommunityStorage() : super(secure: FakeSecureStorage());
523+
final started = Completer<void>();
524+
final release = Completer<void>();
525+
526+
@override
527+
Future<void> save(Community community) async {
528+
started.complete();
529+
await release.future;
530+
await super.save(community);
531+
}
532+
}

0 commit comments

Comments
 (0)