Repository navigation
Commit 1185709
feat(git/cas_publish): the §Push step 2-7 commit point
Adds crates/sprout-relay/src/api/git/cas_publish.rs — the pure async
function that turns a post-receive-pack workspace into a durable manifest
CAS. Composes Dawn's GitStore primitives (put_pack, put_manifest,
get_pointer, put_pointer) and Dawn's Manifest schema (canonical_bytes,
Inv_Closed at compose time) into the spec's step 2-7 sequence:
read pointer (e, d_before) §step 3
fetch + verify m_before §step 3 + A1 detectability
snapshot refs + symref-HEAD from disk
pack new objects via pack-objects --revs §step 1-2
put_pack(bytes) -> packs/<sha256> §step 2 (A1)
compose m_after (parent packs + new pack) §step 5
put_manifest(canonical_bytes) -> manifests/<sha256> §step 6
put_pointer(IfMatch(e) | IfNoneMatchStar) §step 7 (CAS)
Won -> CasSuccess { manifest, manifest_key }
Lost -> CasError::Conflict (→ HTTP 409)
The function returns *before* a Response is constructed — it is called
from finalize_push, which is the unique site that builds a push 2xx, so
the structural seam still enforces Theorem 1 (success-after-CAS).
What this deliberately does NOT do (each with citation):
- No retry on LostRace. Per Sami's TLA-action guidance: the receive-pack
output is derived against a now-superseded parent; reusing it would
violate Inv_RefDerivedFromParent. Client re-pushes, which re-hydrates
+ re-runs receive-pack against the advanced pointer — the only safe
retry, which git already performs. Spec §Push step 7: 'GOTO 3 (retry)
or respond non-ff' — both arms safe; we take non-ff.
- No kind:30618 emission. That is derived after CAS — finalize_push
calls Sami's build_ref_state_event over m_after.refs / m_after.head
on Ok. Spec §Implementation Correspondence: 'kind:30618 is derived
after CAS, never the commit.'
- No advisory lock. Spec §Push 'no advisory lock in v1' — writer
serialization is the CAS. A mutex would hide the contention Inv_NoFork
proves safe.
Pre-CAS fail-closed paths:
- Pointer body not 64-hex digest -> ManifestReadFailed (pointer corrupt).
- Manifest GET 404 under non-empty pointer -> ManifestReadFailed.
- Digest mismatch on manifest read -> ManifestReadFailed (A1 violation
surfaced as caller-side error, never silent).
- pack-objects exit non-zero -> PackCapture (no write attempted).
8 unit tests pin pointer_key (.git stripping), digest derivation
(prefix invariant), and compose_after (Inv_Closed coverage, sort,
dedupe, refs-only-no-new-pack, first-push). 227 relay tests green.
The integration into finalize_push lands separately — Eva owns the
AppState::git_store wiring + main.rs startup probe gate. This module
is callable today: cas_publish(&store, repo_path, owner, repo,
&refs_before) -> Result<CasSuccess, CasError>.
Refs:
- docs/git-on-object-storage.md §Push step 2-7, §Implementation
Correspondence, §Mechanized Verification (Inv_NoFork,
Inv_RefEffectApplied, Inv_RefDerivedFromParent, Inv_Closed).
Also makes transport::harden_git_env pub(crate) for reuse by
cas_publish's two subprocess sites (for-each-ref, pack-objects).
Co-authored-by: Tyler Longwell <[email protected]>1 parent e4902e3 commit 1185709
3 files changed
Lines changed: 536 additions & 1 deletion
0 commit comments