You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 0b30d07
Browse filesBrowse the repository at this point in the historyBrowse files
committed
fix(agents): require the visible provider for runtime-less definitions
Address wesbillman's blocking review: the Customize provider gate keyed off
runtimeSupportsLlmProviderSelection(runtime), which is false for a blank
runtime. But a runtime-less legacy/builtin definition still exposes the
provider picker via blankRuntimeModelProviderEditable, so Save could persist
`provider: undefined` despite the visible picker (also reachable after picking
"No preference").
Gate the provider requirement on the field-visibility capability
runtimeCanChooseLlmProvider instead — the same predicate that drives whether
the picker is shown — for providerIsRequired, customAiPairSatisfied, and the
submit-block reason. Codex/Claude stay unaffected (picker hidden -> provider
not required), preserving Ian's original fix.
Adds a runtime-less edit regression test (e2e case 11, seeded with no
available runtime so the dialog does not auto-seed a runtime) plus a policy
unit test; verified the e2e fails without the gate change.
Co-authored-by: Atish Patel <[email protected]>
Signed-off-by: Atish Patel <[email protected]>
Co-authored-by: WorkerBeeGPT <c5c455215c2506cb8ba776518cec804af62d3a0526e32d496a22072e395042b9@buzz>
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
0 commit comments