You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 091c4e7
Browse filesBrowse the repository at this point in the historyBrowse files
fix(desktop): humanize turn-failure class, show its age, drop the duplicate exit line
Addresses the three review nits on #2240, all in the turn-failure line:
- The raw `error_class` token no longer reaches the UI. `friendlyTurnErrorClass`
maps the closed set from `classify_turn_failure` to human copy ("Timed out",
"Agent crashed"), falls back to the coarse `outcome` for pre-`error_class`
harnesses, and title-cases anything unmapped so a class added to the Rust enum
degrades to "Some New Class" instead of leaking `some_new_class`.
- `TurnFailure.timestamp` was stored and asserted but never rendered. It is now
`failedAt` — the agent-host timestamp translated through that agent's skew
offset, so it is a desktop-clock instant the UI can age against — and it
renders as a relative label ("Timed out, 3m ago"). Unlike a live turn's
`anchorAt` it is fixed at write time: a failure is a terminal past moment shown
at minute granularity, so sub-second retroactive drift is invisible, and a
stable value keeps `useSyncExternalStore` correct without a snapshot cache.
The 1-minute tick lives in a leaf component, so only rows actually showing a
failure own an interval.
- An `exited` turn failure no longer renders beside the process-level
`friendlyError`, where one crash read as two independent errors. Every other
class describes a failure the process line does not explain, so it still shows.
Gates: desktop `tsc --noEmit` clean, `biome check .` clean, file-size/px-text/
pubkey checks clean, test suite 3351/0 (up 12).
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
0 commit comments