|
1 | 1 | import assert from "node:assert/strict"; |
2 | 2 | import test from "node:test"; |
3 | 3 |
|
4 | | -import { getDiscoveredPersonaModelOptions } from "./usePersonaModelDiscovery.ts"; |
| 4 | +import { |
| 5 | + deriveModelDiscoveryPending, |
| 6 | + getDiscoveredPersonaModelOptions, |
| 7 | + isCacheableDiscoveryResponse, |
| 8 | + synthesizeEmptyDiscoveryStatus, |
| 9 | +} from "./usePersonaModelDiscovery.ts"; |
5 | 10 |
|
6 | 11 | function response(overrides = {}) { |
7 | 12 | return { |
@@ -110,3 +115,146 @@ test("returns null when discovery is unsupported or empty", () => { |
110 | 115 | ); |
111 | 116 | assert.equal(getDiscoveredPersonaModelOptions(null, ""), null); |
112 | 117 | }); |
| 118 | + |
| 119 | +// ── synthesizeEmptyDiscoveryStatus ──────────────────────────────────────────── |
| 120 | + |
| 121 | +test("synthesizeEmptyDiscoveryStatus_emptyModels_producesWarningStatus", () => { |
| 122 | + const status = synthesizeEmptyDiscoveryStatus( |
| 123 | + response({ models: [], agentName: "Claude Code" }), |
| 124 | + "", |
| 125 | + ); |
| 126 | + assert.equal(status?.tone, "warning"); |
| 127 | + assert.match(status?.message ?? "", /Claude Code/); |
| 128 | + assert.match(status?.message ?? "", /reported no models/); |
| 129 | +}); |
| 130 | + |
| 131 | +test("synthesizeEmptyDiscoveryStatus_supportsSwitchingFalse_producesWarningStatus", () => { |
| 132 | + const status = synthesizeEmptyDiscoveryStatus( |
| 133 | + response({ |
| 134 | + supportsSwitching: false, |
| 135 | + models: [{ id: "gpt-4", name: "GPT-4", description: null }], |
| 136 | + agentName: "Codex", |
| 137 | + }), |
| 138 | + "", |
| 139 | + ); |
| 140 | + assert.equal(status?.tone, "warning"); |
| 141 | + assert.match(status?.message ?? "", /Codex/); |
| 142 | +}); |
| 143 | + |
| 144 | +test("synthesizeEmptyDiscoveryStatus_withUsableModels_returnsNull", () => { |
| 145 | + assert.equal( |
| 146 | + synthesizeEmptyDiscoveryStatus( |
| 147 | + response({ |
| 148 | + models: [ |
| 149 | + { id: "claude-sonnet-5", name: "Claude Sonnet 5", description: null }, |
| 150 | + ], |
| 151 | + agentName: "Claude Code", |
| 152 | + }), |
| 153 | + "", |
| 154 | + ), |
| 155 | + null, |
| 156 | + ); |
| 157 | +}); |
| 158 | + |
| 159 | +test("synthesizeEmptyDiscoveryStatus_emptyAgentName_usesGenericFallback", () => { |
| 160 | + const status = synthesizeEmptyDiscoveryStatus( |
| 161 | + response({ models: [], agentName: "" }), |
| 162 | + "", |
| 163 | + ); |
| 164 | + assert.equal(status?.tone, "warning"); |
| 165 | + assert.match(status?.message ?? "", /This agent/); |
| 166 | +}); |
| 167 | + |
| 168 | +// ── isCacheableDiscoveryResponse ────────────────────────────────────────────── |
| 169 | + |
| 170 | +test("isCacheableDiscoveryResponse_withUsableModels_returnsTrue", () => { |
| 171 | + assert.equal( |
| 172 | + isCacheableDiscoveryResponse( |
| 173 | + response({ |
| 174 | + models: [ |
| 175 | + { id: "claude-sonnet-5", name: "Claude Sonnet 5", description: null }, |
| 176 | + ], |
| 177 | + }), |
| 178 | + "", |
| 179 | + ), |
| 180 | + true, |
| 181 | + ); |
| 182 | +}); |
| 183 | + |
| 184 | +test("isCacheableDiscoveryResponse_emptyModels_returnsFalse", () => { |
| 185 | + // An empty-result response must not be cached so close→reopen retries |
| 186 | + // discovery after the user installs or signs into the CLI. |
| 187 | + assert.equal( |
| 188 | + isCacheableDiscoveryResponse(response({ models: [] }), ""), |
| 189 | + false, |
| 190 | + ); |
| 191 | +}); |
| 192 | + |
| 193 | +test("isCacheableDiscoveryResponse_supportsSwitchingFalse_returnsFalse", () => { |
| 194 | + assert.equal( |
| 195 | + isCacheableDiscoveryResponse( |
| 196 | + response({ |
| 197 | + supportsSwitching: false, |
| 198 | + models: [{ id: "gpt-4", name: "GPT-4", description: null }], |
| 199 | + }), |
| 200 | + "", |
| 201 | + ), |
| 202 | + false, |
| 203 | + ); |
| 204 | +}); |
| 205 | + |
| 206 | +// ── deriveModelDiscoveryPending ──────────────────────────────────────────────── |
| 207 | + |
| 208 | +test("deriveModelDiscoveryPending_stillLoading_isTrue", () => { |
| 209 | + assert.equal( |
| 210 | + deriveModelDiscoveryPending({ |
| 211 | + modelDiscoveryLoading: true, |
| 212 | + modelDiscoveryKey: "key", |
| 213 | + activeModelDiscoveryData: null, |
| 214 | + activeModelDiscoveryStatus: null, |
| 215 | + }), |
| 216 | + true, |
| 217 | + ); |
| 218 | +}); |
| 219 | + |
| 220 | +test("deriveModelDiscoveryPending_keySetDataNullStatusNull_isTrue", () => { |
| 221 | + // A key is set but neither data nor status has arrived yet → still pending. |
| 222 | + assert.equal( |
| 223 | + deriveModelDiscoveryPending({ |
| 224 | + modelDiscoveryLoading: false, |
| 225 | + modelDiscoveryKey: "key", |
| 226 | + activeModelDiscoveryData: null, |
| 227 | + activeModelDiscoveryStatus: null, |
| 228 | + }), |
| 229 | + true, |
| 230 | + ); |
| 231 | +}); |
| 232 | + |
| 233 | +test("deriveModelDiscoveryPending_resolvedEmptyResponse_isNotPending", () => { |
| 234 | + // A resolved-but-empty response sets data non-null and status to a warning. |
| 235 | + // Neither condition for pending is met — the hook must not spin forever. |
| 236 | + const emptyResponse = response({ models: [] }); |
| 237 | + const warningStatus = { message: "no models", tone: "warning" }; |
| 238 | + assert.equal( |
| 239 | + deriveModelDiscoveryPending({ |
| 240 | + modelDiscoveryLoading: false, |
| 241 | + modelDiscoveryKey: "key", |
| 242 | + activeModelDiscoveryData: emptyResponse, |
| 243 | + activeModelDiscoveryStatus: warningStatus, |
| 244 | + }), |
| 245 | + false, |
| 246 | + ); |
| 247 | +}); |
| 248 | + |
| 249 | +test("deriveModelDiscoveryPending_noKey_isNotPending", () => { |
| 250 | + // key=null means discovery is not expected (e.g. dialog closed). |
| 251 | + assert.equal( |
| 252 | + deriveModelDiscoveryPending({ |
| 253 | + modelDiscoveryLoading: false, |
| 254 | + modelDiscoveryKey: null, |
| 255 | + activeModelDiscoveryData: null, |
| 256 | + activeModelDiscoveryStatus: null, |
| 257 | + }), |
| 258 | + false, |
| 259 | + ); |
| 260 | +}); |
0 commit comments