Merged
Conversation
skimage/viewer/qt.py
Outdated
There was a problem hiding this comment.
This logic is not quite right. The reason for this try cascade is that when mpl added QT5 support we re-named qt4_compat -> qt_compat as it smooths over the differences between pyqt4/pysides/pyqt5 so you can not assume that if this import succeeds then you want to use qt5
Author
There was a problem hiding this comment.
when does that import fail then? if matplotlib is older than the version that added Qt5 support?
Owner
|
Thanks @flying-sheep! |
Author
|
no problem :D |
blink1073
pushed a commit
that referenced
this pull request
Jul 12, 2015
Switched to cnp where applicable.
blink1073
pushed a commit
that referenced
this pull request
Sep 4, 2015
blink1073
pushed a commit
that referenced
this pull request
Dec 14, 2015
Avoids crash of active contour example when run with old scipy version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see scikit-image#1316