revert: Partially revert changes from #318 in link navigation#320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow-up to #318
Summary of the issue:
An unintended change in #318 caused some issues: for example, the content of the line where the cursor was located was not reported after following a jump link.
Description of how this pull request fixes the issue:
Revert the use of
end=endinperform_wormhole_navigationcall withinnavigate_to_link_by_range, restoringend=None.This fixes a
start > enderror encountered after navigating internal links. The error was caused by the combination of thestart += 1adjustment (introduced in #318 to fix cursor positioning) and passing an explicitendvalue derived fromtarget_info.position.Restoring
end=Noneresolves the range error by instructing the view to only set the cursor position (start) without selecting a potentially invalid range, while still respecting the necessary cursor adjustment from #318.Testing performed:
Manual testing
Known issues with pull request:
unknown