Adding port number for Black Lager encryption suite.#3
Merged
Conversation
ahmedkadd
requested changes
Nov 29, 2022
ahmedkadd
left a comment
ahmedkadd
left a comment
There was a problem hiding this comment.
The port number definition looks good. Consider adding more documentation as described in the comment.
| PRIVATE_APP = 256; | ||
|
|
||
| /* | ||
| * Black Lager encryption port |
There was a problem hiding this comment.
Consider adding more description of what the packets sent over the Black Lager port too. Mention it is a text messaging application with digital signatures.
ahmedkadd
approved these changes
Nov 29, 2022
ahmedkadd
left a comment
ahmedkadd
left a comment
There was a problem hiding this comment.
More description has been added. Looks good. Approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist before merging