Skip to content

Commit a6598e1

Browse files
committed
[flutter_tools] Verify sibling extension fault isolation in ExtensionCleanManager
Verify in `extension_clean_manager_test.dart` that a throwing `CleanService` extension logs an error without preventing a sibling extension from receiving its `CleanEnvironment` during `ExtensionCleanManager.cleanProject`. Part of flutter#190755
1 parent 3e38019 commit a6598e1

1 file changed

Lines changed: 54 additions & 29 deletions

File tree

‎packages/flutter_tools/test/general.shard/extension_protocol/extension_clean_manager_test.dart‎

Lines changed: 54 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -144,39 +144,64 @@ void main() {
144144
expect(receivedEnv.buildDir, customBuildDir.absolute.uri);
145145
});
146146

147-
test('logs error when extension clean RPC throws without failing caller', () async {
148-
void failingEntryPoint(SendPort sendPort) {
149-
ToolExtensionEntryPoint.run(
150-
sendPort,
151-
<ToolExtensionService>[
152-
_FakeCleanService((CleanEnvironment _) async {
153-
throw StateError('Simulated extension clean failure');
154-
}),
155-
],
156-
supportedPlatforms: const <String>{'linux'},
147+
test(
148+
'logs error when extension clean RPC throws without failing caller or sibling extensions',
149+
() async {
150+
final verifyPort = ReceivePort();
151+
addTearDown(verifyPort.close);
152+
final SendPort verifySendPort = verifyPort.sendPort;
153+
154+
void failingEntryPoint(SendPort sendPort) {
155+
ToolExtensionEntryPoint.run(
156+
sendPort,
157+
<ToolExtensionService>[
158+
_FakeCleanService((CleanEnvironment _) async {
159+
throw StateError('Simulated extension clean failure');
160+
}),
161+
],
162+
supportedPlatforms: const <String>{'linux'},
163+
);
164+
}
165+
166+
void succeedingEntryPoint(SendPort sendPort) {
167+
ToolExtensionEntryPoint.run(
168+
sendPort,
169+
<ToolExtensionService>[
170+
_FakeCleanService((CleanEnvironment env) async {
171+
verifySendPort.send(env.toMap());
172+
}),
173+
],
174+
supportedPlatforms: const <String>{'linux'},
175+
);
176+
}
177+
178+
final manager = ExtensionManager(
179+
hostPlatform: HostPlatform.linux_x64,
180+
logger: logger,
181+
featureFlags: TestFeatureFlags(isToolExtensionsEnabled: true),
182+
entryPoints: <ExtensionEntryPoint>[failingEntryPoint, succeedingEntryPoint],
157183
);
158-
}
184+
addTearDown(manager.dispose);
159185

160-
final manager = ExtensionManager(
161-
hostPlatform: HostPlatform.linux_x64,
162-
logger: logger,
163-
featureFlags: TestFeatureFlags(isToolExtensionsEnabled: true),
164-
entryPoints: <ExtensionEntryPoint>[failingEntryPoint],
165-
);
166-
addTearDown(manager.dispose);
186+
final cleanManager = ExtensionCleanManager(
187+
extensionManager: manager,
188+
featureFlags: TestFeatureFlags(isToolExtensionsEnabled: true),
189+
logger: logger,
190+
);
167191

168-
final cleanManager = ExtensionCleanManager(
169-
extensionManager: manager,
170-
featureFlags: TestFeatureFlags(isToolExtensionsEnabled: true),
171-
logger: logger,
172-
);
192+
final Directory projectDir = fs.directory('/my_project')..createSync(recursive: true);
193+
projectDir.childFile('pubspec.yaml').writeAsStringSync('name: test_app\n');
194+
final FlutterProject project = FlutterProject.fromDirectoryTest(projectDir, logger);
195+
final Directory buildDir = projectDir.childDirectory('build');
173196

174-
final Directory projectDir = fs.directory('/my_project')..createSync(recursive: true);
175-
projectDir.childFile('pubspec.yaml').writeAsStringSync('name: test_app\n');
176-
final FlutterProject project = FlutterProject.fromDirectoryTest(projectDir, logger);
197+
await cleanManager.cleanProject(project, buildDirectory: buildDir);
198+
expect(logger.errorText, contains('Failed to clean extension artifacts'));
177199

178-
await cleanManager.cleanProject(project, buildDirectory: projectDir.childDirectory('build'));
179-
expect(logger.errorText, contains('Failed to clean extension artifacts'));
180-
});
200+
final Object? rawReceived = await verifyPort.first;
201+
final receivedEnv = CleanEnvironment.fromJson(rawReceived! as Map<String, Object?>);
202+
expect(receivedEnv.projectRoot, project.directory.absolute.uri);
203+
expect(receivedEnv.buildDir, buildDir.absolute.uri);
204+
},
205+
);
181206
});
182207
}

0 commit comments

Comments
 (0)