Repository navigation
Commit 8efc672
authored
Don't terminate the shared EGL display when an engine is disposed (flutter#194520)
The EGL display is shared across the process (by all engines and GDK),
so calling eglTerminate() when one engine's FlOpenGLManager is disposed
breaks rendering for any remaining engines. This doesn't occur in the
standard case of a single engine, only when multiple engines are used.
Regression introduced in flutter#172330.
Fixes flutter#1943991 parent 72f018b commit 8efc672
3 files changed
Lines changed: 57 additions & 1 deletion
File tree
- engine/src/flutter/shell/platform/linux
- testing
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | 40 | | |
42 | 41 | | |
43 | 42 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
256 | 257 | | |
257 | 258 | | |
258 | 259 | | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
423 | 423 | | |
424 | 424 | | |
425 | 425 | | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
426 | 436 | | |
427 | 437 | | |
428 | 438 | | |
| |||
852 | 862 | | |
853 | 863 | | |
854 | 864 | | |
| 865 | + | |
855 | 866 | | |
856 | 867 | | |
857 | 868 | | |
| |||
966 | 977 | | |
967 | 978 | | |
968 | 979 | | |
| 980 | + | |
969 | 981 | | |
970 | 982 | | |
971 | 983 | | |
| |||
0 commit comments