Repository navigation
Commit 8bae903
[flutter_tools] Use resolved application ID for app link settings (flutter#189488)
Fixes flutter#179705
The AppLinkSettings Gradle task was writing `variant.namespace` into the
generated JSON. When an app sets `applicationId` from an environment
variable or Gradle property, the namespace can differ from the resolved
application ID.
This updates the task to use AGP's resolved
`ApplicationVariant.applicationId` and adds an integration test covering
an environment-backed `applicationId`.
Tests:
- `dart run test -j1
test/integration.shard/android_gradle_outputs_app_link_settings_test.dart`
- `FLUTTER_TEST_DISABLE_FS_GUARD=true dart run test -j1
test/commands.shard/hermetic/android_analyze_test.dart`
Co-authored-by: Gray Mackall <[email protected]>
Co-authored-by: Matt Boetger <[email protected]>1 parent 325d3b9 commit 8bae903
3 files changed
Lines changed: 67 additions & 4 deletions
File tree
- packages/flutter_tools
- gradle/src/main/kotlin
- tasks
- test/integration.shard
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
1175 | 1176 | | |
1176 | 1177 | | |
1177 | 1178 | | |
| 1179 | + | |
| 1180 | + | |
| 1181 | + | |
1178 | 1182 | | |
1179 | 1183 | | |
1180 | | - | |
| 1184 | + | |
1181 | 1185 | | |
1182 | 1186 | | |
1183 | 1187 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
50 | 54 | | |
51 | 55 | | |
52 | 56 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
427 | 427 | | |
428 | 428 | | |
429 | 429 | | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
430 | 485 | | |
431 | 486 | | |
432 | 487 | | |
| |||
0 commit comments