Repository navigation
Commit 68ed60d
committed
[flutter_tools] Guard getLogReader against synchronous connection disposal
Replaces `late final readerFuture` in `ExtensionBackedDevice.getLogReader`
with a nullable future and disposal guard so synchronous startup failures on
an already-disposed `ExtensionConnection` complete cleanly without throwing a
`LateInitializationError` or caching a dead reader, and widens active
app-scoped log streams to device-wide when a second application requests logs.
Part of flutter#190755
Part of flutter#190750
Part of flutter#1907531 parent 86e7282 commit 68ed60d
2 files changed
Lines changed: 22 additions & 6 deletions
File tree
- packages/flutter_tools
- lib/src/experimental
- test/general.shard/extension_protocol
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
736 | 736 | | |
737 | 737 | | |
738 | 738 | | |
739 | | - | |
| 739 | + | |
740 | 740 | | |
741 | 741 | | |
742 | 742 | | |
| |||
748 | 748 | | |
749 | 749 | | |
750 | 750 | | |
751 | | - | |
| 751 | + | |
| 752 | + | |
752 | 753 | | |
753 | 754 | | |
754 | 755 | | |
| |||
757 | 758 | | |
758 | 759 | | |
759 | 760 | | |
760 | | - | |
| 761 | + | |
| 762 | + | |
761 | 763 | | |
762 | 764 | | |
763 | 765 | | |
764 | 766 | | |
765 | | - | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
766 | 770 | | |
767 | 771 | | |
768 | 772 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1845 | 1845 | | |
1846 | 1846 | | |
1847 | 1847 | | |
1848 | | - | |
1849 | | - | |
| 1848 | + | |
| 1849 | + | |
| 1850 | + | |
1850 | 1851 | | |
1851 | 1852 | | |
1852 | 1853 | | |
1853 | 1854 | | |
| 1855 | + | |
| 1856 | + | |
| 1857 | + | |
| 1858 | + | |
| 1859 | + | |
| 1860 | + | |
| 1861 | + | |
| 1862 | + | |
| 1863 | + | |
| 1864 | + | |
| 1865 | + | |
1854 | 1866 | | |
1855 | 1867 | | |
1856 | 1868 | | |
| |||
0 commit comments