Repository navigation
Commit 5b39e0b
authored
[flutter_tools] Inject CrashReportSender into SwiftPM migration (flutter#196315)
Previously, `SwiftPackageManagerIntegrationMigration` accepted `required
bool reportCrashes` and instantiated `CrashReportSender` inline with an
unmocked `http.Client()`. As a result, the `validate project settings`
unit tests in `swift_package_manager_integration_migration_test.dart`
made live HTTPS `POST` requests to
`https://clients2.google.com/cr/report`, causing `tool_tests_general`
presubmits to fail with `TimeoutException` whenever the remote endpoint
took longer than 2 seconds.
Replace `bool reportCrashes` with an optional `CrashReportSender
Function()? crashReportSenderFactory` passed at the `buildXcodeProject`
and `buildMacOS` production call sites (when
`!botDetector.isRunningOnBot`) so `CrashReportSender` and its
`http.Client` are only allocated when a migration crash occurs, pass a
`FakeCrashReportSender` factory in
`swift_package_manager_integration_migration_test.dart`, and re-enable
the two `validate project settings` tests that were temporarily skipped
in flutter#196310.
Fixes flutter#196307
Previous output:
```
00:32 +3002 ~2 -1: test/general.shard/migrations/swift_package_manager_integration_migration_test.dart: Flutter Package Migration validate project settings throw if settings fail to compile [E]
TimeoutException after 0:00:02.000000: Test timed out after 2 seconds.
dart:isolate _RawReceivePort._handleMessage
```
Current output:
```
+157: All tests passed!
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md1 parent b98afb5 commit 5b39e0b
4 files changed
Lines changed: 144 additions & 125 deletions
File tree
- packages/flutter_tools
- lib/src
- ios
- macos
- migrations
- test/general.shard/migrations
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| 46 | + | |
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
| |||
170 | 171 | | |
171 | 172 | | |
172 | 173 | | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
173 | 182 | | |
174 | | - | |
175 | 183 | | |
176 | 184 | | |
177 | 185 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| |||
151 | 152 | | |
152 | 153 | | |
153 | 154 | | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
154 | 163 | | |
155 | | - | |
156 | 164 | | |
157 | 165 | | |
158 | 166 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
17 | 15 | | |
18 | 16 | | |
19 | 17 | | |
| |||
35 | 33 | | |
36 | 34 | | |
37 | 35 | | |
38 | | - | |
39 | 36 | | |
40 | 37 | | |
| 38 | + | |
41 | 39 | | |
42 | 40 | | |
43 | 41 | | |
| |||
46 | 44 | | |
47 | 45 | | |
48 | 46 | | |
| 47 | + | |
49 | 48 | | |
50 | | - | |
51 | 49 | | |
52 | 50 | | |
53 | 51 | | |
| |||
171 | 169 | | |
172 | 170 | | |
173 | 171 | | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
| 172 | + | |
180 | 173 | | |
181 | 174 | | |
182 | 175 | | |
| |||
247 | 240 | | |
248 | 241 | | |
249 | 242 | | |
250 | | - | |
| 243 | + | |
251 | 244 | | |
252 | 245 | | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
| 246 | + | |
260 | 247 | | |
261 | 248 | | |
262 | 249 | | |
263 | 250 | | |
264 | 251 | | |
265 | 252 | | |
266 | 253 | | |
267 | | - | |
| 254 | + | |
268 | 255 | | |
269 | 256 | | |
270 | 257 | | |
| |||
0 commit comments