Change UnMock task to Gradle's dependency transform#83
Merged
Conversation
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-all.zip |
There was a problem hiding this comment.
we could switch to binary distribution, I don't see any reason why all is needed
Contributor
Author
There was a problem hiding this comment.
It was all before, so I did not want to change it. Plus, from what I understand, all includes sources/javadocs, which makes IDE experience a bit better when interacting with Gradle scripts.
bjoernQ
approved these changes
Jun 24, 2024
bjoernQ
left a comment
bjoernQ
left a comment
Owner
There was a problem hiding this comment.
LGTM - Thanks! Going to merge this and hopefully I can publish a new version next weekend
Contributor
Author
|
Thanks! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like Unmock is doing exactly what Gradle's dependency transformation system was designed to do. So this PR moves Unmock from being a task to a dependency transformer, which allows across-module caching.
This fixes #82.